From: Nithishvelan M <mnithishvelan@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Nuno Sa <nuno.sa@analog.com>,
Michael Hennerich <Michael.Hennerich@analog.com>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Nithishvelan M <mnithishvelan@gmail.com>
Subject: [PATCH] staging: iio: impedance-analyzer: ad5933: use devm_mutex_init()
Date: Tue, 27 Oct 2026 16:08:29 +0000 [thread overview]
Message-ID: <20261027160829.1731-1-mnithishvelan@gmail.com> (raw)
Replace mutex_init() with devm_mutex_init() in ad5933_probe() and
check its return value. The driver already uses devm_* helpers for its
other resources and has no remove() callback, so this ensures the
mutex is destroyed automatically on teardown when mutex debugging is
enabled.
No functional change intended. Compile-tested only.
Signed-off-by: Nithishvelan M <mnithishvelan@gmail.com>
---
drivers/staging/iio/impedance-analyzer/ad5933.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
index c05a5f4b4..51d73c5ab 100644
--- a/drivers/staging/iio/impedance-analyzer/ad5933.c
+++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
@@ -672,7 +672,9 @@ static int ad5933_probe(struct i2c_client *client)
i2c_set_clientdata(client, indio_dev);
st->client = client;
- mutex_init(&st->lock);
+ ret = devm_mutex_init(&client->dev, &st->lock);
+ if (ret)
+ return ret;
ret = devm_regulator_get_enable_read_voltage(&client->dev, "vdd");
if (ret < 0)
--
2.53.0
next reply other threads:[~2026-10-27 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 16:08 Nithishvelan M [this message]
2026-10-27 16:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261027160829.1731-1-mnithishvelan@gmail.com \
--to=mnithishvelan@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®