From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=141.14.17.11 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793127297; b=lyoL9uHw/A3cbtQDIa2Xa+Ir/aara0NcbrhzkSZ+xxrgF+dbz35Sps9O7T+e6pfICN0O tF86yRmQ8SyQ7l8AuJaHX+V2D6WQtxS+0VGJ4idVFUhRNDi0Bm/7VHisGqG5RiZKmfsF/ rNo4ad08clqVSA8VFFEZsbcxuZu+EITBpiWVAnMHwG1hRICwHfIRuqnGCbfs8JvljpxjR j6vwo7eXOZ+OITrI7D26RX3wAOlv9IpIFzF62NX709X9sZPuzydBmAH/u4hircLjCppCe U9cjCgDKTHEXPeqMM+EYcbOCztVFl4Tij34xsUZphVdssbEh06peXyu2k12CDcHruDA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793127297; h=DMARC-Filter:Received:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Transfer-Encoding:DKIM-Signature; bh=4aG9p3Chmdw2Uvqo6sRKdBC6007ynLccNNDb6g2oQZ8=; b=mf7OCJewcdqnpSE5iRpZgpL8mOzz2MzOc45sSBCwDH2IkK3FHkvl/XkASuhRbx2nOK+g +W/qhsap0/DzYcm7/c84dl2EXCjNFeXpj7tMJWNYhkI4T5vmvcT4CB6db/BYTTF+iUiOt sR0TfDNbGzWUHswYM4diupt2WTYdexkUrDQrYpnkvelLZG9KWXb03zo/Pp0lAxgFi1/Rx TlRYtSUiM2yqKJEQ0x7SUjkGiiesvFDN2CXMT0Y7QB582fsGkhbycPd5jJB6Iskk/zZ6O FPWf20qc0cXfTEodSZY2xTktB7KSWrT94TuCoiIFvRWjs6KlW9oz0fh/gnzNjF5DZjA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=molgen.mpg.de; spf=pass smtp.mailfrom=molgen.mpg.de; dkim=pass header.d=molgen.mpg.de header.i=@molgen.mpg.de header.a=rsa-sha256 header.s=20260906 header.b=dI0nJB0o; arc=none smtp.remote-ip=141.14.17.11 Received: from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF085606A31D for ; Tue, 27 Oct 2026 18:54:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BF085606A31D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=molgen.mpg.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=molgen.mpg.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=molgen.mpg.de header.i=@molgen.mpg.de header.a=rsa-sha256 header.s=20260906 header.b=dI0nJB0o Received: from abreu (unknown [185.238.219.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 063D04C1A256EE; Tue, 27 Oct 2026 19:54:21 +0100 (CET) From: Paul Menzel To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter , Wentao Liang , Alex Hung Cc: Paul Menzel , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amd/display: Don't warn about vendor infoframe for non-infoframe sinks Date: Tue, 27 Oct 2026 19:54:13 +0100 Message-ID: <20261027185414.162183-1-pmenzel@molgen.mpg.de> X-Mailer: git-send-email 2.55.0 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=molgen.mpg.de; s=20260906; t=1793127263; h=from:from:subject:date:message-id:mime-version:content-type:content-transfer-encoding; bh=4aG9p3Chmdw2Uvqo6sRKdBC6007ynLccNNDb6g2oQZ8=; b=dI0nJB0o5kLbZ7MZDpxH5+wDkkUpl0UfZIj5R5+cfOgB5Dpf5Vw8wziwa+uOlOZ66Gxf3uLnHtRK /nLcvyz8SZNurt0mOaFYVckC4bkpE73yibUoY/ibYsPMZgGWFclcopsPuSHnBPBV6evTqJn/YHqmaX OSiSnjP1reFn0Xu9sf9rW4+04GaesQsMOD5w5nCjwegltJGW75sfeERX2lurmaP9/ssRFjd6P7w61a 58bRQCS/5X72QN0pXGiP6r957AEik9jSigsWq61elnuvSx8+Ve94z2KvRH4skHNUvRZkju+trIoBuZ AjLrwn2p4NeqQOcKp7Tdw+6HUA0bg7Ww== With an EIZO EV2781 connected over HDMI to an AMD Ryzen 3 2200G (Raven) on an MSI B350M MORTAR (MS-7A37), Linux logs at every boot since v6.16: amdgpu 0000:30:00.0: [drm] Failed to setup vendor infoframe on connector HDMI-A-1: -22 Commit 6027cbee1900 ("drm/amd/display: Add error check for avi and vendor infoframe setup function") started to log the return value of drm_hdmi_vendor_infoframe_from_display_mode(). With `frame` and `mode` being non-NULL, the helper only fails with -EINVAL, if the sink does not support HDMI infoframes, that means, if `connector->display_info.has_hdmi_infoframe` is false, and its kernel-doc says, that this error can be safely ignored. drm_parse_hdmi_vsdb_video() only sets `has_hdmi_infoframe`, if the HDMI VSDB has HDMI_Video_present set, and drm_parse_hdmi_forum_scds() sets it for sinks with an HF-SCDB. So an HDMI sink, whose VSDB lacks HDMI_Video_present, triggers the warning, although nothing failed. The EIZO EV2781 is such a sink. Its HDMI VSDB has a payload of only seven bytes (source physical address, Supports_AI, and a maximum TMDS clock of 250 MHz), so the byte with HDMI_Video_present is absent, and the EDID has no HF-SCDB: 67 03 0c 00 10 00 80 32 Only warn, if the sink supports HDMI infoframes. The infoframe setup itself is unchanged. Fixes: 6027cbee1900 ("drm/amd/display: Add error check for avi and vendor infoframe setup function") Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/5025 --- Notes: claude-opus-5-5 (Claude Code) assisted in analysis, code change and commit message. drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c index ded8e21897f1c..636dd2dedd73d 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c @@ -941,7 +941,8 @@ STATIC_IFN_KUNIT void fill_stream_properties_from_drm_display_mode( err = drm_hdmi_vendor_infoframe_from_display_mode(&hv_frame, (struct drm_connector *)connector, mode_in); - if (err < 0) + /* Sinks without HDMI infoframe support make it fail with -EINVAL. */ + if (err < 0 && info->has_hdmi_infoframe) drm_warn_once(connector->dev, "Failed to setup vendor infoframe on connector %s: %zd\n", connector->name, err); timing_out->hdmi_vic = hv_frame.vic; base-commit: 77f548b127c6de34ce271fa09ba270cb1ef9f2da -- 2.54.0