mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yongzhao Chen <yongzhao.derek@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev-bot+sinfo@kernel.org, netdev@vger.kernel.org,
	Christian Marangi <ansuelsmth@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	linux-kernel@vger.kernel.org, Ziyang Huang <hzyitc@outlook.com>,
	Stanislaw Pal <kuncy7@gmail.com>
Subject: Re: [PATCH net v7] net: dsa: qca8k: preserve port state across MTU changes
Date: Tue, 27 Oct 2026 22:25:05 +0100	[thread overview]
Message-ID: <20261027212505.1848-1-yongzhao.derek@gmail.com> (raw)
In-Reply-To: <47e9713f-815e-4caf-8928-a7ec12d0087b@lunn.ch>

Hi Andrew,

On Tue, Oct 27, 2026 at 01:54:16PM +0100, Andrew Lunn wrote:
> Is this a real problem which bothers somebody? If it has not been seen
> in production, it sounds like it does not bother anybody. So net-next.

It has not been seen in production. Following your suggestion, I will
move it to net-next.

v7 needs another revision anyway. Sashiko's review [1] is right: a
concurrent PORT_STATUS reader such as the PCS poll can corrupt the MTU
snapshot, because the qca8k regmap is created with disable_locking and
shares its work_buf. Clearing the MAC bits unconditionally would not be
enough, since the restore uses the same snapshot and the MAX_FRAME_SIZE
write also goes through work_buf. Stanislaw's patch [2] enables the
regmap lock. With it, the v7 code passes a local KUnit test that forces
this interleaving against the real regmap core.

I will send v8 for net-next once it reopens and [2] is in net-next, and
say in the commit message how the problem was found, as sinfo asked.

[1] https://lore.kernel.org/netdev/179303171241.3134.15019965307136674652@kernel.org/
[2] https://lore.kernel.org/netdev/20261022192933.384898-2-kuncy7@gmail.com/

pw-bot: cr

  reply	other threads:[~2026-10-27 21:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 15:58 Yongzhao Chen
2026-10-22 16:03 ` netdev-bot+sinfo
2026-10-27  9:27   ` Yongzhao Chen
2026-10-27 12:54     ` Andrew Lunn
2026-10-27 21:25       ` Yongzhao Chen [this message]
2026-10-26 16:21 ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261027212505.1848-1-yongzhao.derek@gmail.com \
    --to=yongzhao.derek@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=ansuelsmth@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=horms@kernel.org \
    --cc=hzyitc@outlook.com \
    --cc=kuba@kernel.org \
    --cc=kuncy7@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev-bot+sinfo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®