From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.200 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793140759; b=pm1LSyidZLeJsyCEKVKBBcan8lIiEr9pWakZBle+omKixA8DF7atbEMYf/UaNYRe/mbO nKoUwN8dxH0BMElxEgLCnhGWGDnU+cHzHW4mgqqCEKBXJR+lrni7ucCzfrQL239E5rIn+ +luivfnRogT/rzogUUiiZcdhfctk1mcgkMDMD1tcAEjxJgwANaVEbBEz2WOrrJiRuqvu7 X+M+IowCnE+BO7lbd6vb4boUCr89u8Im+cGcKoVF7ZQnnxTvNgpsP4gRjBwx+pUQNj0mY pVL2gjM2zjN9Au41+l60gAsvA99LLnJBNaskji9qcpG6cY5QD+Rro+xL6nZ7zSINT8g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793140759; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=beIsynJTUoVVYUibNrHvS9xq2J3rMWzpCblr3XGPomY=; b=K8BSuB1AlE2av2LNtKcKzG2u94A0RlZGJOFc0BoC51BvAkDdMLMJLws6TYVEGt2XxvZv 1BJLh0QYk4L9IWNJvk9+hPgaWfr8xTCYtQawOIfGOsyyNAgYOcZTnhBt5lZzoTOFgSdIo 9SZcvGHmVgRWEl2OrwalCW1pYe/sKPS17+UaOZ2yTJTUAnQiIynI0IPLbwYKmk/KLVX0e gaYTCREJWQxQjRNgkWYfjXATKT/P7R9uxBNZ8NuyoF1XqcV7axeoxYZGqacBIWqRjm5K3 JhHAHzFQmKygYIkgG0/nhE4PZ+3mf1Yla++XcXo3YBddOduBuNvF9gYhAp+0i0k1row== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=kIMyUKFu; arc=none smtp.remote-ip=209.85.210.200 Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44CAB60A2606 for ; Tue, 27 Oct 2026 22:39:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 44CAB60A2606 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=kIMyUKFu Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8a5971cf7ceso470811b3a.1 for ; Tue, 27 Oct 2026 15:39:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793140759; x=1793745559; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=beIsynJTUoVVYUibNrHvS9xq2J3rMWzpCblr3XGPomY=; b=kIMyUKFukUJtjlCB+ZE2zh2lwo3GQV3z3dUYxV09PKjXw0ZjE2jeWA5BuL5r+QkTsS 5ZzU/9piUKJLhgATzOW69XBDirJSfUNdjU8bimvi6t/U9+77eeZV3sUpzjATUlpkTsmz gq3vyWIGNK0zFjlANK5GQZMvv0vsQLSwO9CijSJxrX9Vh1ynVxUpyQR+qXuUOzTQNEd2 vqFNVi+/m+qyeN1OsBM/7m5G51CLC9ESLC5hoKgrvebdkKnbj7QYKY4thO4WPGJ0SxlV i2/3GcwAryD5MX3hH5HdRpHDIt1i8yx0VLeoNGibsE95Q6GYl69dtaAIBjedJgq+ugfg pXGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793140759; x=1793745559; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=beIsynJTUoVVYUibNrHvS9xq2J3rMWzpCblr3XGPomY=; b=DYvfqysyIL+1gcc9EOjD1BprzbXbM9YGagxpULEG8uBJxobncorP3eMz+psRr16uzQ hNkK4RLb0d3As3u8PUYB3eoNIYJO9CfvZ465NMvuK/R7A/hU3lxL4aI7vRWsRdxPr6Hh A6R8O/dx2d+AfHo8CDeJ5bLteC9Cq6UsOHgQcSEVwPozWI6eRRsPTKRXC8y4pUzlO+2Q M9pRAHIRxbXBeVktlqVxMo3r9HXnhsMSyqcTMYtZSZrDk1NFoUtzhFQizGMLPNWCvMqE 3h3wnPxmUc28aaRU7e+++xcawWSTPs6jtjn0cLU+4gJZVnLODbvu5OTWxTM9JiLt0bGZ qYWw== X-Forwarded-Encrypted: i=1; AKwUvByfBI3s4LDlyd28DOVoll5WHmur/UIP7uy9cMfUddWctO5O4aTGSWxsPTnQr0mwntFQLlcSs888Gw3UNGM=@vger.kernel.org X-Gm-Message-State: AFq9FYIPgzgHsg1xJsCcyRVuOXPM3UjeJLQLci3ZDpdInSsCMGMW+9GR n6ROOGrvPdyXhOQG2ukrskqQlaGhl2Zw9lhfXag6BzP47QDQ2+BF2+Y3jfnr6Yg5sH6lzk1mWv3 Jl648EilzJA== X-Received: from pfbdw21.prod.google.com ([2002:a05:6a00:3695:b0:89f:827e:eb47]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:4293:b0:876:194e:b8fe with SMTP id d2e1a72fcca58-8a6e70e832amr492696b3a.26.1793140758450; Tue, 27 Oct 2026 15:39:18 -0700 (PDT) Date: Tue, 27 Oct 2026 15:38:38 -0700 In-Reply-To: <20261027223847.652884-1-irogers@google.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261027223847.652884-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.313.g2479322e68-goog Message-ID: <20261027223847.652884-4-irogers@google.com> Subject: [PATCH v2 3/9] sh: sq: Add missing kobject release callback to ktype_percpu_entry From: Ian Rogers To: Kees Cook , Greg Kroah-Hartman , Miguel Ojeda , "Rafael J . Wysocki" , Danilo Krummrich Cc: Nathan Chancellor , Nick Desaulniers , Miguel Ojeda , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Zhongqiu Han , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Paul Mundt Content-Type: text/plain; charset="UTF-8" In sq_dev_add(), sq_kobject[cpu] is dynamically allocated with kzalloc_obj() and initialized with ktype_percpu_entry. When sq_dev_remove() calls kobject_put(kobj), the kobject is never freed because ktype_percpu_entry lacks a .release callback. Provide a sq_kobj_release() callback that calls kfree(kobj). Fixes: d7c30c682a27 ("sh: Store Queue API rework.") Signed-off-by: Ian Rogers --- arch/sh/kernel/cpu/sh4/sq.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/sh/kernel/cpu/sh4/sq.c b/arch/sh/kernel/cpu/sh4/sq.c index 908a8e09113b..f33864958487 100644 --- a/arch/sh/kernel/cpu/sh4/sq.c +++ b/arch/sh/kernel/cpu/sh4/sq.c @@ -331,7 +331,13 @@ static const struct sysfs_ops sq_sysfs_ops = { .store = sq_sysfs_store, }; +static void sq_kobj_release(struct kobject *kobj) +{ + kfree(kobj); +} + static struct kobj_type ktype_percpu_entry = { + .release = sq_kobj_release, .sysfs_ops = &sq_sysfs_ops, .default_groups = sq_sysfs_groups, }; -- 2.56.0.313.g2479322e68-goog