From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.49 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793142511; b=Ugv9lI6o3PNEYCCDAK+Myt3PVb3Co0V7bFzTPIn8VwVZn8+ksnXwA4u1vImlGKncCZhk UMib8F2zUnbR4MmwKfI69T7Va7sWpkSGEN0h7v2jtsHaOA8Vzo9nOSQN7wKpqtKKX8zVX MN8/KkPZIW9hTjxiI5CbDp7OeT+byaDT7ybxLy7b9zrXSciu3DU0Si+gmZpEWhJZoVy+n /YH3ZD5nnhh7BeC269+37zUjNRBJpJR/EwUFFBAEw8j//1SKj0p+GnKXBmSrwjG5TtwID m3BzLVPsgcbx5O+bln7ImGCZ8oH84ftkiusykkzW6prCtIEEWGjrBG1Rpk6rTaGKEuw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793142511; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:MIME-Version:Content-Type: Content-Transfer-Encoding; bh=MMuIgB64ADt+cztY16YzQdSqp2JNpxBylsF2Y/Dr7t0=; b=Ef3R4rUI9XHo06oR0dE/aX8tYAOuqetXDM1E+Y4os6mb9RT5knZP7RR3BD2ZHZzmHHBR R7P1GPCROO0zjb5TsQZMOSesgBzWvwbkBbBwwaqikezi0r0zQJRQNjzCnULUFkN6e7vXQ eZ4p8i4MlePGZgcQA2xzR/QU7wJuWIqfpPr2rzR0fqW5V1hJ8HW2To2WR3gwdwCIehxqb rp9Fwl+7E0jmY9pMAQCAUTgbyc6ofWeVX+bmuRGCq5ndXwGL2OSeB4TzWSd8Ybh3p+Dm8 BxC9xCscf9p7FlbR0sbuoVjuiDLh2Kk4oCklzhmHU3jJr+LE1zNoHAWuoKK/rwy9iqg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=nSqmKpgj; arc=none smtp.remote-ip=209.85.128.49 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEEBB606A31E for ; Tue, 27 Oct 2026 23:08:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BEEBB606A31E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=nSqmKpgj Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4a5b2be99a8so2958895e9.2 for ; Tue, 27 Oct 2026 16:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793142509; x=1793747309; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MMuIgB64ADt+cztY16YzQdSqp2JNpxBylsF2Y/Dr7t0=; b=nSqmKpgjCru0xafx7MWoUDOYrNhffOLw87Ahi1ZIyjDVo6mPrEROQZo1FOObX2eCVy BHvB2X7NBoSSxFURZD2UEVZix2Nh+N/bs7qbwq1Lj6eLDfwY9fCDFA+mkaNmB/mzbXEM CY4foFhHwmGg5KXmXDmtYYl1M97aJSTJfUsCdip94S094nzU40uR+WGxVZPAngYwSyD3 lKST+rZAnV2fObdTIZQ8iJhjCyNx+d3s9QH5/aoT7ijhE4i4Kr8MmGr+yfQTeSGp0PvD Kq42P+m0CL/Bvyu4vk7c+jIgwYOe9IPBmfPrGzN4wBWhlLi94hHSPAy0M/oIXLyNPjpW HPXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793142509; x=1793747309; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=MMuIgB64ADt+cztY16YzQdSqp2JNpxBylsF2Y/Dr7t0=; b=ZgN5uM/JRv+Ljxj3sQSttSMQ9DUZjaJTuR7Egq9HjiHxxJvvU9n11GoU8US8Btc/dR wgB0n5NLnIDICpONFgC1GCaPT/zKIwW5X7RHrLf8AEIO1wFbSCrKxuboO8L1IxKfTD2N N3O2q0+XhgsdpyyK1HpMaKWOUV1p7ERMUo/nyRaXoNgizyv3RfOkHkMLukNJTRJhUe/Y Msv591xrDEOQaPf49QAJ3hH2lwrqVJnKAvHtvAh9qCUXc+q0hCjmyp3PX7o/rZL497Fn 3o8FdV3bWhRdV7mF+b1XMJEyZqIJdmzTKoFAv1sNiG8RM1NudLXwud6THNY3cD6wLKjV shIw== X-Forwarded-Encrypted: i=1; AKwUvBzJHqKEc0csCWJAQCsQE/NsRPCM8NTH9Ky2AolNsmKcE2M1g0+Y7p+hmPskIsfHF8eQNN96ZJoWRYDkEAk=@vger.kernel.org X-Gm-Message-State: AFq9FYJt5byUbskX4H2qpQ5hNp/gLx8eqZT0Qd9MlAn000P1RrsJands 9avMt0OVh6mmdX55vTLGHWImVKjGc57c+vmbWGaBOWaYy2Cn+V00wSfT X-Gm-Gg: AYBFou0y0p0GzPDOtwtyGcTJt3uVcHjqRnOOeRZwtoYTHAlCvzJq1KUfPaq8w9AJlM7 ZAx31HcrGXdnBKdNTRbyjKQ0EfpG2AzcWH4meP7FZ1CsmYY30PomPUCpjIddvsrztUx22gucWYS ZVb9gXTcWY+gYBRALv2+qucgc63dgN0dzce4aMsnVCjOiuRKa6Te8tTES4a/f4hZdEz9VwrxYKx 0l4fJVI1e18P8RagKLwxeAgsnGWhgYC+j8EkqxnRAeeZaU7ulLZ0C5FAV99M0s7Ohb1krkCsEpY 26AaYxsHg2B4kfFkxBPueJfX9gnBca/rs2oSDpFhEtdLx+LTCWrweTqW0sZ0ORzLiDjWWMnVJ4M O4ft8bqUoeykKi/bzBuFed8nX5SdA3j/jJuc7FHmX+QN87eMItkaXzEFYps8TqH2WxpAzCa3xPJ JAXIo2UV8+HJMdfb9d240x5TQ4mngpev5KaJ5EmXveeywpRq3pZpVtkLcAD8b/OPnTm3ScWCQzo qS3LJ5/R5Gj7M0tSyXEh1eXAExhRLsL6dBm8jP+thLr+cJSaRzKHT2yw+AI4ajsxdgr4oWjMunO 2Nc= X-Received: by 2002:a05:600c:19c6:b0:4a1:78c5:79f5 with SMTP id 5b1f17b1804b1-4a96845e569mr7992445e9.33.1793142509007; Tue, 27 Oct 2026 16:08:29 -0700 (PDT) Received: from ubuntu-4gb-nbg1-1.. ([2a01:4f8:1c19:b0ad::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a97cebf858sm3407595e9.12.2026.10.27.16.08.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2026 16:08:28 -0700 (PDT) From: =?UTF-8?q?Rare=C8=99-Mihai=20Vladu?= To: Hans de Goede , Mauro Carvalho Chehab Cc: Sakari Ailus , Andy Shevchenko , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, =?UTF-8?q?Rare=C8=99-Mihai=20Vladu?= Subject: [PATCH v4 0/5] media: atomisp: remove the circbuf library Date: Tue, 27 Oct 2026 23:08:02 +0000 Message-ID: <20261027230807.2407261-1-vladurares@gmail.com> X-Mailer: git-send-email 2.43.0 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Thanks to Andy for suggesting, in review of my earlier typedef patch [1], that I look at converting the custom circbuf code to circ_buf or kfifo, and for reviewing the previous versions. While looking into it, I found that the circbuf API is only used by the local queue path, and ia_css_queue_local_init() has no callers, so as far as I can tell that path is unused. The remote queues only need the descriptor and element layout shared with the SP firmware and a few small helpers. So this series first moves the remote queue handling into helpers, then removes the unused local path together with the queue type that no longer seems to serve a purpose, moves the few remaining pieces into ia_css_queue_comm.h and drops base/circbuf/. checkpatch warns about new typedefs in patch 4 and about MAINTAINERS in patch 5. The typedefs are only moved from ia_css_circbuf_comm.h, which patch 5 deletes, and MAINTAINERS has no entries for the removed files. Compile-tested only. This supersedes the typedef patch [1]. Changes in v4: - Patch 2: tidy up the moved code: drop redundant parentheses and '!= 0' comparisons, use !ptr instead of comparing to NULL, and return the final ia_css_queue_store() call directly, as Andy suggested - Add Andy's Reviewed-by to patches 2-4, thanks! Changes in v3: - New patch 2: move the remote branches into helpers first, so that patch 3 mostly removes code, as Andy suggested - Generate the patches with --histogram, as Andy suggested - Patch 1: add Andy's Reviewed-by Changes in v2 (patch numbers as in v2): - Patch 1: keep the includes ordered by name, as Andy suggested - Patch 2: also remove IA_CSS_QUEUE_TYPE_REMOTE, the type field and the type checks, as Andy suggested, and describe in the commit message how the queue handles are initialized and why the struct ia_css_queue size change on 64-bit should not matter - Patch 3: use u8/u32 and the usual function declaration style in the moved code, as Andy suggested - Patch 4: add Andy's Reviewed-by v3: https://lore.kernel.org/all/20261027120341.2305533-1-vladurares@gmail.com/ v2: https://lore.kernel.org/all/20261014111213.1967452-1-vladurares@gmail.com/ v1: https://lore.kernel.org/all/20261012230754.1914517-1-vladurares@gmail.com/ [1] https://lore.kernel.org/all/20260918214132.1135549-1-vladurares@gmail.com/ Rareș-Mihai Vladu (5): media: atomisp: sh_css_mipi: include assert_support.h directly media: atomisp: queue: move remote queue handling into helpers media: atomisp: queue: remove unused local queue support media: atomisp: queue: move circbuf types and helpers to queue_comm.h media: atomisp: remove unused circbuf library drivers/staging/media/atomisp/Makefile | 2 - .../base/circbuf/interface/ia_css_circbuf.h | 363 ----------------- .../circbuf/interface/ia_css_circbuf_comm.h | 56 --- .../circbuf/interface/ia_css_circbuf_desc.h | 160 -------- .../atomisp/pci/base/circbuf/src/circbuf.c | 312 -------------- .../runtime/queue/interface/ia_css_queue.h | 29 -- .../queue/interface/ia_css_queue_comm.h | 135 ++++++- .../atomisp/pci/runtime/queue/src/queue.c | 382 ++++++------------ .../pci/runtime/queue/src/queue_access.c | 1 - .../pci/runtime/queue/src/queue_access.h | 3 - .../media/atomisp/pci/sh_css_internal.h | 2 +- .../staging/media/atomisp/pci/sh_css_mipi.c | 1 + 12 files changed, 251 insertions(+), 1195 deletions(-) delete mode 100644 drivers/staging/media/atomisp/pci/base/circbuf/interface/ia_css_circbuf.h delete mode 100644 drivers/staging/media/atomisp/pci/base/circbuf/interface/ia_css_circbuf_comm.h delete mode 100644 drivers/staging/media/atomisp/pci/base/circbuf/interface/ia_css_circbuf_desc.h delete mode 100644 drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c -- 2.43.0