From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=103.168.172.142 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793081044; b=JwoJYQVc/MIc7peo1q//91aZUF/D41MgCbGWCGEgXTMCXiB1BtlbwcrmM/R8TllBVeK4 8s474zf8ipmOG/jg6rce0oUe82HhiIwiEBVhHoA63SP+WfdTGYSpHaL9mObRfmvr4AOx+ mqlKttuGaurrQPM4U0VhlIutxegaFGH9Y0jlDuJ9gfV2kqWDWTe2ukWT8CfR5Zhzf0xKs OWncWdoRMVCuRn6CYBS6iCvsWituljzlF/KRviLTZ4mWMaBQk1dr5LkfTbby3dHRod3tD WYrVyZMGov3zvlcO1YW0RMwA1DwAloXMovJRKVpRAMEGhjvhTCV96nBTMwppzuNTUeQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793081044; h=DMARC-Filter:Received:Received:DKIM-Signature:DKIM-Signature: X-DKIM2-Info:DKIM2-Signature:X-DKIM2-Info:Message-Instance: X-ME-Sender:X-ME-Received:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID: Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=t4OoGf5gHVzRGe+YIjw2VuUWKRz8U6K0v5JtauIuYFg=; b=xpteSiR8ddH6DqxW8TwNYyma44XifdrFZ4yqVpxp+huvA71TsoU2007/UJWMos8nBERk G7q67vWpI3RVcQaOSKli9KX6rx9PLqjveeRp5Xy327bF6Nr2UsRt2qDmhQL8j2KDtyp1Y 11O/CGfBG5wYbIX7efB1m2ZBkW3jW5XhVfF81kTuExs9uzaldwMPZDLZUIat03CkOCrb7 zvxDEFAJi+s4beEfABkla1xiD7IDFlRH3F/9e52oQ5LISA55TqAF3Oeiu19dVfioNq0Pf 8cOTrFAHyqNAO1bID6wq3QmtrXJPC3MeQXnV89fdfYWfFEnqnncehx9Ykcz2YHv2mBg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=kroah.com; spf=pass smtp.mailfrom=kroah.com; dkim=pass header.d=kroah.com header.i=@kroah.com header.a=rsa-sha256 header.s=fm2 header.b=pBmbRuK+; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=IlFiGdCd; arc=none smtp.remote-ip=103.168.172.142 Received: from flow-a7-smtp.messagingengine.com (flow-a7-smtp.messagingengine.com [103.168.172.142]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFB87606A31F for ; Tue, 27 Oct 2026 06:04:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org CFB87606A31F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kroah.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kroah.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kroah.com header.i=@kroah.com header.a=rsa-sha256 header.s=fm2 header.b=pBmbRuK+; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=IlFiGdCd Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailflow.phl.internal (Postfix) with ESMTP id 0B5FF138035D for ; Tue, 27 Oct 2026 02:04:03 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Tue, 27 Oct 2026 02:04:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1793081042; x=1793088242; bh=t4OoGf5gHV zRGe+YIjw2VuUWKRz8U6K0v5JtauIuYFg=; b=pBmbRuK+RpEV9BFZTEEED1+xQn QxhzwuWaStp0492F1sZlJfdb5JrjYSCV+2NYVAHtlzBHez2rPZGHA5hVzwPIReU0 PBLDTVnFMvFnxG1AZV9TRR631wBSiqcqUraFNCcatQe9H7+KVdS43vEmJH/IjCmZ segcD9NSUwmMGgDgk0RzIRq1Us9+nZTxJ0pFEN1sxF7h3bL+Bw1xd8n/uaYXPqT9 omVT04BOGkvrKu/VnhPQ53HphPOrrlfa05snlpXQQp269jbsx/ijs+qitlvwPu6v F2n5RJVA4zJ0ZAEuGcZEt+cqQuYI7ADvrfw/g+X2wZ5uWhG6ftAzAbq5zRbg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1793081042; x=1793088242; bh=t4OoGf5gHVzRGe+YIjw2VuUWKRz8U6K0v5J tauIuYFg=; b=IlFiGdCdCTlmZWowaWNwwI5su5BcJsv/nw1U199AnPalMMXClCC JvQIFOWvHlwMeYSvzJeOZZNcO6ZOGMDS25kTmYL800KodK7FH7fXwEuIT+uX4V7U rVAQJ1AI5ksxoeIKCUgIxYxR8UJl8LQcz+oKvB4Es9pUur6G/j4u+wGDaQ1FW4kf EiGZ3QNVlV2cyobajY0wEQB0cShOsgRHkbLUcui1oCyGlZ1g69kIaweh5EMX1/31 GdcCyGXRf59NPD098Nf3wePdwDKNi7p632hU9F/LXKuawSkV58au96Lo6rjtFo5f AGh6URukYmKewPtpVJ3Nkg5aikN4j5BEOeQ== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-07; repo=github.com/dkim2wg/interop; date=2026-10-18; sw=lmtpprox; action=sign d=kroah.com a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1793081042; d=kroah.com; mf=PGdyZWdAa3JvYWguY29tPg==; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm2:rsa-sha256:DK6kRAXk2cOr/nq2xw+riQ3TzWmyyUv2pwR9Fagis5scJ9M Tvfc9hJMWA5r1ZEL6GQSwXWsPyALd0M6laOJn/+UP+Sl9nA36OAB++ck5br3QGkz KawnJv88b93LKiRTnFqS3RT0OK/90+IrnyOScgavPVMqs1OokDgpGQYAsezLP7oT mv6mnnkM7ByHwdsLctgjPNo2SxY0rk9nsUxNHJZMh1+uPSWhs2PC4JwNMzoNa2o6 PPAiycK8pOe2Y55kKRj7FSCU5YXEKpYMGl12pZwtcwxKQvNTjZAo4hDjMKqpLLs8 MqQxV5ugnTXpLPymmRCn12sZyydkTFDoL+K5ftw==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-07; repo=github.com/dkim2wg/interop; date=2026-10-18; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-disposition,content-type,date,feedback-id,from, in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:zoLwu0ba4hLP136iUKXuQNMXsdfdA3aYEIrrMD0JcHQ=:0fCBaab8hkFDDaJ/Ih1bLvqwAABT2NnP0tQ4AAZGSwY=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFX46FHV+PvV6KGDcfkleNK34N2X9H1Al5LrxAe53ONFm9S0IjeeWDzhKxG8Shv+2 2Sn379VUd+VqaQMqSNIr0RXE0+SOVRfM/Gx63Qebrl2PemtKwduXbWRECrBTGBGfJrULBQ YffivZZeuaqa6DZI7pcpaDtiOVdw5kIrTCL6r+s1lX0EQtvi5KXdkVtZXgpLmiCeQhkyo5 0RBDkNxGhRvHg45S2izMhkaFcV0863KLldUCedNcqH3+jgrZBCN9SeN2y6dCFRcMN42C1t u00FOS5PhnGCWh3LVzWtg7Y9UnqD1Eeh27e8Hg6l3YKmlHNF7H1Kh+vihbmSX9fAbHYDo0 vqvwH4vETUN8Zr4DxgJ4QOvXhjERnzK77P9A+IdCgjx+wiWLtKkc6LZFFD5Bs6Z1sqZuVz ckKV1E0wb9arx8YX8MtEsQsRkZeuM118FdGNbvrDBaRqe0x0rhL+VYYeX+8ZFBGdMjUawJ tKIyqkzcz7czfyfY6rW9sNJyuz8PObfbf9f+DG/Wm/50xB7NDGRNqMS0hrstNZ3Z4TQGvn In1zUasPgunc5Wwdo3htDug2OGygn9eWE+LyMfxwElu7DqFy//jpxmpCS/DqHVPA/Mtm6Q rFKbHh41mZeRGHIV2EfmG7gi/NY8DRdJ/daoTWFCIqbRlpCr+MY0uSnnyS8A X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Oct 2026 02:04:01 -0400 (EDT) Date: Tue, 27 Oct 2026 07:04:00 +0100 From: Greg KH To: Tristan Madani Cc: Johannes Berg , Christian Lamparter , Stanislaw Gruszka , Ivo van Doorn , "John W . Linville" , Kees Cook , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, tristan@talencesecurity.com Subject: Re: [PATCH v2 wireless 0/3] wifi: replace open-coded IE searches with cfg80211_find_ie() Message-ID: <2026102756-geometric-swept-9e61@gregkh> References: <20261026223153.2087218-1-tristan@talencesecurity.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261026223153.2087218-1-tristan@talencesecurity.com> On Mon, Oct 26, 2026 at 10:31:52PM +0000, Tristan Madani wrote: > Three wireless drivers (carl9170, rt2x00, p54) each hand-roll their own > TIM IE search function. Replace them with cfg80211_find_ie(), which > already provides a correct and well-tested IE search. > > Changes in v2: > - Replace the entire open-coded functions with cfg80211_find_ie() > instead of only tightening the loop condition, per Johannes Berg. > - Add pre-subtraction length guards in p54 to prevent unsigned > underflow on truncated beacon frames. > > Tristan Madani (3): > wifi: carl9170: replace open-coded IE search with cfg80211_find_ie() > wifi: rt2x00: replace open-coded IE search with cfg80211_find_ie() > wifi: p54: replace open-coded IE search with cfg80211_find_ie() > > drivers/net/wireless/ath/carl9170/rx.c | 27 ++++------------- > drivers/net/wireless/intersil/p54/lmac.h | 3 -- > drivers/net/wireless/intersil/p54/main.c | 30 +++++-------------- > drivers/net/wireless/intersil/p54/txrx.c | 12 ++++++-- > .../net/wireless/ralink/rt2x00/rt2x00dev.c | 30 +++++-------------- > 5 files changed, 29 insertions(+), 73 deletions(-) > > -- > 2.47.3 > > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.