From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Benoît Monin" <benoit.monin@bootlin.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
"Thomas Gleixner" <tglx@kernel.org>,
"Radu Rendec" <radu@rendec.net>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Gregory CLEMENT <gregory.clement@bootlin.com>
Subject: [PATCH 2/4] irqchip: irq-eyeq5-msi: add EyeQ5 PCIe MSI controller driver
Date: Wed, 28 Oct 2026 16:58:49 +0100 [thread overview]
Message-ID: <20261028-eyeq5_msi-v1-2-c464752fb55f@bootlin.com> (raw)
In-Reply-To: <20261028-eyeq5_msi-v1-0-c464752fb55f@bootlin.com>
Each EyeQ5 PCIe port has its own MSI controller. The controller snoops the
MSI write TLPs that the port receives. It raises an interrupt when a write
targets the doorbell window. A port supports a maximum of 4 MSI vectors.
The driver supports two roles, selected by the GCSR mode. In root complex
mode, it registers a PCI MSI parent. In endpoint mode, it registers a
platform MSI parent. The driver chains the snooper domain to one GIC
interrupt.
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
---
arch/mips/Kconfig | 1 +
drivers/irqchip/Kconfig | 5 +
drivers/irqchip/Makefile | 1 +
drivers/irqchip/irq-eyeq5-msi.c | 474 ++++++++++++++++++++++++++++++++++++++++
4 files changed, 481 insertions(+)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index d7c67cebe065f..98571ee5a20dd 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -633,6 +633,7 @@ config EYEQ
select CPU_MIPSR2_IRQ_VI
select CSRC_R4K
select DMA_NONCOHERENT
+ select EYEQ5_MSI
select HAVE_PCI
select IRQ_MIPS_CPU
select MIPS_AUTO_PFN_OFFSET
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 20b77fbc51ee0..e92134d1b1b97 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -840,4 +840,9 @@ config SUNPLUS_SP7021_INTC
chained controller, routing all interrupt source in P-Chip to
the primary controller on C-Chip.
+config EYEQ5_MSI
+ bool
+ select IRQ_DOMAIN
+ select IRQ_MSI_LIB
+
endmenu
diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index ab33cccd84719..5e6ab5c2c50fc 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile
@@ -135,3 +135,4 @@ obj-$(CONFIG_APPLE_AIC) += irq-apple-aic.o
obj-$(CONFIG_MCHP_EIC) += irq-mchp-eic.o
obj-$(CONFIG_SOPHGO_SG2042_MSI) += irq-sg2042-msi.o
obj-$(CONFIG_SUNPLUS_SP7021_INTC) += irq-sp7021-intc.o
+obj-$(CONFIG_EYEQ5_MSI) += irq-eyeq5-msi.o
diff --git a/drivers/irqchip/irq-eyeq5-msi.c b/drivers/irqchip/irq-eyeq5-msi.c
new file mode 100644
index 0000000000000..883b6d63c9882
--- /dev/null
+++ b/drivers/irqchip/irq-eyeq5-msi.c
@@ -0,0 +1,474 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Mobileye EyeQ5 MSI interrupt controller
+ *
+ * Copyright Mobileye (2026)
+ */
+
+#define pr_fmt(fmt) "eyeq5-msi: " fmt
+
+#include <linux/bitfield.h>
+#include <linux/bitmap.h>
+#include <linux/interrupt.h>
+#include <linux/io.h>
+#include <linux/irq.h>
+#include <linux/irqchip.h>
+#include <linux/irqchip/chained_irq.h>
+#include <linux/irqchip/irq-msi-lib.h>
+#include <linux/irqdomain.h>
+#include <linux/msi.h>
+#include <linux/of_address.h>
+#include <linux/of_irq.h>
+#include <linux/slab.h>
+#include <linux/spinlock.h>
+
+/*
+ * The snooper decodes the vector number from TLP address bits [4:3], so a
+ * port can serve at most 4 vectors.
+ */
+#define EYEQ_MSI_MAX_VECTORS 4
+
+/*
+ * Vector n is raised by a write to the doorbell base + n * 8.
+ */
+#define EYEQ_MSI_VECTOR_STRIDE 8
+
+#define GCSR_CONFIG 0x00
+#define GCSR_CONFIG_RC BIT(0)
+
+#define GCSR_IRQSTATUS 0x0a
+#define GCSR_IRQSTATUS_MASK GENMASK(15, 12)
+
+#define GCSR_IRQMASK 0x0c
+#define GCSR_IRQMASK_MASK GENMASK(15, 12)
+
+#define MSI_BASE_LO 0x00
+#define MSI_BASE_HI 0x02
+
+#define MSI_CTRL 0x04
+#define MSI_CTRL_EN_OVERRIDE BIT(15)
+#define MSI_CTRL_BAR_MATCH_MODE BIT(10)
+#define MSI_CTRL_BAR_COMPARE GENMASK(9, 7)
+
+#define VECTOR_ADDR_LO GENMASK_ULL(20, 5)
+#define VECTOR_ADDR_HI GENMASK_ULL(36, 21)
+
+struct eyeq_msi {
+ raw_spinlock_t lock;
+ struct irq_domain *msi_domain;
+ DECLARE_BITMAP(used, EYEQ_MSI_MAX_VECTORS);
+
+ void __iomem *gcsr_base;
+ void __iomem *msi_base;
+
+ phys_addr_t vector_phys;
+
+ const char *label;
+ u32 num_vectors;
+ int irq;
+};
+
+/*
+ * The caller must hold msi->lock.
+ */
+static void __eyeq_msi_mask_irq(struct eyeq_msi *msi, unsigned int bit)
+{
+ u16 value;
+
+ value = readw(msi->gcsr_base + GCSR_IRQMASK);
+ value &= ~FIELD_PREP(GCSR_IRQMASK_MASK, BIT(bit));
+ writew(value, msi->gcsr_base + GCSR_IRQMASK);
+}
+
+/*
+ * The caller must hold msi->lock.
+ */
+static void __eyeq_msi_unmask_irq(struct eyeq_msi *msi, unsigned int bit)
+{
+ u16 value;
+
+ value = readw(msi->gcsr_base + GCSR_IRQMASK);
+ value |= FIELD_PREP(GCSR_IRQMASK_MASK, BIT(bit));
+ writew(value, msi->gcsr_base + GCSR_IRQMASK);
+}
+
+static void eyeq_msi_mask_irq(struct irq_data *data)
+{
+ struct eyeq_msi *msi = irq_data_get_irq_chip_data(data);
+
+ guard(raw_spinlock_irqsave)(&msi->lock);
+ __eyeq_msi_mask_irq(msi, data->hwirq);
+}
+
+static void eyeq_msi_unmask_irq(struct irq_data *data)
+{
+ struct eyeq_msi *msi = irq_data_get_irq_chip_data(data);
+
+ guard(raw_spinlock_irqsave)(&msi->lock);
+ __eyeq_msi_unmask_irq(msi, data->hwirq);
+}
+
+static void eyeq_msi_compose_msg(struct irq_data *data, struct msi_msg *msg)
+{
+ struct eyeq_msi *msi = irq_data_get_irq_chip_data(data);
+ phys_addr_t address;
+
+ memset(msg, 0, sizeof(*msg));
+
+ address = msi->vector_phys + data->hwirq * EYEQ_MSI_VECTOR_STRIDE;
+
+ msg->address_lo = lower_32_bits(address);
+ msg->address_hi = upper_32_bits(address);
+ msg->data = data->hwirq;
+}
+
+static struct irq_chip eyeq_msi_irq_chip = {
+ .name = "EyeQ5-MSI",
+ .irq_mask = eyeq_msi_mask_irq,
+ .irq_unmask = eyeq_msi_unmask_irq,
+ .irq_compose_msi_msg = eyeq_msi_compose_msg,
+};
+
+static void eyeq_msi_isr(struct irq_desc *desc)
+{
+ struct irq_chip *parent_chip = irq_desc_get_chip(desc);
+ struct eyeq_msi *msi = irq_desc_get_handler_data(desc);
+ void __iomem *status_reg;
+ unsigned long pending;
+ unsigned int bit;
+ int ret;
+
+ chained_irq_enter(parent_chip, desc);
+
+ status_reg = msi->gcsr_base + GCSR_IRQSTATUS;
+
+ while (true) {
+ pending = FIELD_GET(GCSR_IRQSTATUS_MASK,
+ readw(status_reg));
+ if (!pending)
+ break;
+
+ /*
+ * Write-one-to-clear status register.
+ */
+ writew(FIELD_PREP(GCSR_IRQSTATUS_MASK, pending),
+ status_reg);
+
+ for_each_set_bit(bit, &pending, msi->num_vectors) {
+ ret = generic_handle_domain_irq(msi->msi_domain, bit);
+ if (ret)
+ pr_err_ratelimited("unmapped MSI interrupt %u\n",
+ bit);
+ }
+ }
+
+ chained_irq_exit(parent_chip, desc);
+}
+
+static int eyeq_msi_domain_alloc(struct irq_domain *domain,
+ unsigned int virq,
+ unsigned int nr_irqs,
+ void *args)
+{
+ struct eyeq_msi *msi = domain->host_data;
+ DECLARE_BITMAP(reserved, EYEQ_MSI_MAX_VECTORS);
+ unsigned long bit = 0;
+ unsigned int i;
+
+ bitmap_zero(reserved, EYEQ_MSI_MAX_VECTORS);
+
+ scoped_guard(raw_spinlock_irqsave, &msi->lock) {
+ for (i = 0; i < nr_irqs; i++) {
+ bit = find_next_zero_bit(msi->used, msi->num_vectors, bit);
+ if (bit >= msi->num_vectors) {
+ /*
+ * Roll back this call's allocations: on error the
+ * core does not call .free().
+ */
+ for_each_set_bit(bit, reserved,
+ EYEQ_MSI_MAX_VECTORS) {
+ clear_bit(bit, msi->used);
+ __eyeq_msi_mask_irq(msi, bit);
+ }
+
+ return -ENOSPC;
+ }
+
+ set_bit(bit, msi->used);
+ __eyeq_msi_unmask_irq(msi, bit);
+ set_bit(bit, reserved);
+ bit++;
+ }
+ }
+
+ i = 0;
+ for_each_set_bit(bit, reserved, EYEQ_MSI_MAX_VECTORS)
+ irq_domain_set_info(domain, virq + i++, bit,
+ &eyeq_msi_irq_chip, msi,
+ handle_simple_irq, NULL, NULL);
+
+ return 0;
+}
+
+static void eyeq_msi_domain_free(struct irq_domain *domain,
+ unsigned int virq,
+ unsigned int nr_irqs)
+{
+ struct irq_data *data;
+ struct eyeq_msi *msi;
+ irq_hw_number_t hwirq;
+ unsigned int i;
+
+ for (i = 0; i < nr_irqs; i++) {
+ data = irq_domain_get_irq_data(domain, virq + i);
+ if (WARN_ON_ONCE(!data))
+ continue;
+
+ msi = irq_data_get_irq_chip_data(data);
+ hwirq = data->hwirq;
+
+ guard(raw_spinlock_irqsave)(&msi->lock);
+
+ if (!test_and_clear_bit(hwirq, msi->used)) {
+ pr_warn("attempt to free unused hwirq %lu\n",
+ (unsigned long)hwirq);
+ continue;
+ }
+
+ __eyeq_msi_mask_irq(msi, hwirq);
+ }
+}
+
+/*
+ * The same callbacks serve the PCI MSI parent (root complex mode) and the
+ * platform MSI parent (endpoint mode).
+ */
+static const struct irq_domain_ops eyeq_msi_domain_ops = {
+ .alloc = eyeq_msi_domain_alloc,
+ .free = eyeq_msi_domain_free,
+ .select = msi_lib_irq_domain_select,
+};
+
+#define EYEQ_MSI_FLAGS_REQUIRED \
+ (MSI_FLAG_USE_DEF_DOM_OPS | \
+ MSI_FLAG_USE_DEF_CHIP_OPS | \
+ MSI_FLAG_NO_AFFINITY)
+
+#define EYEQ_MSI_FLAGS_SUPPORTED \
+ (MSI_FLAG_MULTI_PCI_MSI | \
+ MSI_FLAG_PCI_MSIX | \
+ MSI_GENERIC_FLAGS_MASK)
+
+static const struct msi_parent_ops eyeq_msi_parent_ops = {
+ .required_flags = EYEQ_MSI_FLAGS_REQUIRED,
+ .supported_flags = EYEQ_MSI_FLAGS_SUPPORTED,
+ .bus_select_token = DOMAIN_BUS_NEXUS,
+ .bus_select_mask = MATCH_PCI_MSI,
+ .prefix = "EYEQ-",
+ .init_dev_msi_info = msi_lib_init_dev_msi_info,
+};
+
+/*
+ * In endpoint mode the snooper is a platform MSI controller: the host writes
+ * the doorbell and the snooper raises a local interrupt. Expose it as a
+ * platform MSI parent so endpoint functions can allocate doorbells.
+ */
+static const struct msi_parent_ops eyeq_msi_platform_parent_ops = {
+ .required_flags = EYEQ_MSI_FLAGS_REQUIRED,
+ .supported_flags = EYEQ_MSI_FLAGS_SUPPORTED,
+ .bus_select_token = DOMAIN_BUS_NEXUS,
+ .bus_select_mask = MATCH_PLATFORM_MSI,
+ .prefix = "EYEQ-",
+ .init_dev_msi_info = msi_lib_init_dev_msi_info,
+};
+
+static int eyeq_msi_create_domain(struct eyeq_msi *msi,
+ struct device_node *node, bool is_rc)
+{
+ const struct msi_parent_ops *parent_ops = is_rc ?
+ &eyeq_msi_parent_ops : &eyeq_msi_platform_parent_ops;
+ struct irq_domain_info info = {
+ .fwnode = of_fwnode_handle(node),
+ .ops = &eyeq_msi_domain_ops,
+ .host_data = msi,
+ .size = msi->num_vectors,
+ /*
+ * The composed doorbell address does not depend on affinity,
+ * as required by platform MSI doorbell consumers.
+ */
+ .domain_flags = is_rc ? 0 : IRQ_DOMAIN_FLAG_MSI_IMMUTABLE,
+ };
+
+ msi->msi_domain = msi_create_parent_irq_domain(&info, parent_ops);
+ if (!msi->msi_domain)
+ return -ENOMEM;
+
+ return 0;
+}
+
+static int eyeq_msi_parse_vector_region(struct eyeq_msi *msi,
+ struct device_node *node)
+{
+ struct device_node *memory_node;
+ struct resource resource;
+ int ret;
+
+ memory_node = of_parse_phandle(node, "memory-region", 0);
+ if (!memory_node) {
+ pr_err("missing memory-region property\n");
+ return -EINVAL;
+ }
+
+ ret = of_address_to_resource(memory_node, 0, &resource);
+ of_node_put(memory_node);
+
+ if (ret) {
+ pr_err("failed to parse MSI vector memory region: %d\n",
+ ret);
+ return ret;
+ }
+
+ msi->vector_phys = resource.start;
+
+ return 0;
+}
+
+static int eyeq_msi_parse_dt(struct eyeq_msi *msi,
+ struct device_node *node)
+{
+ int ret;
+
+ ret = of_property_read_u32(node, "num-vectors",
+ &msi->num_vectors);
+ if (ret) {
+ pr_err("missing or invalid num-vectors property\n");
+ return ret;
+ }
+
+ if (!msi->num_vectors ||
+ msi->num_vectors > EYEQ_MSI_MAX_VECTORS) {
+ pr_err("invalid number of vectors: %u\n",
+ msi->num_vectors);
+ return -EINVAL;
+ }
+
+ ret = of_property_read_string(node, "label", &msi->label);
+ if (ret)
+ msi->label = node->name;
+
+ return eyeq_msi_parse_vector_region(msi, node);
+}
+
+static void eyeq_msi_program_hardware(struct eyeq_msi *msi, bool is_rc)
+{
+ u32 match_bar;
+ u16 control;
+
+ /*
+ * The register holds address bits 5..36.
+ */
+ writew(FIELD_GET(VECTOR_ADDR_LO, msi->vector_phys),
+ msi->msi_base + MSI_BASE_LO);
+
+ writew(FIELD_GET(VECTOR_ADDR_HI, msi->vector_phys),
+ msi->msi_base + MSI_BASE_HI);
+
+ /*
+ * RC mode uses BAR 2 as the no-translation BAR, endpoint mode uses
+ * BAR 3 as the MSI BAR.
+ */
+ match_bar = is_rc ? 2 : 3;
+
+ /*
+ * MSI_ADDR_MASK is left to zero: the vector region only differs from
+ * its base on address bits [4:3], which hardware excludes from the
+ * comparison since they hold the vector number.
+ */
+ control = MSI_CTRL_EN_OVERRIDE |
+ MSI_CTRL_BAR_MATCH_MODE |
+ FIELD_PREP(MSI_CTRL_BAR_COMPARE, match_bar);
+
+ writew(control, msi->msi_base + MSI_CTRL);
+}
+
+static int __init eyeq_msi_of_init(struct device_node *node,
+ struct device_node *parent)
+{
+ struct eyeq_msi *msi;
+ bool is_rc;
+ int ret;
+
+ msi = kzalloc_obj(struct eyeq_msi);
+ if (!msi)
+ return -ENOMEM;
+
+ raw_spin_lock_init(&msi->lock);
+ bitmap_zero(msi->used, EYEQ_MSI_MAX_VECTORS);
+ msi->irq = -1;
+
+ msi->gcsr_base = of_iomap(node, 0);
+ if (!msi->gcsr_base) {
+ pr_err("failed to map GCSR registers\n");
+ ret = -ENOMEM;
+ goto err_free;
+ }
+
+ msi->msi_base = of_iomap(node, 1);
+ if (!msi->msi_base) {
+ pr_err("failed to map MSI registers\n");
+ ret = -ENOMEM;
+ goto err_unmap_gcsr;
+ }
+
+ ret = eyeq_msi_parse_dt(msi, node);
+ if (ret)
+ goto err_unmap_msi;
+
+ msi->irq = of_irq_get(node, 0);
+ if (msi->irq < 0) {
+ ret = msi->irq;
+ pr_err("failed to obtain parent IRQ: %d\n", ret);
+ goto err_unmap_msi;
+ }
+
+ is_rc = FIELD_GET(GCSR_CONFIG_RC,
+ readw(msi->gcsr_base + GCSR_CONFIG));
+
+ ret = eyeq_msi_create_domain(msi, node, is_rc);
+ if (ret) {
+ pr_err("failed to create IRQ domain: %d\n", ret);
+ goto err_dispose_irq;
+ }
+
+ eyeq_msi_program_hardware(msi, is_rc);
+
+ /*
+ * Install the chained handler only once the domain and hardware are
+ * ready, otherwise an interrupt could arrive unhandled.
+ */
+ irq_set_chained_handler_and_data(msi->irq,
+ eyeq_msi_isr, msi);
+
+ pr_info("%s: initialized in %s mode with %u vectors, parent IRQ %d\n",
+ msi->label, is_rc ? "root-complex" : "endpoint",
+ msi->num_vectors, msi->irq);
+
+ return 0;
+
+err_dispose_irq:
+ irq_dispose_mapping(msi->irq);
+
+err_unmap_msi:
+ iounmap(msi->msi_base);
+
+err_unmap_gcsr:
+ iounmap(msi->gcsr_base);
+
+err_free:
+ kfree(msi);
+
+ return ret;
+}
+
+IRQCHIP_DECLARE(eyeq5_msi, "mobileye,eyeq5-msi",
+ eyeq_msi_of_init);
--
2.53.0
next prev parent reply other threads:[~2026-10-28 15:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 15:58 [PATCH 0/4] irqchip: add EyeQ5 PCIe MSI controller Gregory CLEMENT
2026-10-28 15:58 ` [PATCH 1/4] dt-bindings: interrupt-controller: add Mobileye " Gregory CLEMENT
2026-10-28 15:58 ` Gregory CLEMENT [this message]
2026-10-28 20:05 ` [PATCH 2/4] irqchip: irq-eyeq5-msi: add EyeQ5 PCIe MSI controller driver Thomas Gleixner
2026-10-28 15:58 ` [PATCH 3/4] MIPS: dts: eyeq5: add MSI controllers Gregory CLEMENT
2026-10-28 15:58 ` [PATCH 4/4] MAINTAINERS: add EyeQ5 MSI controller entry Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028-eyeq5_msi-v1-2-c464752fb55f@bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=benoit.monin@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=radu@rendec.net \
--cc=robh@kernel.org \
--cc=tglx@kernel.org \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tsbogend@alpha.franken.de \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®