From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793196592; b=ZtpAWDGQXhM89Xyu8mvEN7nE0IerCrSK34hKCeZ04xSc+ETTzwFrELwv+S97M02uDOx9 9eqexYB4YcaaS9Or4yQErKT3Y+abzI90XFyWIfhZUmOECOTIgom7eMPL8YVQLjP9Lj1R8 5qF+CmVstXRT8lAlHGS/JjVFu+PzmhdRuXN7mcof3HHi/G+rCJ8C6z7kUZuwLoTEHK2cS r3KFCyREb56W/h3Ixa9FT2rlEDg0mPCMHtbh+h+ZuOXrQoxmB41+gwxiOP9qkvudHbL1s +JyYS9RtCKFTabVtb8zoEHPwwwrFh2lWIjOLeCNZcDdmt4XBnkXFSGyV+tZx5PmNXQQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793196592; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From:Date: Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:X-B4-Tracking:X-Change-ID:To:Cc:X-Mailer: X-Authority-Analysis:X-Proofpoint-Spam-Info:X-Proofpoint-GUID: X-Proofpoint-ORIG-GUID:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-Virus-Version:X-Proofpoint-Spam-Details; bh=cxJH0qp0FiIlpZ0MfESATVurtQCCVtnz1lsq71RKj1Q=; b=2pxkm2WFXtSfbK+rVrksvEtGA86a/5AMlRLFWfmYlvM2uTiw2kWHTvx9K4J8zfiArEee s3v4nupEOnpNhA00cx+cHxCsVAWNRnwjPFGbpvmaXv+9czHVsfkd18LAPe8ZWcGCGwRBU KEiD2/F3GA6aOFq5CN4TbbXwKw0WGXgwd2HZAbMFENVWhGfYVumCEr8aybrgq4PUR/u5H EOuKlT4lo85tmEEna2i0ZrQkJWrpJlF/RYEZAduorXW6VaPw7Q4Pl+ErzImhZr9oZ/jv6 IekXJLoKXzHB8UVO9odTLg+i34LqOInTDLM9BYWo4u7gztsvJxRKSpIUOpnD8jObinQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=mp4KMjVY; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=CbVMu5ci; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87BD6606A31D for ; Wed, 28 Oct 2026 14:09:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 87BD6606A31D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=mp4KMjVY; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=CbVMu5ci Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69SBdqTW137444 for ; Wed, 28 Oct 2026 14:09:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=cxJH0qp0FiIlpZ0MfESATV urtQCCVtnz1lsq71RKj1Q=; b=mp4KMjVYVmH3JyoOr9N0gjhCaISy4zYtKVjRKs +zW3BT8jIoOlkdGps3zxS34wmoMez3QAu2wxVMj+Sy9Uhx7hwd2GjhTjUofJeOQu QWE2JNRNC4ufofI8TdJbcsTV1UHXOWiVA643Wykruk0rIfgR/I+Nd4KBjcKDjqqr VfUlQe0BoUptbbhI6maM8grjvKAvwa24JihCWQNibNcvH9ZDkmfOI0gkcjth9mcz PJx4IxtWs5En00Sh/QtE/5QiGIwCAvBnL/D5jUAsmrbyGTVPxbHMeiGs1z3+JOpM TF0s8zrcf9CPzfQR4ICpLiNBtg+C4MPTi1FwcAgg7laetYnQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hk6f92t2n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Oct 2026 14:09:50 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-944101e6367so47670785a.1 for ; Wed, 28 Oct 2026 07:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793196590; x=1793801390; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=cxJH0qp0FiIlpZ0MfESATVurtQCCVtnz1lsq71RKj1Q=; b=CbVMu5ciZN7QPxoDrtCCXTgu1ZMnpEoney8ZfyUuKbqvWM/3QuXEuVSBKaEarUhzvr N6N7MaIoh1D5S+awqPcu+1j+93dU4wc2jTEw+iT1AvM3Znyk3ltysPgc8y2eKPVoRhvO XSgQ7Z3qmEZWzFRHuC0m/lvZjwLt4v1tNonQ2Bbtue3qD4A5nsf3Q5hXTQZ+RjL079nr 8YB47i+ykeZa5JrL3mAEvG13iZWdu9sfLa4UijK5VDk/d2valNn/9uszvUzICbxO/xQO OCo4mwhKGQmjqllufZ6zO+rjH++zvfiWxPXhz7c0tNxD0h6DSxdrx2GRouxfPLeHq9b+ QTEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793196590; x=1793801390; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=cxJH0qp0FiIlpZ0MfESATVurtQCCVtnz1lsq71RKj1Q=; b=EeL5a/Yyze4ajzhvA25TJgUyWKn3Bx0uhcJeCVhPsaUvqsWQmvPDBT6wNe4In6G6YW jWUrh1jQAumvsjFHNVK3xJ/SF2CBbo6VU9Vt4khj8VHOYZNmM13V+2ZWMnJgpqupiOoK hVerLleagPKmeP/9nthmo+IbSfscMbjj4iIEuhb0PUn2xm+P/zuDdhxip2gKx2Qm/hP3 4ojpQfIw8BY4dghLHFoVhpBjVqOawAexm+Nx86YU7WYNDRwx7aIirPqyvjqtiE0Rmurp ov7KCtjgBILZuxqSXjZ1qSHekh3sENPBzOf4vJ461EQFahA68Orxw0URKrY2oAFFypUC Vbyg== X-Forwarded-Encrypted: i=1; AKwUvBzNZ08h19oS4OwVMND4Odx3dVWmBciEZ8v35vc4G/K5R2MfFqzIqtkSVSyAJ+DOF4RXSfTaA2Qvhu5LSjo=@vger.kernel.org X-Gm-Message-State: AFq9FYIhdfKpnzmCr2OBjX56JAK4YM41GBVr7k9B8p3VnpadgeeWT8y0 i/D/1if9+ry/kmLUI2yp++FaB/+8fFF8d7FOcEbWE74dV0d+pMLIS9W5K6tzp7akFlXNHHtIG6E Sodq7yoTgMz0GXhf0V89lt4OAjEHnsHT1lgyX03AtYoIj8C1VFZKbRH4OX6novnDsr6c= X-Gm-Gg: AYBFou2rGtM26udC8etpA9KjLpCqipAwfr36/9BTSCV6n8zWtijHuO7eMTq58wUVfbZ tsddsDRe6/res5Hrs5oPVpTGsCnbZs1eA7l6NWa0RpbZTe8uiCPCTrhMzNHA9cZpDeA2Q1LkFse 0wuBT7gDRVpwPb6NcUNp3zbRGm1lOQpsSb0Ae5MRkz3QYqGTAbI5KMBg09+qHTMOgScXOm9Cevs HleLtpX2Cd5dAxK3bXFsgUpU59BI8lWBiFFRwGYwi2Iuf96QexY+SB0RkAUqdNvc2YhFbqOnSsJ lXWt6M4j3RwE1pynu2XSPoPzzFi9Ce9eE/Y6qW6IIaOzvSZrgQFBTVdAOJ3Hv5Fsqp7MUZ5oXX4 tLdSQ+WhMPJtZAudTJFfV0FTz9zrNHMNaAT8uRbCs4+DPyhWfaZwu9XjbsndjWGOn9NAqPVDevD Ohvt3VVxcF0hs7Ug/EfDwasriiSel7xZzmZycAKbmqOuOYQqWVeUscj3sHwgY6l0stz+Bi+pNbH /7TwY4efFmGguN8EzSKKMA6Pu55 X-Received: by 2002:a05:620a:846:b0:944:4e6:85d8 with SMTP id af79cd13be357-94404e6b700mr356957085a.5.1793196589609; Wed, 28 Oct 2026 07:09:49 -0700 (PDT) X-Received: by 2002:a05:620a:846:b0:944:4e6:85d8 with SMTP id af79cd13be357-94404e6b700mr356951985a.5.1793196588953; Wed, 28 Oct 2026 07:09:48 -0700 (PDT) Received: from QCOM-eG0v1AUPpu.na.qualcomm.com ([2a01:e0a:830:450:9d77:8e43:b62f:d85d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e3ecd8ddasm31369197f8f.48.2026.10.28.07.09.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 07:09:48 -0700 (PDT) From: Loic Poulain Date: Wed, 28 Oct 2026 15:09:47 +0100 Subject: [PATCH] iio: adc: qcom-spmi-adc5-gen3: Reuse IIO device ID for ADC_TM auxiliary device X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261028-fix-adc5-tm-v1-1-0018aabc06c5@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIACoC4moC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzNDAyML3bTMCt3ElGRT3ZJc3WRLsyRD40STNBMTIyWgjoKiVKA02LTo2Np aAJXQkuRdAAAA X-Change-ID: 20261028-fix-adc5-tm-c96b13a4f442 To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Loic Poulain X-Mailer: b4 0.14.2 X-Authority-Analysis: v=2.4 cv=frhJ914f c=1 sm=1 tr=0 ts=6ae2022e cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=6zM0cWFruIK7PyS1tvwA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDI4MDA1NiBTYWx0ZWRfXxV82cKAiwClw urkbY3Sx+qwjXSkwsKQNcvn/4Zs1TQq2TH76lbbNhhcGS33U505vNkOsmaq/QTTg2s3Q26ZjVGV bxPFWWJ9xjMxmOx7mVJ9AG+nUohZFv0= X-Proofpoint-GUID: XR61fxofW14YqPxceuRl7avKRD1w4jNg X-Proofpoint-ORIG-GUID: XR61fxofW14YqPxceuRl7avKRD1w4jNg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDI4MDA1NiBTYWx0ZWRfX6lJF+U8HmBr4 dyWYF3KdAjMAVkRBlVuuN036pCjjd7z4nNKwUbtWmV/J96BNqpZ/kRrVHxLTR01pwX1aptAQN+e 14cKg3oen0y9YwfuAuON52VZUS+5UtapVuu98A95PEMq+75LXAzDPI4Buot+88+eHMxy0aEjNPw CoueiVxBUPHRrvDaWGBcpFNGlCkNssiLYapRgSJA87GMsu3OMm38ze25xhO+lUbUnbzLIan1MvV nxQtCPvhxOAoGFUMo79LUPfcCYfZ8ehxWqSQcTYpW8KK70NrZ2R6O8QwpOJ+qxQrCoaZ9eTaMJ6 LyZreCXhlITe54w8/nAoJQqR1MT0lng4VMdjk50ic74lIngkupWAX8LP4MdbOi/2+2Iv7vWyddQ 84CE+mDmILd/tAhNtIYRuWAG9SNSJYwiz6HH86q8PRcHy81lv/AkWklvQk/61pk5mdfUGE7XbV+ SWVx0b7qoIzy15jkM9A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-28_04,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 suspectscore=0 adultscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610280056 A recent fix in ADC5 Gen3 driver allocates a dedicated auxiliary-device ID through an IDA to ensure that ADC_TM auxiliary devices receive unique names on the auxiliary bus. However, each ADC instance is already assigned a unique IIO device ID. Reuse that existing identifier when registering the ADC_TM auxiliary device instead of maintaining a separate IDA solely for auxiliary device naming. This removes the custom ID allocation and release handling while preserving unique auxiliary device names across multiple ADC instances. Signed-off-by: Loic Poulain --- drivers/iio/adc/qcom-spmi-adc5-gen3.c | 24 +++++------------------- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/drivers/iio/adc/qcom-spmi-adc5-gen3.c b/drivers/iio/adc/qcom-spmi-adc5-gen3.c index f0b2544c16322374644ac3a2eda63322f318e25f..a23eb5c9096d765af7d76ad66b50ed895782b256 100644 --- a/drivers/iio/adc/qcom-spmi-adc5-gen3.c +++ b/drivers/iio/adc/qcom-spmi-adc5-gen3.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include #include @@ -609,16 +608,9 @@ static void adc5_gen3_delete_aux(void *data) auxiliary_device_delete(data); } -static DEFINE_IDA(adc5_gen3_aux_ida); +static void adc5_gen3_aux_device_release(struct device *dev) {} -static void adc5_gen3_aux_device_release(struct device *dev) -{ - struct auxiliary_device *adev = to_auxiliary_dev(dev); - - ida_free(&adc5_gen3_aux_ida, adev->id); -} - -static int adc5_gen3_add_aux_tm_device(struct adc5_chip *adc) +static int adc5_gen3_add_aux_tm_device(struct adc5_chip *adc, int id) { struct tm5_aux_dev_wrapper *aux_device; int i, ret, i_tm = 0; @@ -628,6 +620,7 @@ static int adc5_gen3_add_aux_tm_device(struct adc5_chip *adc) return -ENOMEM; aux_device->aux_dev.name = "adc5_tm_gen3"; + aux_device->aux_dev.id = id; aux_device->aux_dev.dev.parent = adc->dev; aux_device->aux_dev.dev.release = adc5_gen3_aux_device_release; @@ -650,16 +643,9 @@ static int adc5_gen3_add_aux_tm_device(struct adc5_chip *adc) aux_device->n_tm_channels = adc->n_tm_channels; - ret = ida_alloc(&adc5_gen3_aux_ida, GFP_KERNEL); - if (ret < 0) - return ret; - aux_device->aux_dev.id = ret; - ret = auxiliary_device_init(&aux_device->aux_dev); - if (ret) { - ida_free(&adc5_gen3_aux_ida, aux_device->aux_dev.id); + if (ret) return ret; - } ret = devm_add_action_or_reset(adc->dev, adc5_gen3_uninit_aux, &aux_device->aux_dev); @@ -814,7 +800,7 @@ static int adc5_gen3_probe(struct platform_device *pdev) return ret; if (adc->n_tm_channels > 0) { - ret = adc5_gen3_add_aux_tm_device(adc); + ret = adc5_gen3_add_aux_tm_device(adc, iio_device_id(indio_dev)); if (ret) dev_err_probe(dev, ret, "Failed to add auxiliary TM device\n"); --- base-commit: f1ac44c32cba88ad65dcecd4a279661d14e93651 change-id: 20261028-fix-adc5-tm-c96b13a4f442 Best regards, -- Loic Poulain