From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hiren Gohel <hiren.gohel@oss.qualcomm.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: qcom: Add SA8797P eUSB2 PHY
Date: Wed, 28 Oct 2026 13:59:21 +0100 [thread overview]
Message-ID: <20261028-nice-infallible-mongoose-3befcc@quoll> (raw)
In-Reply-To: <20261026094118.3264112-2-hiren.gohel@oss.qualcomm.com>
On Mon, Oct 26, 2026 at 03:11:17PM +0530, Hiren Gohel wrote:
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + phy@88e3000 {
> + compatible = "qcom,sa8797p-snps-eusb2-phy";
> + reg = <0x0 0x088e3000 0x0 0x154>;
> + #phy-cells = <0>;
> +
> + power-domains = <&scmi12_pd 1>, <&scmi12_pd 0>;
> + power-domain-names = "core", "transfer";
Please make the example complete - also phys property.
With this:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-28 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 9:41 [PATCH 0/2] Add support for SA8797P in the phy-snps-eusb2 phy driver Hiren Gohel
2026-10-26 9:41 ` [PATCH 1/2] dt-bindings: phy: qcom: Add SA8797P eUSB2 PHY Hiren Gohel
2026-10-27 11:00 ` Konrad Dybcio
2026-10-28 12:59 ` Krzysztof Kozlowski [this message]
2026-10-26 9:41 ` [PATCH 2/2] phy: snps-eusb2: Add support for SA8797P Hiren Gohel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028-nice-infallible-mongoose-3befcc@quoll \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hiren.gohel@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®