From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793164205; b=sZDF/Kfgrk99fEeQvYybzA/VPU1ix4lUjFCSM0C9mXvHWV1+OmwCOmVRYct6jWODRlXH a7cgP4IKYbUsCmHAYZWRVtjD31TyQh8pMgRh4FbWVoviKNa6dYtayJ6/RWYbScGidn5j3 02cKaz1+RXcgVU3PIAHLrWE3+YMZuZF7WbWym+n/w2g1UbOiTsC9/gwzyYDgIQs+GQ3ow Pla9wXlHyyzduajzx/cxI2MX3jrnWZOvX17wFaQNn7Q63q4+iIVJe10zN3wkc63oynlHb ECljjvLkyISdo/39FbdBGEuPAilFVN4BZIbNWhYsdP8rUkR3MUiNN3lxFBHFzRUYMEg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793164205; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From:To:Cc: Subject:Date:Message-Id:X-Mailer:MIME-Version: Content-Transfer-Encoding:X-Proofpoint-Spam-Info:X-Authority-Analysis: X-Proofpoint-GUID:X-Proofpoint-ORIG-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=e5W6PLruHf5ReVXisrJnJK3zbKxib4hojUPeC8YB9yg=; b=W9XZVI1Rsk0PaKPeWpQEL0cEJmPhsuVKXyHbWObVyaKbfKt7BON2zhWpt7wyka1JfT9t L7XYtNtgR2bvinH8zgm08f9J9tuGsolQYR69l2Z9+Tfq7OcqmFo+eQnylT3XmTLS/hsLx eOPLuTUncCc9lETd/9gRa11PXvsUl0e8VcLDFEWhGWj7iI/nnjWkzT1NwFOmcqbaI+hDT qiYeDJpxyd+o+J+1k8HlsVapunbFMSSCC7BYaIVwe4JJw7Ugy+vbtshlVlsXO+7uUu3xE KlFa5IbHkBONdN9XAfd5eAw6Ir+9Lz2aC28aAAt5FVqWff4ASbg9YSRAof0UXTrWrfA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=T5AEDCL9; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=BbN5iZmG; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ECB5606A320 for ; Wed, 28 Oct 2026 05:10:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2ECB5606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=T5AEDCL9; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=BbN5iZmG Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69S4PQ1w655214 for ; Wed, 28 Oct 2026 05:10:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=e5W6PLruHf5ReVXisrJnJK3zbKxib4hojUP eC8YB9yg=; b=T5AEDCL9mjhVY8bYsqtWdIFYc+kh1OrWEAG6OvdR6gzaZLK0BaF DDrAYsSYdPAaIP8D9YE97RmKoExz52lul6kbIWXsAW/56tl554kzFVpiIHR0hl6y +JChosL+MyI/Z0P75bnnVFPVsQsBNaCNk37r0EdmwJY0Hd2UJl8xGpZdH1rNNrZ+ NUb6ufob3H+eOorb6RfL9CvVwYnpPX4bMJL8qJVfdCMx2TC9r4FuIhsZVDVnsRTn ZqIrntEUqc/Ovi1oW9mVGAiwRkXFrKBZcZT++kmtV0tcsHB+ROK7zBomfOO9fI0F 0fDT3a4SVXcERFtzfZVCo3Fo+kQi/YzDuuw== Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hk7g7gmeb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Oct 2026 05:10:03 +0000 (GMT) Received: by mail-oo1-f69.google.com with SMTP id 006d021491bc7-6dfe0f03baeso890461eaf.1 for ; Tue, 27 Oct 2026 22:10:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793164203; x=1793769003; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=e5W6PLruHf5ReVXisrJnJK3zbKxib4hojUPeC8YB9yg=; b=BbN5iZmGGxdrbSDSU8seK3dITQtJoacUIU9NFSYWZKhE7rHasupqFhcqdx58JveB8k 1Bw07Q0FVvj9rstcnfSJm3HfCi7vcUdMKZSGBbGdsoefiXfHB9+nlzRudjUr1IXqdBQ4 Yf3wmDhz/RaaZ5rZg49IIHOg8lrqpMNWHVJKO7zFBhrwb7rY8D0XoWk1H1YPSUVBu3AE OX0gnaUmi2QPvlN/BwPIH3MhplD51h5iifb+ThvoIpHIULKTiJpgK5qJcHYGS/3BYCVI auPyThVUeWovYReN0UgCYj8+4fHSS0rXNYQsGFshMQPEOVr0RIf9iCJwng30o0lDJ6WJ dYSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793164203; x=1793769003; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=e5W6PLruHf5ReVXisrJnJK3zbKxib4hojUPeC8YB9yg=; b=V5Ip+frxfEHapj32j45/99bhNAyIt9AVRXcdtR8p8/G18C5kvXDmojMJp2sfeK/EIo 4JmKr90gK03S1OK0H94jaTJwQa9U6QjZSVpAaf1ma7M4TTVZ0jw/4rLmciDrD8tGod7H 4fuIvAXeFLTBILWhDEzj8yQNBebXtNikfGf2m2fpvETvFgorGU7FKfIb7U606GlA7qSM ILgWoNqHcwpNjhoCbId2KUfUhCICnBb00uaNEm3KtNFR1DciIHy82YHUh1nXi6xcurDQ /r4BL0+V6Tehm0qOxWZdWAMi3lm48XEK9W/iShqTk+KJarFW/g3LnESZQhk7Wb47drGu 7jXg== X-Forwarded-Encrypted: i=1; AKwUvBxzzkGmHIjWvmRmHHuGmuRYIcJ9takYTvT/izMmMCj/HctOYDniKZzI36Iq39XljR1viZq/qwT0nifN7Ao=@vger.kernel.org X-Gm-Message-State: AFq9FYIkGhDyIRvTzz2XigeCjitVJ0FluWvxeATdpaEwlGR4fUFXt77u 6/pzBqOVZR805Zgyer7WBkGJngfqhUTtv9k020H7857wy9hoKroHN0sukFY1YfYS96CqfbZHS85 dwkeYcbsQSCztma1bBE7nSeBB7AEL42mg2J/+MLT9TphSrVZASBB6qNrJ8jn6NpnVdUFsW8QwXh 8= X-Gm-Gg: AYBFou22YQGwP2EJXtnNOYBpcSNhzonEIEzblkS3t+nYpraFQ7cMBgwN86m5lnAb671 /VaY8XxEXwDuVLFMBCa1MpdtWACscmB+oY6SH/keyS0UKI59nCGqhNbQjR6QVr1W1sM7vrXdFa4 3uWU4e4Fg/JfqYJUbyd8va0scvHZNEWnWaUrh8+owgLTH7OnVWfBFjVbrT4U5DO58BoOH9zC/0b la/UX9XY87utmazGMDXOE6Hsp1WOH8LHJhtvQy/Ll17NWcKlnZGWaHKs/lhi/L0zw23xzMwXl1V U96WabHJOxRtoCrdqWYKE7Xir7qqjxUuohjOIFCPnBhP1msohwGPCxZPid21lg12hDPaPzAqaS8 1PK6hmoG9DoDYKX6pClKGDi8bCUvDEuA50gCbZfEDfs3m9qSgj9QiLzKBJmr/iUe5cU8cadPdCK aGQbLgHFBG6TawQ3Teu+eMLFG78fdr X-Received: by 2002:a05:6820:55d7:20b0:6e0:e81:e5e8 with SMTP id 006d021491bc7-713edca6cffmr498233eaf.34.1793164203192; Tue, 27 Oct 2026 22:10:03 -0700 (PDT) X-Received: by 2002:a05:6820:55d7:20b0:6e0:e81:e5e8 with SMTP id 006d021491bc7-713edca6cffmr498230eaf.34.1793164202777; Tue, 27 Oct 2026 22:10:02 -0700 (PDT) Received: from hu-aarunnan-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-85b1f436687sm650864a34.8.2026.10.27.22.10.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2026 22:10:02 -0700 (PDT) From: Anusha Arun Nandi To: kernel@oss.qualcomm.com, Bryan O'Donoghue Cc: gjorgji.rosikopulos@oss.qualcomm.com, hariram.purushothaman@oss.qualcomm.com, akapatra@quicinc.com, jigarkumar.zala@oss.qualcomm.com, Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , linux-phy@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] phy: qcom-mipi-csi2: Add support for single power-domain SoCs Date: Tue, 27 Oct 2026 22:10:00 -0700 Message-Id: <20261028051000.2650923-1-anusha.nandi@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMDI4MDAyMCBTYWx0ZWRfX4RvKkDuzAlcT Es/pcMpIaWzIILk0pj8BeJ49enf3LgOXtQjkAbSDkBA4b+rvA87K5I9vl6MyxguCrLXr9Li90hJ yBdht9r/MRJelIxBcd1tJAga9fWrupo= X-Authority-Analysis: v=2.4 cv=SoIFe/O0 c=1 sm=1 tr=0 ts=6ae183ab cx=c_pps a=lVi5GcDxkcJcfCmEjVJoaw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=uorg23y0nfgcnAkg4s0A:9 a=rBiNkAWo9uy_4UTK5NWh:22 X-Proofpoint-GUID: 5-Gcp1OiW6FS66sVLsLxQ_cTI-XgR1lZ X-Proofpoint-ORIG-GUID: 5-Gcp1OiW6FS66sVLsLxQ_cTI-XgR1lZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDI4MDAyMCBTYWx0ZWRfX8CF9Ztv3szO6 IsZpxWeaAPPN2LeQV755ldvwvBsSayqAj2ZRA0OpQR83Q58E/IrdQrQko5i6jvctA0kOOtiVBNv Bu5MLvuM0+/fylDsLjLqXWDHScOvtzgwxD4/koHACFUx6ZTNABeDDbU5eO6kbTBc3eeOcBubwvM Jeou98Q+IAhpuDBa8/wzRSiJ43phwTxKfN51AsTLj2379ROs+9lR4S8tiCenAaE8rORjd8O+c+l gAPvHrTzfmq7AyFVnVv5yY9m6EuFaiUfuGhhFcf9yKaMTsH0+TUoYAz+t5hxdCEYt4MvEyz7X7o 5dLOpm405EkQ6gKR5+jrDSVncX7RrB/e2+H8Y0RwEA3tTRJ77uP4SLYdMCNu1H04B+qTshecnYX wFrJuyamfV/+0JEN1e1fzhUGsjeNTUbHw9wmmL6CZIQuHmkBaztO0s6rYDWneUm6PWPd18/Vo5o VdqzeVFg4ENctYoUIuA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-28_02,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 spamscore=0 phishscore=0 impostorscore=0 adultscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610280020 sa8775p, qcs8300 and sc7280 each list exactly one power-domain ("top") on the CSI2 PHY node. For a device with a single power-domain phandle, the generic platform-bus code (platform_probe() -> dev_pm_domain_attach()) auto-attaches it via genpd_dev_pm_attach() before the driver's own probe() runs. phy_qcom_mipi_csi2_probe() then unconditionally calls devm_pm_domain_attach_list(), which fails with -EEXIST because dev->pm_domain is already set, and the driver treats that as fatal: qcom-mipi-csi2-phy ace6000.phy: error -EEXIST: Failed to attach power-domain list qcom-mipi-csi2-phy ace6000.phy: probe with driver qcom-mipi-csi2-phy failed with error -17 x1e80100 is unaffected: it lists three power-domains, so the generic code does not auto-attach any of them (auto-attach only applies to single-power-domain devices); the driver's explicit attach is the only one that runs. For the single power-domain case, call dev_pm_domain_attach() instead of devm_pm_domain_attach_list(): it returns early when dev->pm_domain is already set, so csi2phy->pd_list is left NULL rather than built up by hand. The three call sites that walk pd_list for genpd performance-state scaling now guard against a NULL pd_list, which is harmless since scaling is unused (scaled = false) on every SoC that has a single "top" domain. Signed-off-by: Anusha Arun Nandi --- drivers/phy/qualcomm/phy-qcom-mipi-csi2-core.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-mipi-csi2-core.c b/drivers/phy/qualcomm/phy-qcom-mipi-csi2-core.c index c0a4fa20eaf0..ac25e1e5f1c3 100644 --- a/drivers/phy/qualcomm/phy-qcom-mipi-csi2-core.c +++ b/drivers/phy/qualcomm/phy-qcom-mipi-csi2-core.c @@ -43,7 +43,7 @@ phy_qcom_mipi_csi2_set_clock_rates(struct mipi_csi2phy_device *csi2phy, } pstate = 0; - for (i = 0; i < csi2phy->pd_list->num_pds; i++) { + for (i = 0; csi2phy->pd_list && i < csi2phy->pd_list->num_pds; i++) { unsigned int perf; if (!csi2phy->soc_cfg->genpds[i].scaled) @@ -174,7 +174,7 @@ static int phy_qcom_mipi_csi2_power_on(struct phy *phy) unset_rate: dev_pm_opp_set_rate(csi2phy->dev, 0); - for (i = 0; i < csi2phy->pd_list->num_pds; i++) { + for (i = 0; csi2phy->pd_list && i < csi2phy->pd_list->num_pds; i++) { if (!csi2phy->soc_cfg->genpds[i].scaled) continue; @@ -204,7 +204,7 @@ static int phy_qcom_mipi_csi2_power_off(struct phy *phy) dev_pm_opp_set_rate(csi2phy->dev, 0); - for (i = 0; i < csi2phy->pd_list->num_pds; i++) { + for (i = 0; csi2phy->pd_list && i < csi2phy->pd_list->num_pds; i++) { if (!csi2phy->soc_cfg->genpds[i].scaled) continue; @@ -233,6 +233,10 @@ static int phy_qcom_mipi_csi2_attach_pm_domains(struct mipi_csi2phy_device *csi2 const char **pd_names; int i; + /* Single power-domain devices are already attached by the bus core. */ + if (csi2phy->soc_cfg->num_genpds == 1) + return dev_pm_domain_attach(csi2phy->dev, 0); + pd_names = devm_kzalloc(csi2phy->dev, sizeof(char *) * csi2phy->soc_cfg->num_genpds, GFP_KERNEL); @@ -369,11 +373,8 @@ static int phy_qcom_mipi_csi2_probe(struct platform_device *pdev) return ret; ret = phy_qcom_mipi_csi2_attach_pm_domains(csi2phy); - if (ret < 0 || csi2phy->pd_list == NULL) { - if (ret == 0) - ret = -ENODEV; + if (ret < 0) return dev_err_probe(dev, ret, "Failed to attach power-domain list\n"); - } ret = devm_pm_runtime_enable(dev); if (ret < 0) -- 2.34.1