From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Yury Norov <yury.norov@gmail.com>
Subject: [PATCH] lockdep: Add #include <linux/instruction_pointer.h> to lockdep.h
Date: Wed, 28 Oct 2026 11:05:58 -0400 [thread overview]
Message-ID: <20261028110558.623a92d1@gandalf.local.home> (raw)
From: Steven Rostedt <rostedt@goodmis.org>
On 32bit x86, _THIS_IP_ is not defined in asm/linkage.h. It happens to get
included into lockdep.h via kernel.h pulling in trace_printk.h which
includes instruction_pointer.h that has _THIS_IP_ defined when linkage.h
does not.
In order to remove trace_printk.h from kernel.h, have lockdep.h include
instruction_pointer.h directly.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
include/linux/lockdep.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h
index a6451ecbbe9a..c6b0168f5fc9 100644
--- a/include/linux/lockdep.h
+++ b/include/linux/lockdep.h
@@ -22,6 +22,7 @@ struct task_struct;
#include <linux/list.h>
#include <linux/debug_locks.h>
#include <linux/stacktrace.h>
+#include <linux/instruction_pointer.h> /* In case _THIS_IP_ isn't defined */
static inline void lockdep_copy_map(struct lockdep_map *to,
struct lockdep_map *from)
--
2.53.0
next reply other threads:[~2026-10-28 15:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 15:05 Steven Rostedt [this message]
2026-10-28 15:16 ` Yury Norov
2026-10-28 15:45 ` Steven Rostedt
2026-10-28 15:48 ` Yury Norov
2026-10-28 16:30 ` Steven Rostedt
2026-10-28 17:54 ` Yury Norov
2026-10-28 18:05 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028110558.623a92d1@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®