From: Reid Downing <skibletz@gmail.com>
To: David Laight <david.laight.linux@gmail.com>
Cc: Carlos Maiolino <cem@kernel.org>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
"Darrick J . Wong" <djwong@kernel.org>,
Eric Sandeen <sandeen@redhat.com>, Christoph Hellwig <hch@lst.de>,
Reid Downing <skibletz@gmail.com>
Subject: Re: [PATCH v2] xfs: fix wrong compat fields in xfs_ioctl32_bstat_copyin()
Date: Wed, 28 Oct 2026 07:31:27 -0400 [thread overview]
Message-ID: <20261028113127.3374246-1-skibletz@gmail.com> (raw)
In-Reply-To: <20261027161748.2760321-1-skibletz@gmail.com>
Hi David, Eric, Carlos,
Thank you all for the careful review, and Eric, thanks for catching
the second line.
I looked at the refactor David suggested and Eric sketched, and I
agree it is the better way to write this function. I'm not confident
enough in the 32-bit compat code to send it myself, and I only want to
send changes I can fully vouch for. If the refactor should go in, I'd
be glad to see it done.
Reid
prev parent reply other threads:[~2026-10-28 11:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 16:17 Reid Downing
2026-10-27 16:49 ` David Laight
2026-10-28 15:18 ` Christoph Hellwig
2026-10-28 11:31 ` Reid Downing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028113127.3374246-1-skibletz@gmail.com \
--to=skibletz@gmail.com \
--cc=cem@kernel.org \
--cc=david.laight.linux@gmail.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®