mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Danish Khateeb <danishkhateeb03@gmail.com>
To: Lee Jones <lee@kernel.org>
Cc: Danish Khateeb <danishkhateeb03@gmail.com>,
	Pavel Machek <pavel@kernel.org>, Andrew Davis <afd@ti.com>,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] leds: tca6507: Fix use-after-free on unbind
Date: Wed, 28 Oct 2026 08:48:57 -0500	[thread overview]
Message-ID: <20261028134857.36086-1-danishkhateeb03@gmail.com> (raw)
In-Reply-To: <179213356828.2581328.5085333261240588869@kernel.org>

On Wed, 28 Oct 2026, Lee Jones wrote:
> Please review, explain or fix the Sashiko review(s).

Sashiko is right that the "LED off" write queued on unbind gets
cancelled, but that predates 1b5c2fa7081c: remove() used to call
led_classdev_unregister() and then cancel_work_sync(), the same order
this patch restores. Since 1b5c2fa7081c that write only ran on freed
memory. If you'd like the LEDs turned off on unbind, I can send a
separate patch that flushes the work instead of cancelling it.

Thanks,
Danish

  reply	other threads:[~2026-10-28 13:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 14:40 Danish Khateeb
2026-10-28 12:29 ` Lee Jones
2026-10-28 13:48   ` Danish Khateeb [this message]
2026-10-28 15:19     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261028134857.36086-1-danishkhateeb03@gmail.com \
    --to=danishkhateeb03@gmail.com \
    --cc=afd@ti.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®