From: Mohamad Raizudeen <raizudeen.kerneldev@gmail.com>
To: ebiggers@kernel.org
Cc: ardb@kernel.org, Jason@zx2c4.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mohamad Raizudeen <raizudeen.kerneldev@gmail.com>
Subject: [PATCH] lib/crypto: aes: use memzero_explicit() instead of memset()
Date: Wed, 28 Oct 2026 19:56:36 +0530 [thread overview]
Message-ID: <20261028142636.5888-1-raizudeen.kerneldev@gmail.com> (raw)
aes_gcm_decrypt() and aes_ccm_decrypt() use plain memset() to wipe the
output buffer when authentication fails. But the compiler can optimize
that wipe away, so use memzero_explicit() instead of memset().
This matches every other sensitive wipes in this file, which already
uses memzero_explicit() for keystream blocks, tmp buffers, ctx
teardowns.
Signed-off-by: Mohamad Raizudeen <raizudeen.kerneldev@gmail.com>
---
lib/crypto/aes.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/crypto/aes.c b/lib/crypto/aes.c
index e1c191551736..7814ef525239 100644
--- a/lib/crypto/aes.c
+++ b/lib/crypto/aes.c
@@ -1733,7 +1733,7 @@ int aes_gcm_decrypt(u8 *dst, const u8 *src, size_t data_len, const u8 *authtag,
* Clear the inauthentic decrypted data so that callers won't
* receive it even if they fail to correctly handle errors.
*/
- memset(dst, 0, data_len);
+ memzero_explicit(dst, data_len);
}
return err;
}
@@ -2074,7 +2074,7 @@ int aes_ccm_decrypt(u8 *dst, const u8 *src, size_t data_len, const u8 *authtag,
* Clear the inauthentic decrypted data so that callers won't
* receive it even if they fail to correctly handle errors.
*/
- memset(dst, 0, data_len);
+ memzero_explicit(dst, data_len);
}
return err;
}
--
2.53.0
next reply other threads:[~2026-10-28 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 14:26 Mohamad Raizudeen [this message]
2026-10-28 15:51 ` Eric Biggers
2026-10-28 20:56 ` David Laight
2026-10-29 17:31 ` Eric Biggers
2026-10-30 3:32 ` Mohamad Raizudeen
2026-10-30 16:31 ` David Laight
2026-11-03 23:25 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028142636.5888-1-raizudeen.kerneldev@gmail.com \
--to=raizudeen.kerneldev@gmail.com \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®