From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.200 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793208640; b=xQmKxtgR/dJZrNgqDs/5SOThBt0o++pryRTCeM8YvKPRp//0hoYKGlYBKzUNHCO/8nRU CY1RJ8icZAViFrlReVTG6OEzcDjQgmN5vR7u3xWu7decVVLA+Ithfu7HxqWSYe9+xsCSK rgL0nn7kIULiux/qzC2DRDpen6/ZFmRS0MED1ws4rzUo0NjOvDr9VZu2gESOw21SBeRDa qhbuGv4ybXZh0y+oW3VSANnV3UA0ZzFn+gbgmzh5t19OvtvvqR5kixxmnNtOFC0X6l2Ec xdh7Cn56KA6MRPz/ZIBeonA/IKpVONE27p8Vy9iwsEqTUM2mimD/Kgcds+L4Aaku2Fg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793208640; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=aT/pVU6IgIaYwku4adsSNoBoyYJO/ByS0tjhWNwyOaU=; b=YQNHCiCY9IF8cSNfLh7EH0Q1H+SWdCFE0T0ucTCfjLxz2qk/eXHCANuXUeiWyMC0AIrl nAsU6x9C4BwprO8xh7Q9PlcMFNm9MrHxArNV2SZqwhUSelFTvnFMxrQMQpkBglyAh5sCO D+25sfIdsPhUWUZGTcNt6jRdQSxKS2NqIHt0Vl4iFLPF26AbFymsCq+i6gJsiXSua1RG7 8Iuz0STsGc1/go0AjxXja1j9gw/LQXYfSMQX+BVygSlA9iojrmJARewogvWNwq4JPHigl MHHCyOb6rvts8MLhFjS91pF+gU8bK0/FZRpXd050EEMTB75Rc+jst9rM6aTeHni2V0Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--rathodpriyank.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b="i8oSMlu/"; arc=none smtp.remote-ip=209.85.210.200 Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7C53606A322 for ; Wed, 28 Oct 2026 17:30:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C7C53606A322 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--rathodpriyank.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=i8oSMlu/ Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8a065d0e9deso1042078b3a.0 for ; Wed, 28 Oct 2026 10:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793208639; x=1793813439; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aT/pVU6IgIaYwku4adsSNoBoyYJO/ByS0tjhWNwyOaU=; b=i8oSMlu/WkbIYGthAShj23qls5PPa/cxrQ80XRTY7eJl6stpBqjqTJoVWruuxGySrD Zet9b9zdF8MYfRamF8DMgs5eTpbkL70dL230V2a5giSqkRbElhM3zmNCyl4TDOU21mF3 I3RNxSFADpGlcEccnqECxbVl5H2SzwAJeGg4F424R0B03qLvEhXDR1Tb1gRgpRx2Iuc/ CUw3ZMIVtBZO67OfWZ5JBfhx6S+/MgGHU3Bb5FrcpxKbCCCeWZaNkCWf+3RcGagxU3zQ V4DU3aAnNuK+8QFF6wVKtsVW16pHwRNHSQD0WqALj+8lM+nCIiN80jMQl1OaLNpyOFrH QWVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793208639; x=1793813439; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aT/pVU6IgIaYwku4adsSNoBoyYJO/ByS0tjhWNwyOaU=; b=Q/YPK2/UJcf1lYuBnLHM/B3yRzTvy6CXvLev8mNeEgSifmYAcXUFxDx4FxUmV5A42I Q5533QrdgUy4efX67sE3vNhbvEEKoFKZJHxysJdBVvl7ATyYlJWV7/U5HtjrTunLiOfj cMdlnaA/XDzh9xPluPRZBpD9AYBt7dLaly/HdTvpZTC+7ysXzkJuBoFzDzxLZe4cZVIv SCIJrjaDKsxYh/LTiWdimj7N/2NMljfct+VmWsKN6qO70fCc2+jrXqm2tSwbqoDKPwCA iDS7tJs1iGAKtt+agZmw+BIYgJMfWo0BsHpJ19RHZRgwb8v+baF7xsRJ8cyEYsPqSAYQ gmNQ== X-Forwarded-Encrypted: i=1; AKwUvBwwHo56hhqPTSPCld2mPhfqAKeG2fb5t/wQ5+NAWWkaaQkWDCBsKToGIy4psvmsWVJpWaYNR/BZpEht2fI=@vger.kernel.org X-Gm-Message-State: AFq9FYKkEn1tc5KxiX90XlBGGSYRpQdy1cDhGmjHHUFNlgKuJIj213o2 u1F2/R7nBgMIAcJr2O5rGDf85W2QVloeh82KuhBQ7jATERSF92u6DwlyB4kPis6kiWUV3RSzzpO EN1YEHD4MbV7W/NkG+gfJfsmsV+hLK5vJow== X-Received: from pfaq14.prod.google.com ([2002:a05:6a00:a88e:b0:89b:34dc:b094]) (user=rathodpriyank job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:2e93:b0:883:7868:94d7 with SMTP id d2e1a72fcca58-8a82efe49c7mr111145b3a.10.1793208638703; Wed, 28 Oct 2026 10:30:38 -0700 (PDT) Date: Wed, 28 Oct 2026 17:30:38 +0000 In-Reply-To: <20261027230853.GA519764@bhelgaas> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261012-fix-aer-mask-override-v1-0-49a0d7aeaea0@google.com> <20261012-fix-aer-mask-override-v1-1-49a0d7aeaea0@google.com> <20261027230853.GA519764@bhelgaas> X-Mailer: git-send-email 2.56.0.313.g2479322e68-goog Message-ID: <20261028173038.292999-1-rathodpriyank@google.com> Subject: Re: [PATCH 1/2] PCI/AER: Make aer_mask_override effective for injected errors From: Priyank Rathod To: Bjorn Helgaas Cc: bhelgaas@google.com, lukas@wunner.de, sathyanarayanan.kuppuswamy@linux.intel.com, ilpo.jarvinen@linux.intel.com, dave.jiang@intel.com, prarit@redhat.com, ying.huang@linux.alibaba.com, terry.bowman@amd.com, corbet@lwn.net, jic23@kernel.org, danielmaraboo@gmail.com, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hi Bjorn, Thank you for reviewing the patch! On Tue, Oct 27, 2026 at 06:08:53PM -0500, Bjorn Helgaas wrote: > Can you start with a one- or two-sentence description of what's going > on here? Evidently injecting some errors doesn't work as expected > today? As long as the justification is compelling and the code is > readable, I don't think we need quite as much detail about every > little implementation detail. Good point, thank you. Would a shorter commit log like the following look better to you? aer_mask_override=1 is supposed to allow injecting masked errors, but aer_inject() corrupts the hardware Mask registers with "&= !" and restores them before irq_inject_interrupt(), so aer_isr() still drops the error as masked. Emulate aer_mask_override in config space reads and writes instead of modifying the hardware Mask registers, and document the parameter with MODULE_PARM_DESC(). I am happy to send a v2 with this updated commit message, unless you prefer to adjust it directly when applying. Thanks, Priyank