From: mdshahid03@gmail.com
To: starblue@users.sourceforge.net, gregkh@linuxfoundation.org
Cc: legousb-devel@lists.sourceforge.net, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mohammad Shahid <mdshahid03@gmail.com>
Subject: [PATCH] USB: legousbtower: use stream_open for stream semantics
Date: Wed, 28 Oct 2026 23:58:01 +0530 [thread overview]
Message-ID: <20261028182802.25212-1-mdshahid03@gmail.com> (raw)
From: Mohammad Shahid <mdshahid03@gmail.com>
The LEGO USB Tower driver uses nonseekable_open() in tower_open()
However, its read and write have stream semantics.
Use stream_open instead to mark the file as a stream and disable
unnecessary file position handling.
The issue is reported by stream_open.cocci script as potential
deadlock between read and write operation.
Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>
---
drivers/usb/misc/legousbtower.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c
index 18dd4115befb..b849bd0e9664 100644
--- a/drivers/usb/misc/legousbtower.c
+++ b/drivers/usb/misc/legousbtower.c
@@ -313,7 +313,7 @@ static int tower_open(struct inode *inode, struct file *file)
struct tower_reset_reply reset_reply;
int result;
- nonseekable_open(inode, file);
+ stream_open(inode, file);
subminor = iminor(inode);
interface = usb_find_interface(&tower_driver, subminor);
--
2.43.0
reply other threads:[~2026-10-28 18:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028182802.25212-1-mdshahid03@gmail.com \
--to=mdshahid03@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=legousb-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=starblue@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®