From: Hungyu Lin <dennylin0707@gmail.com>
To: jirislaby@kernel.org
Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, dennylin0707@gmail.com
Subject: [PATCH] tty: n_tty: convert the full VTIME interval to jiffies
Date: Thu, 29 Oct 2026 00:20:52 +0000 [thread overview]
Message-ID: <20261029002052.54117-1-dennylin0707@gmail.com> (raw)
VTIME specifies a timeout in tenths of a second, but n_tty_read() divides
HZ by 10 before multiplying by VTIME. For supported HZ values that are
not divisible by 10, this truncates each decisecond and shortens the
requested interval. For example, HZ=128 and VTIME=40 produce 480 ticks
instead of 512 ticks for four seconds.
Convert the full interval to milliseconds before calling
msecs_to_jiffies(), for both the read and inter-byte timeouts. This
preserves zero VTIME and avoids accumulating the initial division's
rounding loss.
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
drivers/tty/n_tty.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
index e6a0f5b40d0a..e485cf36dfa1 100644
--- a/drivers/tty/n_tty.c
+++ b/drivers/tty/n_tty.c
@@ -2219,9 +2219,9 @@ static ssize_t n_tty_read(struct tty_struct *tty, struct file *file, u8 *kbuf,
if (!ldata->icanon) {
minimum = MIN_CHAR(tty);
if (minimum) {
- time = (HZ / 10) * TIME_CHAR(tty);
+ time = msecs_to_jiffies(100 * TIME_CHAR(tty));
} else {
- timeout = (HZ / 10) * TIME_CHAR(tty);
+ timeout = msecs_to_jiffies(100 * TIME_CHAR(tty));
minimum = 1;
}
}
--
2.43.0
next reply other threads:[~2026-10-29 0:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 0:20 Hungyu Lin [this message]
2026-10-29 6:23 ` Greg KH
2026-10-29 6:38 ` Hungyu Lin
2026-10-29 7:04 ` Greg KH
2026-10-29 7:52 ` Hungyu Lin
2026-10-29 8:09 ` Greg KH
2026-10-29 8:17 ` Hungyu Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261029002052.54117-1-dennylin0707@gmail.com \
--to=dennylin0707@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®