mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: fangyu.yu@linux.alibaba.com
To: jgg@nvidia.com
Cc: Ankit.Soni@amd.com, fangyu.yu@linux.alibaba.com,
	guoren@kernel.org, iommu@lists.linux.dev, joerg.roedel@amd.com,
	joro@8bytes.org, kevin.tian@intel.com,
	linux-kernel@vger.kernel.org, robin.murphy@arm.com,
	vasant.hegde@amd.com, will@kernel.org
Subject: Re: [PATCH] iommupt/kunit: Read an exact NR_SECONDARY_PAGETABLE snapshot for the leak check
Date: Thu, 29 Oct 2026 09:21:51 +0800	[thread overview]
Message-ID: <20261029012151.78138-1-fangyu.yu@linux.alibaba.com> (raw)
In-Reply-To: <20261028125910.GB3040767@nvidia.com>

>> The run fails consistently. In the example above, 14 of 21 tests
>> failed. With the proposed fix, the same command passes with 18
>> passed and 3 skipped.
>>
>> 3) Could you clarify what you meant by "disabling the check on !SMP"?
>
>Just
>
>if (!IS_ENABLED(CONFIG_SMP))
>
>With a comment explaining it
>

Got it, v2 will guard the assertion instead of open-coding the
vmstat snapshot:

  │ if (!IS_ENABLED(CONFIG_SMP))
  │    KUNIT_ASSERT_EQ(test, priv->orig_nr_secondary_pagetable,
  │                    global_node_page_state(NR_SECONDARY_PAGETABLE));

Thanks,
Fangyu

>Jason

      reply	other threads:[~2026-10-29  1:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 13:20 fangyu.yu
2026-10-15 13:40 ` Jason Gunthorpe
2026-10-16  1:12   ` fangyu.yu
2026-10-16 15:23     ` Jason Gunthorpe
2026-10-19  3:24       ` fangyu.yu
2026-10-28 12:59         ` Jason Gunthorpe
2026-10-29  1:21           ` fangyu.yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261029012151.78138-1-fangyu.yu@linux.alibaba.com \
    --to=fangyu.yu@linux.alibaba.com \
    --cc=Ankit.Soni@amd.com \
    --cc=guoren@kernel.org \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@nvidia.com \
    --cc=joerg.roedel@amd.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=vasant.hegde@amd.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®