mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhan Xusheng <zhanxusheng1024@gmail.com>
To: akpm@linux-foundation.org
Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev,
	shakeel.butt@linux.dev, muchun.song@linux.dev,
	penguin-kernel@I-love.SAKURA.ne.jp, tj@kernel.org,
	mkoutny@suse.com, cui.tao@linux.dev, cgroups@vger.kernel.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	zhanxusheng@xiaomi.com
Subject: Re: [PATCH v2] mm: memcontrol: don't miss processes whose leader has exited in OOM scans
Date: Thu, 29 Oct 2026 10:04:59 +0800	[thread overview]
Message-ID: <20261029020459.3335597-1-zhanxusheng1024@gmail.com> (raw)
In-Reply-To: <sashiko-outbox-188003@kernel.org>

On Wed, Oct 28, 2026 at 02:40:35PM +0000, sashiko-bot@kernel.org wrote:
> - [High] mm: memcontrol: missing CSS_TASK_ITER_WITH_DEAD in mem_cgroup_scan_tasks()

css_task_iter_advance() drops PF_EXITING tasks with !signal->live before
it looks at CSS_TASK_ITER_PROCS, so the current code doesn't see such a
victim either.  The patch keeps that.  The changelog's "until it is
gone" should read "while signal->live is non-zero"; I'll fix it if there
is a v3.

> - [Medium] mm: memcontrol: mem_cgroup_scan_skip() exposes left-behind exiting threads

That needs every remaining thread to be past exit_signals() while
signal->live is still non-zero; once it drops to zero the iterator hides
the left-behind thread too.  Without the patch, the left-behind leader
exposes the moved process to the source memcg's scans until then.

Thanks,
Zhan Xusheng

       reply	other threads:[~2026-10-29  2:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <sashiko-outbox-188003@kernel.org>
2026-10-29  2:04 ` Zhan Xusheng [this message]
2026-10-27 14:40 Zhan Xusheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261029020459.3335597-1-zhanxusheng1024@gmail.com \
    --to=zhanxusheng1024@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=cui.tao@linux.dev \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mkoutny@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=tj@kernel.org \
    --cc=zhanxusheng@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®