From: Haiyue Wang <haiyuewa@163.com>
To: platform-driver-x86@vger.kernel.org
Cc: "Haiyue Wang" <haiyuewa@163.com>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v1] platform: arm64: drop the vacuous THERMAL dependency from EC_ASUS_GLYMUR
Date: Thu, 29 Oct 2026 10:12:30 +0800 [thread overview]
Message-ID: <20261029021330.460192-1-haiyuewa@163.com> (raw)
'depends on THERMAL || THERMAL=n' is always true and is semantically a
no-op, but it couples NEW_LEDS, which is selected here, to THERMAL and
closes a Kconfig dependency loop. The C tools stay silent because they
fold the always-true expression to 'y' before running dependency loop
detection; kconfiglib, used by the Yocto kernel config audit, does not
fold and rejects the config at parse time.
The loop is easy to expose with the in-tree tools, using the technique
from commit b33a654a5bd6 ("drm/tiny: Kconfig: Remove always-y THERMAL
dep. from TINYDRM_REPAPER"),
https://git.kernel.org/linus/b33a654a5bd6: temporarily make THERMAL
tristate so the folding stops, then any config target reports it:
$ sed -i 's/bool "Thermal drivers"/tristate "Thermal drivers"/' \
drivers/thermal/Kconfig
$ make allnoconfig
error: recursive dependency detected!
symbol POWER_SUPPLY is selected by HID_ASUS
symbol HID_ASUS depends on LEDS_CLASS
symbol LEDS_CLASS depends on NEW_LEDS
symbol NEW_LEDS is selected by EC_ASUS_GLYMUR
symbol EC_ASUS_GLYMUR depends on THERMAL
symbol THERMAL is selected by AB8500_BM
symbol AB8500_BM depends on POWER_SUPPLY
Drop the vacuous line to break the loop; the driver still builds both
with and without THERMAL.
Fixes: db3a9dddab5f ("platform: arm64: Add a driver for the EC found on ASUS Glymur machines")
Signed-off-by: Haiyue Wang <haiyuewa@163.com>
Assisted-by: LLM
---
drivers/platform/arm64/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig
index 2a84775a13a9..3f879410b311 100644
--- a/drivers/platform/arm64/Kconfig
+++ b/drivers/platform/arm64/Kconfig
@@ -40,7 +40,6 @@ config EC_ASUS_GLYMUR
depends on HWMON
depends on INPUT
depends on PM
- depends on THERMAL || THERMAL=n
select NEW_LEDS
select LEDS_CLASS
help
--
2.56.0
next reply other threads:[~2026-10-29 2:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 2:12 Haiyue Wang [this message]
2026-10-29 8:08 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261029021330.460192-1-haiyuewa@163.com \
--to=haiyuewa@163.com \
--cc=bryan.odonoghue@linaro.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®