From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.49 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793243484; b=4VqLwdzM9U8IUl6VPc02eWNKvwvpeM0GFOuRFLZiz/Gz7PZijwxKRo9WlneSE/D5fQtV NlAVIfHOjs8dzwXwc7UNVBQ3L5sVYhYNPqrc4zhBxRQLDPhrJYfeuvZlSklDl+sQ1DXZh jb/DtmmC+10zEsGHP876OFMNHQ99DBeZ4TSXGrpaD2LlvJeX04XNRMgxw4UyvwyHFWl82 ErrsnsM5CS4WgapQDz/TaQmDB5qo3N0qNzZCdTPN5UKSMgD+qqZkRdq4dRBG6Ycs77tC+ EDnv3mH72evVWr+VP4fKb+jgg0HtJ76UCxY3/z3kxVlGeXv0IEJIs+JeceRxwZyDkUw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793243484; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=sDis0WLx8KUE2I1kamC2CNbijidM52hUokuP0aR4tyA=; b=JOJ7UJnNNaKPrCccoYCG2RK5Msa+rjGHlmo6bE86c+UcHpIT4kpaJId8cTBsUIYZ3XBG 6/JnJlTssrI3917zRvfj+Zlc/IVBsSvzsdxel15jbsTqEYfdOLidLIO14B8Glro6cPbUC sbGCEZ2nzWy09s40o/Lz624Q5vXa81h+qN0Ts5gJXoohDZIAIht75QfpGVVwRAg0mnDXp S7597+IM7R505P7Y7kwYgPQocKIb4PmS5Q/ZyZ2+ri4cvTMDO4IB1af35jxiIa9SKaDgI klmyyclrllHyVwzRoI+uM1TSWu8S/z/iCQITCdziTvCEbB4ZoK6dTh0d3I1Oi+sageA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=smartx.com; spf=pass smtp.mailfrom=smartx.com; dkim=pass header.d=smartx-com.20260707.gappssmtp.com header.i=@smartx-com.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=gTQgqc7f; arc=none smtp.remote-ip=74.125.82.49 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1934606A31C for ; Thu, 29 Oct 2026 03:11:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D1934606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=smartx.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=smartx.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=smartx-com.20260707.gappssmtp.com header.i=@smartx-com.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=gTQgqc7f Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-14fc585291cso1502137c88.1 for ; Wed, 28 Oct 2026 20:11:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smartx-com.20260707.gappssmtp.com; s=20260707; t=1793243482; x=1793848282; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sDis0WLx8KUE2I1kamC2CNbijidM52hUokuP0aR4tyA=; b=gTQgqc7fe00z38xS5VGL17ODfWk/PlBu1jih7V9N5ixOOIh4suNWXgN1PLiPkzxYyF Tj5/qsjjHD6FC5/PvMl06NBmfZ3VG73HPxA0eyYrakmgTH8JTSdNOXbqzcoVGBvP6OKF +Br9NIZBdNisAFJmXMlzO11v6I6/eqTCKXnm0BOPfeU6wx9VVv3ohYiteBGouPAD8p9D fF8VfgggBcpIqhP1nxJy6Lu04xwwpAH9jifgcptedlpc6It8WTUWiJ7LZq26bSWtxmxa ks3Y2p6zCXc2kGkI363E0lJBSzkEhk8eo0Xau9J6aJIC1GQGSPhi7gTdrFsXhKy2ea8p 30OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793243482; x=1793848282; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=sDis0WLx8KUE2I1kamC2CNbijidM52hUokuP0aR4tyA=; b=XNjfJGyldqvHiE2Nm5UnECb6zt58sJs9kzan/o5pEAb5iORxIxQ5yVj1k9i+UEwmXc xU7exils6CvAjQOZ9X83BJJJNHZ6/3mW457IZ62BXvQbCMpYse/TCbR0Lkjw0KLv+NmH 0U5H3/ZG6AYWiHpWQ0QF/fy0hrNdtumq+JOD3d2aY269+tC9++2bUeHtQBIecv+gujxY scIl7TkMb+EAkKzAKg63aPy800l0J/Jb6zm95eSdygfIyBf/Af3nR0teVlExoM7/fNA6 yLYxGbR3kEOBdie4FtkBg/GBsUo5pXbdU99u4+5hPWcbOo4cnCqMjIcCnAmIliU12SWT bNTA== X-Forwarded-Encrypted: i=1; AKwUvBw+XLgPlZfXA7pvsw7yiTiqyAAxL0Gv0sbVlDq3J6WcotHlKo9HlVufcZGfFtGam/cJUyetp6dDesgtgwE=@vger.kernel.org X-Gm-Message-State: AFq9FYKH0JLDR4ceHlKZP1d78dfdlmR+I1DwjK4w10rbPmr7BgwVvyW8 zqFsyctEt/u3v4Yaoo8eliuypncc7xBODWyUkgOzmI//KL77BY2SsoGPlL1Xc37BOH4dMihiRvV YEjsIro0P0cUWaNE/J3Avz6TyiZgyzPVEmFAWkBt/XvI3BPfFo+m+AwD99kk= X-Gm-Gg: AYBFou25LjhHlp3UAERs6L7q0O3AQ7PK3wlv99rxKhnfH5DwJruWNf4sjeMv64Z/EnD gNA3eb7ocWdyv0N505Av4xAHIl+Y7tieQniLA71Ggsn+C2dsbCCH72X+ecXivem1xxXgYxmWooe tXgdb/bzdso+7AKg2Gxp7cyH6MMVIa4vkPPSNAsnxDOFMIHDm0Y2cOIAyqacmyOsdfs48KysaLC zkEUSjEbgBUtaazwm7ZC2fqeznMqPamaniWvLFiGuTpOlKU79wZJlJjOJYAskXCdWaFfWe4LQ35 2neTEjymO4gL7KQqcJRupjatbBgfy2dchltPWWryESU94jI+1C2YRYOCOpL6jgx5XopgZxCTrjL qTmLtPWoYw6hmzwZdXq9TYVekWGwrjPmfZ2hzBt7HwwHxSE3YJ5Cb2QjdprpeqQljvD3jJzp4e2 CRUdlqR8EPvGTFCkDLU7dpj9Yj2RttlgIOcTzo4XOgFcn8P/FJfqMtLjIYJMEzgOF9S2ly+Crwq EskRtJhd32VzJgdNLm/++NYqo2ejjZXtwnR/WVp0Bfsb06nzT26j68v3rvUYxi9Ho1tACMpN3la p5p8EtNXZOiU6AAi4AeoedeN2DKntiki1k0fAFm5n6fW1iOLuDmk4wJCq/Zonj1v X-Received: by 2002:a05:7022:c89:b0:184:329d:eced with SMTP id a92af1059eb24-1a6ce4ea23dmr5028701c88.25.1793243481131; Wed, 28 Oct 2026 20:11:21 -0700 (PDT) Received: from localhost.localdomain ([179.255.112.163]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1a75f51bdebsm11705549c88.17.2026.10.28.20.11.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 20:11:20 -0700 (PDT) From: Wang Zhan To: netdev@vger.kernel.org, Yingjie Wang Cc: Wang Zhan , davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 1/2] net: preserve rps_default_mask on failed writes Date: Thu, 29 Oct 2026 11:10:36 +0800 Message-ID: <20261029031036.1133374-1-wang.zhan@smartx.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <7fc32d133404c078352f0b8fbcc80a67861bf2c3.1793199118.git.x-professor@outlook.com> References: <7fc32d133404c078352f0b8fbcc80a67861bf2c3.1793199118.git.x-professor@outlook.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, 28 Oct 2026 14:52:09 +0000 Yingjie Wang wrote: > @@ -105,27 +105,29 @@ static int rps_default_mask_sysctl(const struct ctl_table *table, int write, > void *buffer, size_t *lenp, loff_t *ppos) > { > struct net *net = (struct net *)table->data; > + struct cpumask *new_mask = NULL; > struct cpumask *mask; > int err = 0; > > + if (write) { > + new_mask = kzalloc(cpumask_size(), GFP_KERNEL); > + if (!new_mask) > + return -ENOMEM; > + } > + > mutex_lock(&rps_default_mask_mutex); > mask = net->core.rps_default_mask; > if (write) { > - if (!mask) { > - mask = kzalloc(cpumask_size(), GFP_KERNEL); > - net->core.rps_default_mask = mask; > - } > - err = -ENOMEM; > - if (!mask) > - goto done; > - > - err = cpumask_parse(buffer, mask); > + err = cpumask_parse(buffer, new_mask); > if (err) > goto done; > > - err = rps_cpumask_housekeeping(mask); > + err = rps_cpumask_housekeeping(new_mask); > + if (err) > + goto done; Please consider parsing and validating new_mask before taking rps_default_mask_mutex. It remains private to this handler until published.