From: Zhan Xusheng <zhanxusheng1024@gmail.com>
To: kayracizmeci@gmail.com
Cc: peterz@infradead.org, mingo@redhat.com,
tim.c.chen@linux.intel.com, yu.c.chen@intel.com,
kprateek.nayak@amd.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, linux-kernel@vger.kernel.org,
zhanxusheng@xiaomi.com
Subject: Re: [PATCH] sched/cache: Check reduced capacity before alb_break_llc()
Date: Thu, 29 Oct 2026 15:50:43 +0800 [thread overview]
Message-ID: <20261029075043.4013667-1-zhanxusheng1024@gmail.com> (raw)
In-Reply-To: <auLs7xeL9FsHcf-h@scheduler.schedules>
Hi Kayra,
On Thu, Oct 29, 2026 at 10:13:10AM +0300, Kayra Cizmeci wrote:
> Well yeah. alb_break_llc() just returns true in the nr_running <= 1
> case. FWIW, on my tip tree this just creates a conflict. On me
> alb_break_llc() is first, then asym_active_balance() and then
> imbalanced_active_balance(). I think in that case moving all three
> functions would be better? (below this other block that's for this case)
That's sched/core, which doesn't have ee92b7ef4c1e ("sched/cache: Honor
asym packing over cache aware scheduling on hybrid systems") yet. The
patch is on top of it and applies to tip/master.
Only alb_break_llc() needs to go below the capacity check, as it is the
only one that returns 0. The other two only return 1, so where they
sit relative to the capacity check doesn't matter.
imbalanced_active_balance() moves only to stay behind alb_break_llc().
Thanks,
Zhan Xusheng
next prev parent reply other threads:[~2026-10-29 7:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 2:36 Zhan Xusheng
2026-10-29 7:13 ` Kayra Cizmeci
2026-10-29 7:50 ` Zhan Xusheng [this message]
2026-10-29 8:13 ` Kayra Cizmeci
2026-10-29 8:18 ` Chen Yu
2026-10-29 8:18 ` Chen Yu
2026-10-29 8:55 ` Zhan Xusheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261029075043.4013667-1-zhanxusheng1024@gmail.com \
--to=zhanxusheng1024@gmail.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kayracizmeci@gmail.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yu.c.chen@intel.com \
--cc=zhanxusheng@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®