From: Ido Schimmel <idosch@nvidia.com>
To: Henry Martin <bsdhenrymartin@gmail.com>
Cc: Ilya Maximets <i.maximets@ovn.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Petr Machata <petrm@nvidia.com>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Antoine Tenart <atenart@redhat.com>,
Seungwon Bae <qotmddnjs@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net v5 1/2] vxlan: reject adding a remote to a nexthop fdb entry
Date: Thu, 29 Oct 2026 11:11:50 +0200 [thread overview]
Message-ID: <20261029091150.GA1187348@shredder> (raw)
In-Reply-To: <20261028111626.3460759-1-bsdhenrymartin@gmail.com>
Thank you for giving me two minutes to reply before posting a new
version [1][2].
[1] https://lore.kernel.org/netdev/CAEnQdOoQRuH8A=HnJqruN_kp5exzTwV7bK-LZUVo=LGuSMmgNA@mail.gmail.com/
[2] https://lore.kernel.org/netdev/20261027104713.328028-1-bsdhenrymartin@gmail.com/
On Wed, Oct 28, 2026 at 07:16:25PM +0800, Henry Martin wrote:
> FDB entries backed by a nexthop group must not carry a remote
> destination list. vxlan_fdb_update_existing() currently appends a
> remote via vxlan_fdb_append() on an NLM_F_APPEND request with a
> multicast or zero MAC even when the entry is backed by a nexthop,
> breaking that invariant through three different callers:
BUM traffic should always be flooded. It makes no sense to load balance
it between different VTEPs. Simply forbid the creation of a multicast /
all-zeroes FDB that points to an FDB nexthop in
vxlan_fdb_update_create(). This is net-next material.
prev parent reply other threads:[~2026-10-29 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 11:16 Henry Martin
2026-10-28 11:16 ` [PATCH net v5 2/2] vxlan: reject VNI add when the default fdb entry is nexthop-backed Henry Martin
2026-10-29 9:11 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261029091150.GA1187348@shredder \
--to=idosch@nvidia.com \
--cc=andrew@lunn.ch \
--cc=atenart@redhat.com \
--cc=bsdhenrymartin@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=ferruh.yigit@amd.com \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=qotmddnjs@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®