From: Satyam Gupta <sgsatyam@google.com>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: Satyam Gupta <sgsatyam@google.com>,
Scott Collyer <scollyer@google.com>,
Benson Leung <bleung@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/6] platform/chrome: cros_ec_sensorhub: Timestamp wrap and drift filter fixes
Date: Thu, 29 Oct 2026 09:31:54 +0000 [thread overview]
Message-ID: <20261029093154.1572188-1-sgsatyam@google.com> (raw)
In-Reply-To: <atbEIOCk16-Z15Kf@google.com>
On Tue, Oct 20, 2026 at 01:30:11AM +0000, Tzung-Bi Shih wrote:
> It seems the issues raised on v4 haven't been addressed. I'll stop
> reviewing v5.
Sorry about that, I missed your review of v4 [1] when preparing v5.
v6 [2] addresses all of it:
- Fixed the MAX_M unit mismatch. Measuring the actual drift showed about
2900 PPM between the AP and a standalone EC (MediaTek) and about 20 PPM
for the Intel ISH, so v6 keeps a 5000 PPM limit, now converted
correctly.
- Dropped "m = 0" and used -dx instead of abs(dx).
- Reset batch_state[].last_len when dropping a sample.
v6 also reworks "Fix AP/EC TS wrap". While testing I found that the v5
approach could still unwrap the sample and interrupt timestamps to
different overflow periods, so the sample timestamp is now derived from
the interrupt timestamp (patches 1 and 2).
[1] https://lore.kernel.org/all/as8mAFOdk7wgNqVd@google.com/
[2] https://lore.kernel.org/all/20261029092846.1567475-1-sgsatyam@google.com/
Best regards,
Satyam Gupta
prev parent reply other threads:[~2026-10-29 9:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 7:43 Satyam Gupta
2026-10-14 7:43 ` [PATCH v5 1/6] platform/chrome: cros_ec_sensorhub: Fix AP/EC TS wrap Satyam Gupta
2026-10-14 7:43 ` [PATCH v5 2/6] platform/chrome: cros_ec_sensorhub: Fix TS filter history shift index Satyam Gupta
2026-10-14 7:43 ` [PATCH v5 3/6] platform/chrome: cros_ec_sensorhub: Clamp clock drift slope to MAX_DRIFT_PPM Satyam Gupta
2026-10-14 7:43 ` [PATCH v5 4/6] platform/chrome: cros_ec_sensorhub: Reset TS filter on ODR or mode changes Satyam Gupta
2026-10-14 7:43 ` [PATCH v5 5/6] platform/chrome: cros_ec_sensorhub: Increase TS_HISTORY_BORED_US to 2s Satyam Gupta
2026-10-14 7:43 ` [PATCH v5 6/6] platform/chrome: cros_ec_sensorhub: Drop sensor samples with past timestamps Satyam Gupta
2026-10-20 1:30 ` [PATCH v5 0/6] platform/chrome: cros_ec_sensorhub: Timestamp wrap and drift filter fixes Tzung-Bi Shih
2026-10-29 9:31 ` Satyam Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261029093154.1572188-1-sgsatyam@google.com \
--to=sgsatyam@google.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=scollyer@google.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®