mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Pecio <michal.pecio@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: IgorpetinDev <igorpetindev@gmail.com>,
	Alan Stern <stern@rowland.harvard.edu>, Tejun Heo <tj@kernel.org>,
	Oliver Neukum <oneukum@suse.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	syzbot+a5b220cacb0618384d5a@syzkaller.appspotmail.com
Subject: Re: [PATCH v3] usb: core: hcd: flush giveback work on stop
Date: Thu, 29 Oct 2026 11:44:22 +0100	[thread overview]
Message-ID: <20261029114422.2ba64d53.michal.pecio@gmail.com> (raw)
In-Reply-To: <2026102924-flashily-myspace-60a8@gregkh>

On Thu, 29 Oct 2026 10:42:35 +0100, Greg Kroah-Hartman wrote:
> On Sun, Oct 25, 2026 at 10:54:57AM +0300, IgorpetinDev wrote:
> > Hi Michal,
> >   
> > > No such domain?
> > > Looks like you trusted an LLM ;)  
> > 
> > good catch, that was just a clumsy typo on my part: I accidentally typed
> > appspotmail.com instead of appspot.com in the closes tag, anyway - the syzbot ID
> > itself is valid. If Greg or Alan prefer a v4 to fix the URL typo, I'll
> > gladly resend it, or it can be fixed up when applying.  
> 
> Please fix up and send a new version.
> 
> thanks,
> 
> greg k-h

Hi Greg,

This race had been reported by syzbot previously and a patch
has been hanging on linux-usb since August.

https://lore.kernel.org/linux-usb/20260823125831.6ea35650.michal.pecio@gmail.com/

There is only a bit of controversy over flushing vs cancelling the
work. I think that cancelling (and leaking stray completions as opposed
to letting them run, likely UAF things and maybe corrupt memory) is the
right choice, as a courtesy to anyone who might create such bugs and
need to deal with them.

Regards,
Michal

  reply	other threads:[~2026-10-29 10:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23 17:40 [PATCH] usb: core: hcd: cancel giveback work synchronously " Igor Putko
2026-10-23 19:15 ` Alan Stern
2026-10-23 19:31   ` IgorpetinDev
2026-10-24  1:53     ` Alan Stern
2026-10-24  8:36 ` [PATCH v2] usb: core: hcd: flush giveback work " Igor Putko
2026-10-24 15:56 ` [PATCH v3] " Igor Putko
2026-10-24 18:28   ` Alan Stern
2026-10-24 22:06   ` Michal Pecio
2026-10-25  7:54     ` IgorpetinDev
2026-10-25 15:16       ` Alan Stern
2026-10-25 16:10         ` Michal Pecio
2026-10-26  1:09           ` Alan Stern
2026-10-29  9:42       ` Greg Kroah-Hartman
2026-10-29 10:44         ` Michal Pecio [this message]
2026-10-29 14:21           ` Alan Stern
2026-10-29 11:47   ` [PATCH v4] " Igor Putko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261029114422.2ba64d53.michal.pecio@gmail.com \
    --to=michal.pecio@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=igorpetindev@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=stable@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=syzbot+a5b220cacb0618384d5a@syzkaller.appspotmail.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®