mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: oe-lkp@lists.linux.dev, lkp@intel.com,
	linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>,
	linux-trace-kernel@vger.kernel.org, oliver.sang@intel.com
Subject: Re: [PATCH] selftests/tracing: Fix flakiness in trigger-hist-poll.tc by waiting for task exit
Date: Thu, 29 Oct 2026 16:34:52 -0400	[thread overview]
Message-ID: <20261029163452.00d0980c@gandalf.local.home> (raw)
In-Reply-To: <178459323652.354837.10711230683477156733.stgit@devnote2>

On Tue, 21 Jul 2026 09:20:36 +0900

I'm finally getting around to looking at this!

"Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:

> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-poll.tc b/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-poll.tc
> index 04eb8546fc07..d54d54f9ec77 100644
> --- a/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-poll.tc
> +++ b/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-poll.tc
> @@ -38,11 +38,7 @@ BGPID=$!
>  ${POLL} -I -t 4000 ${EVENT}/hist
>  echo 0 > tracing_on
>  
> -if [ -d /proc/${BGPID} ]; then
> -  echo "poll exits too soon"
> -  kill -KILL ${BGPID} ||:
> -  exit_fail
> -fi
> +wait ${BGPID} 2>/dev/null ||:
>  
>  if ! grep -qw "sleep" trace; then
>    echo "poll exits before event happens"
> @@ -60,11 +56,7 @@ BGPID=$!
>  ${POLL} -P -t 4000 ${EVENT}/hist
>  echo 0 > tracing_on
>  
> -if [ -d /proc/${BGPID} ]; then
> -  echo "poll exits too soon"
> -  kill -KILL ${BGPID} ||:
> -  exit_fail
> -fi
> +wait ${BGPID} 2>/dev/null ||:
>  
>  if ! grep -qw "sleep" trace; then
>    echo "poll exits before event happens"
> @@ -72,3 +64,5 @@ if ! grep -qw "sleep" trace; then
>  fi
>  
>  exit_pass
> +
> +

Hmm, any reason for the two added newlines here?

-- Steve

  reply	other threads:[~2026-10-29 20:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21  0:20 Masami Hiramatsu (Google)
2026-10-29 20:34 ` Steven Rostedt [this message]
2026-10-30  0:52   ` Masami Hiramatsu (Google)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261029163452.00d0980c@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mhiramat@kernel.org \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oliver.sang@intel.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®