mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: Thomas Gleixner <tglx@kernel.org>,
	syzbot <syzbot+74de56995244fe32ffe2@syzkaller.appspotmail.com>,
	linux-kernel@vger.kernel.org, peterz@infradead.org,
	syzkaller-bugs@googlegroups.com, Tony Luck <tony.luck@intel.com>,
	linux-edac@vger.kernel.org
Subject: Re: [PATCH V2] x86/mce: Serialize sysfs controls against CPU hotplug
Date: Thu, 29 Oct 2026 10:46:46 -0700	[thread overview]
Message-ID: <20261029174646.GDauOGhqHXpndpV5BL@fat_crate.local> (raw)
In-Reply-To: <20261029165636.GA5110@yaz-khff2.amd.com>

On Thu, Oct 29, 2026 at 12:56:36PM -0400, Yazen Ghannam wrote:
> The diff below fixes both.

No, we've been trying hard to fix this shit and I already told tglx offlist,
I am that >.< close from simply disabling any hotplug operations as long as
someone touches those sysfs files.

There is no good reason to be toggling those continuously and f*ck around with
CPU hotplug at the same time. You do those configurations and then done. Not
whack them all the time.

So this code needs to be simplified - not made an even crazier and
unmaintainable mess.

So, I don't know yet in detail how we are going to query the hotplug core
whether operations are in progress but once we do, those sysfs helpers should
simply do:

	if (hotplug_operations_in_progress)
		return -ECOMEBACKLATER;

And that hotplug_operations_in_progress should include partial hotplug. I.e.,
has someone done partial hotplug? If so, error too.

And that's it.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2026-10-29 17:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14  7:28 [syzbot] [kernel?] general protection fault in timers_dead_cpu syzbot
2026-08-17 21:14 ` Thomas Gleixner
2026-08-17 22:12   ` Thomas Gleixner
2026-08-18  0:21     ` Borislav Petkov
2026-08-17 22:14   ` [PATCH] timer: Keep debugobjects state consistent in migrate_timer_list() Thomas Gleixner
2026-08-18  8:56     ` [tip: core/urgent] " tip-bot2 for Thomas Gleixner
2026-08-17 23:55   ` [syzbot] [kernel?] general protection fault in timers_dead_cpu Borislav Petkov
2026-08-18  0:18     ` Borislav Petkov
2026-08-18  9:09       ` Thomas Gleixner
2026-10-23  9:18         ` [PATCH] x86/mce: Serialize sysfs controls against CPU hotplug Thomas Gleixner
2026-10-28 19:45           ` [PATCH V2] " Thomas Gleixner
2026-10-29 16:56             ` Yazen Ghannam
2026-10-29 17:46               ` Borislav Petkov [this message]
2026-10-29 18:08                 ` Yazen Ghannam
2026-10-29 19:02                   ` Borislav Petkov
2026-10-30 19:18               ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261029174646.GDauOGhqHXpndpV5BL@fat_crate.local \
    --to=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=syzbot+74de56995244fe32ffe2@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®