From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793297784; b=3JW3tLI6ULUv+moKF+3Sjs09eVTt8SBwFDjbiOwYBurnWWbBfL/UUPqhdEC8F5PJfeJX 6GvpgMIxz3fSAwXaiOOrZavB5xit7jHJYzejwvsjRKFDwLoDwMKOVFTkuP/QQNTNVTg7i LEsbyexLOwBeiI0kb1TB/LhzJSXPRg/mS/AR1q/IVFkEkXzVEpjlreRQXUT6gMyzRisgh ioUkmYCfgJ1Zo0ezUpEUiv+6nij3qebCGgl+zNLsoMgkJ7RKB859viGIi+Jt+RsLt7JRS t/pI3/UHmPdRlweot7czKwDUIxf0Mr2zHi342RHN9T97Yx1hReZqWPsffMFzstBG+ZQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793297784; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From:To:Cc: Subject:Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=kGCAJjCLhsAMNr80slCwUFe5tvwX7ZrzHAvRFP8FkYE=; b=LBWDFHlY6D/3ySZVu2z1Fr69yMAHH9cEXqej0cpVww/xhPUAYpCAWIYnFao2PymczRri OrfhCW0Ehb0DUmv5CoC2wV2jng4jGAiyFTRWGDdsADZ3wShh/cxXDDh5APGof4qlZR6ix pD7Ls4Pw4cVKtfAUsIT6EogI+580IAjYtl+OKxvOC9Rr6nKfIRkYXsk/Es0DcmKmw47NE cX4niI+GosbO/UqcCXvzh7yt/4CXmZYfy4JLMhKWUk58ANXM2OhtsosFG61d2tOOFHgFN wM/WkKE8tYSUFwBBEblupC9nsI8clbKdI5OJSzRs2n7vafzHdrYp3XqeKg8j2Sx25NA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b="e/7Bp0rR"; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=CAZUOY05; arc=none smtp.remote-ip=170.10.129.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9101F60A2603 for ; Thu, 29 Oct 2026 18:16:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9101F60A2603 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=e/7Bp0rR; dkim=pass (2048-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=CAZUOY05 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793297782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kGCAJjCLhsAMNr80slCwUFe5tvwX7ZrzHAvRFP8FkYE=; b=e/7Bp0rRChtya8YlUdgk1PNvm56ilW5gCehNkGv9smIoYNDeVPipIzy98tqYx1N92auerp 3sW6oRkuTGkKpiQm14tVdFjuvAaAKPbGIPascvc/geoW5eSQxhyIJH0zYxgnxIpOQ/Yssq cDNnFwKZOQesEP6DuBDIOHdR4F7kvVQ= Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-0mYSi8j6Pe-uNE-58liR2A-1; Thu, 29 Oct 2026 14:16:21 -0400 X-MC-Unique: 0mYSi8j6Pe-uNE-58liR2A-1 X-Mimecast-MFC-AGG-ID: 0mYSi8j6Pe-uNE-58liR2A_1793297780 Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-3692c5b061bso6556854eec.1 for ; Thu, 29 Oct 2026 11:16:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1793297780; x=1793902580; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kGCAJjCLhsAMNr80slCwUFe5tvwX7ZrzHAvRFP8FkYE=; b=CAZUOY05/XO+N2Zkx46MVbF4Sp6loMjB0pqzLS97jY7wusLufmdgNRqVG8C0HgFtOx 7JM1IM8SrugOthimf8wUVt1dFHbGqBV74jvhRKb9HMVaXErm0nxKGHOJ0BEz3gnMyhnY +u2Jm3hfYOsoWBMBc+mRSIQjx6y4HlEer7Dfk1uq2qtnOBbG4BQwjxWXJovETlTyIx1n 2bbql/y6Sk5zcWvXXgiUqiCGswB80gjUzPlUBQexP1bRPofB3TwEFom/doizjDwp0xmV +KefWfZW1Oq2sLSRoJcgQQFbzWz8VYC6hLJdJFlGd9iO0Ur28eWjPWFYx0UuJLZbOoNl +noQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793297780; x=1793902580; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=kGCAJjCLhsAMNr80slCwUFe5tvwX7ZrzHAvRFP8FkYE=; b=mPpxkkB9QNYkzkicOLt0uUBXBis416TZlb7MctpWK8TAkvCCgdJa3fkDX/Kf5vuHgb jhYUjZcXGVaPBErt0ladAgG37S62Ar+MDqGORaLQG4E0ug4UexAL1Vh0jIwxLZP+G+gZ LUhwG211muS5e2LR3pZkltgz6ZQ7dgVaVfo3EjC2UZ/eMQmSvce5/Ev83wjL948+cHha 1bzDY3PagJ+Og9q6X+JEUjr1Fxr7ncswijsTIOXqr/7b01mcfkueAZ11RxBBrGODmNok 2nHhX6zDxna4zgD5u6tIQiPRh0NwYbPojn19oL8j6+EypTNZ8x+I/LBSSCHysOu9q8gA OVwg== X-Gm-Message-State: AFq9FYLLzrV8jKZB59s9pwmRAFyEIi1qt4AYtne1Ld/guL4geM/KaHg9 DRQtbbjZMIwtl2IUs/a8BTmiK+VI2r0I97cigzHgp6DgIDM36eG1CzzWwjTO8eJj9sh8880X6rI 7z/sriuZKoeyhB4ADDd/fu83LisGIKJDvbgVARW0Us0M+wMiQm3c7J4okn8aDJOrJNAMWPpn5tW /GGjaqr4qg88Py56Rhh4/O20IKxXEhws3DG8x1QQGDubpb+p7M X-Gm-Gg: AYBFou3ALlSyLOlsV7PrAhxAFFD5hawAYcksn8vZJ0/tr4/C24ksgOKzffPL11l78Vm s5SXEZ5Wo/Itq4asZ+gZi9GFwc+3upaVMDUb35/gpY7PmgXeEL7InqXp+eUvm/6wzkdV2JCx0vr 881ovWvULmWZ/zSQlo8jQ2WTU484O/1Y+29x3AHDpF37DvIW+6ykpXTnIETbtl3wkWcEd2k8pXs kP8vkxKpmWx3tIInwON7pI521at6+q/pJ5SBcDrLkd9pAVgio0ZDkNm40S1b4S49E8dHqL3a8lG EXDEnKiuKOt3jIcnNIFvqa8NnxKrr/7ir5r9NRPvdshveZErYFL9rh4KG0DM0QRCqw9IlrlyAz6 iTp7WC/eave7rMG8/U1uDR+gs1m3eDQMS/+9sVCB74sIn+8ejAM6O8g7SW2OtGiBGK17amMdAw6 unfvWUrwAgHSUQVg== X-Received: by 2002:a05:693c:42cb:b0:35e:51d6:9f6f with SMTP id 5a478bee46e88-36a423bf856mr219680eec.27.1793297779825; Thu, 29 Oct 2026 11:16:19 -0700 (PDT) X-Received: by 2002:a05:693c:42cb:b0:35e:51d6:9f6f with SMTP id 5a478bee46e88-36a423bf856mr219626eec.27.1793297778887; Thu, 29 Oct 2026 11:16:18 -0700 (PDT) Received: from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.47.195.13]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-36a428af4e6sm259163eec.4.2026.10.29.11.16.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2026 11:16:18 -0700 (PDT) From: Arun Menon To: linux-kernel@vger.kernel.org Cc: Jarkko Sakkinen , Jason Gunthorpe , Peter Huewe , linux-integrity@vger.kernel.org, Arun Menon Subject: [PATCH v5 6/7] tpm_crb: Factor crb_send()/crb_recv() bodies into helpers Date: Thu, 29 Oct 2026 23:45:40 +0530 Message-ID: <20261029181541.99505-7-armenon@redhat.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261029181541.99505-1-armenon@redhat.com> References: <20261029181541.99505-1-armenon@redhat.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arun Menon A later patch adds CRB chunking, which needs its own send/receive loops alongside the existing single-shot transfer. Move the body of crb_send() into tpm_crb_send_no_chunks() and the body of crb_recv() into tpm_crb_recv_no_chunks(). Pure code motion, no behavior change. Also fix the block comment to the kernel's preferred multi-line style. Signed-off-by: Arun Menon --- drivers/char/tpm/tpm_crb.c | 71 ++++++++++++++++++++++++-------------- 1 file changed, 45 insertions(+), 26 deletions(-) diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c index 30ca8192d3a8..f0bac9e1f1e8 100644 --- a/drivers/char/tpm/tpm_crb.c +++ b/drivers/char/tpm/tpm_crb.c @@ -369,24 +369,13 @@ static u8 crb_status(struct tpm_chip *chip) return sts; } -static int crb_recv(struct tpm_chip *chip, u8 *buf, size_t count) +static int tpm_crb_recv_no_chunks(struct tpm_chip *chip, u8 *buf, size_t count) { struct crb_priv *priv = dev_get_drvdata(&chip->dev); unsigned int expected; - /* A sanity check that the upper layer wants to get at least the header - * as that is the minimum size for any TPM response. - */ - if (count < TPM_HEADER_SIZE) - return -EIO; - - /* If this bit is set, according to the spec, the TPM is in - * unrecoverable condition. - */ - if (ioread32(&priv->regs_t->ctrl_sts) & CRB_CTRL_STS_ERROR) - return -EIO; - - /* Read the first 8 bytes in order to get the length of the response. + /* + * Read the first 8 bytes in order to get the length of the response. * We read exactly a quad word in order to make sure that the remaining * reads will be aligned. */ @@ -399,6 +388,28 @@ static int crb_recv(struct tpm_chip *chip, u8 *buf, size_t count) memcpy_fromio(&buf[8], &priv->rsp[8], expected - 8); return expected; + +} + +static int crb_recv(struct tpm_chip *chip, u8 *buf, size_t count) +{ + struct crb_priv *priv = dev_get_drvdata(&chip->dev); + + /* + * A sanity check that the upper layer wants to get at least the header + * as that is the minimum size for any TPM response. + */ + if (count < TPM_HEADER_SIZE) + return -EIO; + + /* + * If this bit is set, according to the spec, the TPM is in + * unrecoverable condition. + */ + if (ioread32(&priv->regs_t->ctrl_sts) & CRB_CTRL_STS_ERROR) + return -EIO; + + return tpm_crb_recv_no_chunks(chip, buf, count); } static int crb_do_acpi_start(struct tpm_chip *chip) @@ -474,12 +485,29 @@ static int tpm_crb_start(struct tpm_chip *chip, u32 start_cmd) return rc; } -static int crb_send(struct tpm_chip *chip, u8 *buf, size_t bufsiz, size_t len) +static int tpm_crb_send_no_chunks(struct tpm_chip *chip, u8 *buf, size_t len) { struct crb_priv *priv = dev_get_drvdata(&chip->dev); int rc = 0; - /* Zero the cancel register so that the next command will not get + memcpy_toio(priv->cmd, buf, len); + + /* Make sure that cmd is populated before issuing start. */ + wmb(); + + rc = tpm_crb_start(chip, CRB_START_INVOKE); + if (rc) + return rc; + + return crb_try_pluton_doorbell(priv, false); +} + +static int crb_send(struct tpm_chip *chip, u8 *buf, size_t bufsiz, size_t len) +{ + struct crb_priv *priv = dev_get_drvdata(&chip->dev); + + /* + * Zero the cancel register so that the next command will not get * canceled. */ iowrite32(0, &priv->regs_t->ctrl_cancel); @@ -494,16 +522,7 @@ static int crb_send(struct tpm_chip *chip, u8 *buf, size_t bufsiz, size_t len) if (priv->sm == ACPI_TPM2_COMMAND_BUFFER_WITH_PLUTON) __crb_cmd_ready(&chip->dev, priv, chip->locality); - memcpy_toio(priv->cmd, buf, len); - - /* Make sure that cmd is populated before issuing start. */ - wmb(); - - rc = tpm_crb_start(chip, CRB_START_INVOKE); - if (rc) - return rc; - - return crb_try_pluton_doorbell(priv, false); + return tpm_crb_send_no_chunks(chip, buf, len); } static void crb_cancel(struct tpm_chip *chip) -- 2.56.0