mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Clark <robin.clark@oss.qualcomm.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
	Alexander Koskovich <akoskovich@pm.me>,
	Jie Zhang <jie.zhang@oss.qualcomm.com>,
	Akhil P Oommen <akhilpo@oss.qualcomm.com>,
	Bhaskar Reddy Valluru <bvalluru@qti.qualcomm.com>,
	Rob Clark <robin.clark@oss.qualcomm.com>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 11/16] drm/msm: Inhibit IFPC for state snapshot
Date: Thu, 29 Oct 2026 13:16:21 -0700	[thread overview]
Message-ID: <20261029201730.151754-12-robin.clark@oss.qualcomm.com> (raw)
In-Reply-To: <20261029201730.151754-1-robin.clark@oss.qualcomm.com>

We need the GPU to stay awake for this.

Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
---
 drivers/gpu/drm/msm/msm_debugfs.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/msm/msm_debugfs.c b/drivers/gpu/drm/msm/msm_debugfs.c
index f12701e286ec..f068315541e8 100644
--- a/drivers/gpu/drm/msm/msm_debugfs.c
+++ b/drivers/gpu/drm/msm/msm_debugfs.c
@@ -86,7 +86,17 @@ static int msm_gpu_open(struct inode *inode, struct file *file)
 
 	pm_runtime_get_sync(&gpu->pdev->dev);
 	msm_gpu_hw_init(gpu);
+
+	/* Inhibit IFPC while accessing registers: */
+	if (gpu->funcs->sysprof_setup)
+		gpu->funcs->sysprof_setup(gpu, true);
+
 	show_priv->state = gpu->funcs->gpu_state_get(gpu);
+
+	/* Re-enable IFPC: */
+	if (gpu->funcs->sysprof_setup)
+		gpu->funcs->sysprof_setup(gpu, false);
+
 	pm_runtime_put_sync(&gpu->pdev->dev);
 
 	mutex_unlock(&gpu->lock);
-- 
2.56.0


  parent reply	other threads:[~2026-10-29 20:18 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 20:16 [PATCH v3 00/16] drm/msm/a8xx: GPU state capture support Rob Clark
2026-10-29 20:16 ` [PATCH v3 01/16] drm/msm: Import adreno_snapshot.h Rob Clark
2026-10-29 20:16 ` [PATCH v3 02/16] drm/msm/a8xx: Export aperture helpers Rob Clark
2026-10-29 20:16 ` [PATCH v3 03/16] drm/msm/a8xx: Add a8xx_aperture_acquire_raw() Rob Clark
2026-10-29 20:16 ` [PATCH v3 04/16] drm/msm/a8xx: Export slice helper Rob Clark
2026-10-29 20:16 ` [PATCH v3 05/16] drm/msm/a8xx: Add missing a850 ifpc reglist entries Rob Clark
2026-10-30  8:32   ` Konrad Dybcio
2026-10-29 20:16 ` [PATCH v3 06/16] drm/msm/a8xx: Allow nonctx reglist to include GMU regs Rob Clark
2026-10-29 20:16 ` [PATCH v3 07/16] drm/msm/a8xx: Stop getting GMEM_PROTECT from nonctx list Rob Clark
2026-10-30 13:43   ` Konrad Dybcio
2026-10-30 14:22     ` Rob Clark
2026-10-29 20:16 ` [PATCH v3 08/16] drm/msm/adreno: Fix PROTECT span length Rob Clark
2026-10-30 13:45   ` Konrad Dybcio
2026-10-29 20:16 ` [PATCH v3 09/16] drm/msm/adreno: add temporary __maybe_unused Rob Clark
2026-10-29 20:16 ` [PATCH v3 10/16] drm/msm/a8xx: Import generated headers Rob Clark
2026-10-29 20:16 ` Rob Clark [this message]
2026-10-29 20:16 ` [PATCH v3 12/16] drm/msm/a8xx: devcoredump state capture support Rob Clark
2026-10-29 21:20   ` Alexander Koskovich
2026-10-30 15:24     ` Rob Clark
2026-10-29 20:16 ` [PATCH v3 13/16] drm/msm/a8xx: Add all CP_PROTECT_PIPE to pwrup reglist Rob Clark
2026-10-30 13:46   ` Konrad Dybcio
2026-10-30 14:42     ` Rob Clark
2026-10-29 20:16 ` [PATCH v3 14/16] drm/msm/a8xx: Use CP_PROTECT_PIPE regs Rob Clark
2026-10-30 14:14   ` Konrad Dybcio
2026-10-29 20:16 ` [PATCH v3 15/16] drm/msm/a8xx: Switch to generated protect regs Rob Clark
2026-10-29 20:16 ` [PATCH v3 16/16] drm/msm/adreno: Remove temporary __maybe_unused Rob Clark
2026-10-29 21:36 ` [PATCH v3 00/16] drm/msm/a8xx: GPU state capture support Alexander Koskovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261029201730.151754-12-robin.clark@oss.qualcomm.com \
    --to=robin.clark@oss.qualcomm.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=akhilpo@oss.qualcomm.com \
    --cc=akoskovich@pm.me \
    --cc=bvalluru@qti.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=jie.zhang@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®