From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.70 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793308601; b=3mcZ4TqSK/ho/qUNanUQzWPIiAPRnwwsK60wBwWatIoFArPgy92O1+YcbXAYB8UcvHSC 7Rknk5nQmwEXTARX7J6IcVM/Aeij2oYVVdo0g5hWkgLCNLeR1G930zsoj/+V1HNVKfHQ8 9We38cCPSsiPL5R83p+pTobLBstjV6ahBFW2O5N6D1BP09GRrwGnnz3vZUgJnhBazz/IR 9VPNkZvi8xIshiIKNWLQo2Sphd8k7QGbgHtSJHG5wmaxp3O9PsNEUoaEJfKxP5bhUhgm3 wirzvF6GBXqsnWQaNmcIvWdoWIbaQHuE1k9XQXw3Yg+ICAoF6bw7Dn+JJLf5Bsf0YOQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793308601; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=kj+EtbVH78ECXqmNIitGQzkU9uA9+mq5+q5O6E7IA5c=; b=1bGP/cK7mSu4200KuQyYcF3GrUdHoeGVEAlt+MbwhlX+Lk+hbJgWXwITESMOAdYJQxAG znzhG7ahRXWLowExxgNFKZ9bBBYrpNe0kwJ1FvuTTUYzh6rnOwwsyiJ5mNhSJxbhJK3Hn sMqJlS3n/4BL5w2i8j9QBkB27yde8ab6QBWiSjchujoWswjHcFcBckgldpbdKBo8SFweB dZjjIoG5FvEfOpYcNZDIG0zYaeGdtx/czm+zIYS8e1cp7AVQzyzl3Ax4IaEjDm/1mizIw W+tvg9IDRb6fLYbQ88Z6RQeX4Y7iNrqG2Btr1Q4kFdNs84S3p4lKJuZ4fmkx8geHHGA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--hramamurthy.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=VNnUPS3F; arc=none smtp.remote-ip=209.85.216.70 Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3813D606A338 for ; Thu, 29 Oct 2026 21:16:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3813D606A338 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--hramamurthy.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=VNnUPS3F Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3ac77c3ff6aso69901a91.0 for ; Thu, 29 Oct 2026 14:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793308599; x=1793913399; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kj+EtbVH78ECXqmNIitGQzkU9uA9+mq5+q5O6E7IA5c=; b=VNnUPS3F4AVqZ0M+URj0605aonRqPsu//CMzi9tuFHWWrjbIQFrwOCL5mYqYGpkuBQ LmrB1KB1gljRlUjie/huybAlpm60uzoDfcHB7bqxMLaqE1EKdE4PmnB4vgA9p0u+D1KV gsMufCb1NgGjWIj1xdTUjH+xL3IoKvsQyjZIeXbs6Uct1ecaHBCrGWNapYpG6wVkVtdM 70dMjQ/Hl/6Glbr7efSEkh7Lv4Byc8y5n1vU70Gq7GQPqsX8BPHqRQVQeCIN0WXy1MXb PCxFywnqr87l1rGBf1b5A6TP5fYwO2BnCS+qaIGQ4PodQoV7u+MFKSL8RcYK03v6fcHV 2e6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793308599; x=1793913399; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kj+EtbVH78ECXqmNIitGQzkU9uA9+mq5+q5O6E7IA5c=; b=wuPBTIwmLa3x53KESxnCjkyM/cVoozPNG4pqIuT1nJ0eHB1qOIofJtFQRiohQZyeEb ws4BCTW2vSj9Sqt4kykJw8MpRGel3yHvymZBnzXu37TB8URnjONDlRvvsDqx05emOXPs c26fgZNk7X/xnNVZNT9OBBlx1QpGU97TGqFPNv/khsoAQuohk+O2hZ8R1Bhbp/n725hq lZgH7v/h4/w40EFEA0G3ECgH0/hFx84/gKubdAeRoHJYA0SFH2k51HDy3PrsAbCPOPTJ Ey0KwuEHS7jKthEnNr/6xdkm+pgQu2riIvLbYY3xvogT80m6oBiVrK2DXf7m660+jXz+ DQjA== X-Forwarded-Encrypted: i=1; AKwUvBwwN0SOWzOmBP4vDo+KiEYohfQniTk41f6D5Fhxz8JoredU9ZQ6prbOWeIMlenkGZiQYIODrzWtB4SRBDY=@vger.kernel.org X-Gm-Message-State: AFq9FYJljiGdNOXWmHc1Oy6iLG2whUu6VivfZXaypzrtchRgPw7Zb1VZ ZXoWQWPhTV8W0g9FFXi5SKzzGO4U40iMgsbGbhpBnRXKKL9apqpGXrAfYfhc+3j0Rz+Rbg0UHe9 qzXBj7ayRwMMrg6wo6DQitKz9kw== X-Received: from pjbgo10.prod.google.com ([2002:a17:90b:3ca:b0:3ab:c012:2f80]) (user=hramamurthy job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2252:b0:3a7:8c68:6446 with SMTP id 98e67ed59e1d1-3ae8987d10amr159004a91.63.1793308599354; Thu, 29 Oct 2026 14:16:39 -0700 (PDT) Date: Thu, 29 Oct 2026 21:16:33 +0000 In-Reply-To: <20261029211634.2232784-1-hramamurthy@google.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261029211634.2232784-1-hramamurthy@google.com> X-Mailer: git-send-email 2.56.0.317.g454f8302e1-goog Message-ID: <20261029211634.2232784-4-hramamurthy@google.com> Subject: [PATCH net v4 3/4] gve: Block invalid ring sizes when device options are 0 From: Harshitha Ramamurthy To: netdev@vger.kernel.org Cc: joshwash@google.com, hramamurthy@google.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, jordanrhee@google.com, willemb@google.com, przemyslaw.kitszel@intel.com, nktgrg@google.com, maolson@google.com, jacob.e.keller@intel.com, pkaligineedi@google.com, yangchun@google.com, patricion@google.com, awogbemila@google.com, stable@vger.kernel.org, linux-kernel@vger.kernel.org, Pin-yen Lin Content-Type: text/plain; charset="UTF-8" From: Pin-yen Lin On older device versions, minimum ring sizes in the device option are reported as 0. The driver imports these 0 values, allowing userspace (`ethtool -G`) to request invalidly small ring sizes. This issue was discovered and actually triggered by the drivers/net/ring_reconfig.py selftest (ringparam test case). Halving the ring size down to 1 triggered a kernel NULL pointer dereference in gve_tx_alloc_rings_dqo(): BUG: kernel NULL pointer dereference, address: 0000000000000002 RIP: 0010:gve_tx_alloc_rings_dqo+0x1c4/0x510 [gve] Call Trace: gve_queues_mem_alloc+0x29/0xa0 [gve] gve_adjust_config+0x1b/0x140 [gve] gve_set_ringparam+0x1f4/0x250 [gve] ethnl_set_rings+0x260/0x440 ... Fix this by falling back to the driver's default minimum ring sizes (GVE_DEFAULT_MIN_RX_RING_SIZE and GVE_DEFAULT_MIN_TX_RING_SIZE) whenever the device option reports minimum ring sizes as 0. This change was tested using the DQO RDA queue format. Cc: stable@vger.kernel.org Fixes: ed4fb326947d ("gve: add support to read ring size ranges from the device") Signed-off-by: Pin-yen Lin Reviewed-by: Joshua Washington Reviewed-by: Jordan Rhee Signed-off-by: Harshitha Ramamurthy --- Changes in v4: - No changes Changes in v3: - Retitled and refined the commit message drivers/net/ethernet/google/gve/gve_adminq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/google/gve/gve_adminq.c b/drivers/net/ethernet/google/gve/gve_adminq.c index 8b215fca9c1b..2c848f0c23dc 100644 --- a/drivers/net/ethernet/google/gve/gve_adminq.c +++ b/drivers/net/ethernet/google/gve/gve_adminq.c @@ -191,7 +191,9 @@ void gve_parse_device_option(struct gve_priv *priv, *dev_op_modify_ring = (void *)(option + 1); /* device has not provided min ring size */ - if (option_length == GVE_DEVICE_OPTION_NO_MIN_RING_SIZE) + if (option_length == GVE_DEVICE_OPTION_NO_MIN_RING_SIZE || + be16_to_cpu((*dev_op_modify_ring)->min_rx_ring_size) == 0 || + be16_to_cpu((*dev_op_modify_ring)->min_tx_ring_size) == 0) priv->device_info.default_min_ring_size = true; break; case GVE_DEV_OPT_ID_FLOW_STEERING: -- 2.56.0.313.g2479322e68-goog