mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Wang Yibo <szwyb123@gmail.com>
Cc: David Gow <david@davidgow.net>,
	linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/tests: convert test_memcat_p module to KUnit
Date: Thu, 29 Oct 2026 23:36:49 -0700	[thread overview]
Message-ID: <20261029233649.8f3b46bfc2b1f50b2db70708@linux-foundation.org> (raw)
In-Reply-To: <20261014034143.551624-1-szwyb123@gmail.com>

On Wed, 14 Oct 2026 11:41:43 +0800 Wang Yibo <szwyb123@gmail.com> wrote:

> Move lib/test_memcat_p.c to lib/tests/memcat_p_kunit.c and convert it to
> use KUnit.
> 
> This change switches the ad-hoc test code to standard KUnit test cases.
> The test data remains the same, but the verification logic is updated to
> use KUNIT_EXPECT_* macros.  All allocations are made test managed, so the
> manual error unwinding paths and the empty module exit hook are no longer
> needed, and a failure now reports which element mismatched instead of a
> single pr_err() message.
> 
> CONFIG_TEST_MEMCAT_P keeps its name so that the defconfigs enabling it
> stay valid; it now depends on KUNIT and defaults to KUNIT_ALL_TESTS, like
> the other lib KUnit tests.  Those defconfigs already select KUNIT and
> KUNIT_ALL_TESTS, so they keep turning the test on unchanged.

Thanks.  AI review asked a couple of questions:
	https://sashiko.dev/#/patchset/20261014034143.551624-1-szwyb123@gmail.com

      reply	other threads:[~2026-10-30  6:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14  3:41 Wang Yibo
2026-10-30  6:36 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261029233649.8f3b46bfc2b1f50b2db70708@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=david@davidgow.net \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=szwyb123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®