From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793353157; b=BJpRELsK6GT6opj2Phft/52aEFPZ1LNI3lAIrJdhfIV84k32FZ+kGeotALNhrrkCU5Cv mtyZvLNsiXl7CopoZO2qWnatBVaWKgJ+9d9IH6l4kkJMOf7OBMwZqQZ1ZqSoDabdi2de4 /QYDA3S08xxBuIvRGyVl1xPigZ1HZO02f5pJluyJbl2XS3AXgQwt54GWEYXlphFeJpnBc DodfP5ojNnRtvY6L7OrxNKdnMmnvsCEQmN94rmREFmzRCkygZMvOwDu2kftAh8ZYUtu2q JCYbxwMJN1bfOGiY9JqEuOlIBrTKal+IVhhrU76Em9Mz/eizUv/+b/hcH81DZgqLVjQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793353157; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From:Date: Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:X-B4-Tracking:X-Change-ID:To:Cc:X-Mailer: X-Authority-Analysis:X-Proofpoint-ORIG-GUID:X-Proofpoint-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Spam-Info: X-Proofpoint-Virus-Version:X-Proofpoint-Spam-Details; bh=wat7q1UYgkEGaTTWcudFAFVB2otd83omGVIbYCT/JIc=; b=YJeyd6rpFZUF3rzUbo2mnvdERJyAsd8F3DwMiT8dmNhVi9CEPIolkBvZ6KSonMeWdx3Y RypcCTgd05C1hVIeJk3UJs3oEjfkVmlAkZhgtGwRFeyHEOBsp+yBXHN4j2Da9D+Z3rym0 Ip6ACQmTy9gTaJnRhY0edM+WWvsZapnerOer8mzV8dECltQayX1Zjga88dZpvHBFMV7er nsfSmTcXh3boEl8sBMATaRiCMQClKycnNKyhWURfyuyjPquG/2Xlm8uTeVl99fj6CDOet Gh07MjBro8TGfZT+znWNBr+U+TZX5J+7VwEjfaEgsQzNu/RDNsUnt5aEyN2XIpLpl0A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=fKM6Hf+O; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=UmW2QZu+; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7E66606A322 for ; Fri, 30 Oct 2026 09:39:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B7E66606A322 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=fKM6Hf+O; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=UmW2QZu+ Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69U8F9ww2374149 for ; Fri, 30 Oct 2026 09:39:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=wat7q1UYgkEGaTTWcudFAF VB2otd83omGVIbYCT/JIc=; b=fKM6Hf+O6j/LL7fINVr8cE27HKhBmPwBZkM6MN bAPoK/O5oGkwoWwmMNRSZJpfk0wlCptMMIkTooPDqcaO6iFqTMXfel4KZAdjBuHA qqeR2voCdJN4i1zIJ28QdCI8m6k1/4Dach9cl9Y9BayIJtCgK2u6MHZQIQgwjstj 0yfKIxaVpGZEhZB0FvvKxx//yUU93H1yRU5OZ3+RJA3kB4lLG2P4qZq4inq2+wFv 9Q3XoLP3Jim0cnTqG22whZl+EB7KnjDsWa6taPjFExPkL4POFwUL4bhqhPQ39UEx dSzazljrBUxwCrSMFx+/eM26NFTCsbsCM8DzaXtEf1fj01dA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hme6qj941-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Oct 2026 09:39:15 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93caf7856ffso94582885a.3 for ; Fri, 30 Oct 2026 02:39:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793353155; x=1793957955; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=wat7q1UYgkEGaTTWcudFAFVB2otd83omGVIbYCT/JIc=; b=UmW2QZu+Tyl6X1wK5EhC0O4uWFl8CE32UoGXlszMEkMhIln7MDKviUtx3g8QamJlrG qSC81a7dSEWNgCuOA2LYtjzMHcyJPhejo/6XZ3ug96Lubj+hIU5ghlQMNa3ea7aT8tby j0Fn1picg+ZXmm5ZWXCfA6jic6mVXBdFR2X+EPFKXuPdZetDPAdTcKdMMOWgY0qMf6o+ 85PB/m2peI7WwGum7jVHWqIUKYMFzh9ubvKFqJ0A9l73bPkA6uqhy6naxGFYp3cTqzUk 68HPiZJkcn0mLCqNA0oJWWKrfJDY+UGSn9flmFKkz4SiOZ+4pJRnrQtSQ/LrCjQ1sYYU Vhpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793353155; x=1793957955; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=wat7q1UYgkEGaTTWcudFAFVB2otd83omGVIbYCT/JIc=; b=hX3W7BEUIVIOApcUUJ6zqRhNXKEszVou42sS6LnFvXwL756mZQ7VU93L58Wy/wXdmI JGRojrbBW7jlJhO5IrKv+Hmq9Fr5QyyJ5rxXjZh3VtO1QbEH0Kq/Yu56eA/8Dss/VZF/ rXLQ32d0puuwvR9wbZcmhi9TCzVzoi9SN8svkRx4LtIAkvAceVTnDaHzhhxBHiFzeyMX OvL2q7W1NrVUHBepKnYi7AUzblTA6wv3qRttOEII1CBqCwJrvfGy01ah0iQs4CaD6tpc mDdAwpMhvBbMufDJgAHH2X6lmPbF29/3JRD0upAZUy3ggbqQtUnYZ//e6qN7lOmMjA5t qoEA== X-Forwarded-Encrypted: i=1; AKwUvBz/BJDRsgzuJ9fUeoYLkVjc5ziydQc/+zVfFJe3OnyETvRG45i1uwyFeq2HHcQz+liu94ImPjgibAbUazY=@vger.kernel.org X-Gm-Message-State: AFq9FYIH2oBaOIMxBym/Rzy/MAA6pO7E1VWn+tEVRAYJcEYOEEGzt+St HiZHllYIJciHKmfJjs4LzefCqvL1EWjegkZjj8ONUmRlWVGZTpltNv8Px+01Fj8KoPNwLbyDi7A xHty7qDbpG6tNffAmqkEMyu0yHd3EXLhwhiH3OKd4LDatUM5afgGxyY15myEnjzncJWQe4N8upR KH8Q== X-Gm-Gg: AYBFou0owJWZUEq4YbuQ+uc9PrXbKDwJ4P4lwzDKe3c5TXE0yOKqgC7TJL79M+bhY0h Tc73ZrmtrAq6CZaMTatwOkns4me50q0cAMP0fXx9BNMYyom067+l5YTLDTCEsE/l6EzD40lb1VF XGc1dKNA5o+a4aAUyBIDu6fM5r9EhREU95nJH8/ab3L3X+wVKuaQ0wqfPholJmO4LaEfFKjmska n2UXfMzQ/HFQPGoOK8O1suP3eOl4SfcCa2Vd2+oHSPdqX2O3tHF+ZvLz0CUvdmOlee6RjHluNK5 3yhv0UjBzmCmC8yVVkNvhLL9KlyfqqBDEWYy2NPq0d4MxrEvyQPNLnAbbzxWy7nrbHLgUa9qODW eLW1WxTfk0KeIeaJplW2zgXmUaZxtA8TyhoNR3nnKQ+p/YvH/8bkBveNMlrNnIcazvd4/oGYHuQ VQVEu5XEC7DLqtQTBpyIxmlyAxYZAiCWXBfa8tfJLi5DHITNnFRchVD1xxjxCBoI08V2rYd+IVr ZePHb/+wdrRP819fiAAOYFruYFY X-Received: by 2002:a05:620a:6603:b0:93f:25c7:a4e1 with SMTP id af79cd13be357-94421744ef3mr263254485a.26.1793353154689; Fri, 30 Oct 2026 02:39:14 -0700 (PDT) X-Received: by 2002:a05:620a:6603:b0:93f:25c7:a4e1 with SMTP id af79cd13be357-94421744ef3mr263249785a.26.1793353154159; Fri, 30 Oct 2026 02:39:14 -0700 (PDT) Received: from QCOM-eG0v1AUPpu.na.qualcomm.com ([2a01:e0a:830:450:9d77:8e43:b62f:d85d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4aa813d295csm126785025e9.7.2026.10.30.02.39.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2026 02:39:13 -0700 (PDT) From: Loic Poulain Date: Fri, 30 Oct 2026 10:39:11 +0100 Subject: [PATCH] media: qcom: camss: vfe: Clear active buffer pointers after flushing X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261030-camss-fix-v1-1-ecc170342d0d@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAL5l5GoC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzNDA2MD3eTE3OJi3bTMCl0TS3MjM0vz1DRLg1QloPqColSgMNis6NjaWgD dsvDnWwAAAA== X-Change-ID: 20261030-camss-fix-4972697ef90e To: Bjorn Andersson , Konrad Dybcio , Abel Vesa , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Todor Tomov , Hans Verkuil Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Sashiko , Loic Poulain X-Mailer: b4 0.14.2 X-Authority-Analysis: v=2.4 cv=KsrYSmWN c=1 sm=1 tr=0 ts=6ae465c3 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=c92rfblmAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=SZjMrJynLI06Tb3JO1YA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=GvGzcOZaWPEFPQC_NcjD:22 X-Proofpoint-ORIG-GUID: DNdnqJixmprtzHjevwbgYrKqzrhU45Ks X-Proofpoint-GUID: DNdnqJixmprtzHjevwbgYrKqzrhU45Ks X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDMwMDAzOCBTYWx0ZWRfX52AYKgSzZAIe 4vTNoAc1O/tM0k0HZr+W6TJI8MSXkYxUM6syVsxTxOyAhR8aDTnDiuhBkS1fMQpiQ2kERvrkLqu yfX54ry3lTlm5Ps0jyuHRIYusDkZfD4tNwcu9js0SEhtPep5peyuIWp612mbMGIXS4xxR5Ei2My IkSm+kBEKPifIzbKo0bajLyaSmIswF/+MK3JuZ1GnrB5qZoJsO+9dP5P5ICsdBqTXuxI6ghae/I AWnOdcDekQM4QaEOtYHbGskZlUItSnj2q0bOHoBL00/hYwFj4EKaxIhrnBEFssWcwptkmZWHj58 FvYmv/ZNhw7ZjIQKa3YW4V630Jxgme++m/26V9u+FXYXXRJsBrJpqellig+7O6XHZkfBRscDg3g /ZBSSIa2ksTqu6XFjVtHE0UxzyJn0CfjC7oEWgz6LaeKl8N/bsTgfhHvrOo76krfmjKr+OIqJwx E7cNzj+MXE6+298moMQ== X-Proofpoint-Spam-Info: AW1haW4tMjYxMDMwMDAzOCBTYWx0ZWRfX2zsrX0DaPExM 1NTfSHcWCV9SiXcMdjsjsFSKqmvYIf3mFLWfzN+8ygMkIAEwfkMk73MmKrvpnJ+92J4p5FQqnm0 H9//inKy9YKhCHcHIY4H/AlWeDT2YV8= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-30_03,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610300038 vfe_flush_buffers() returns all active buffers to vb2 but it leaves output->buf[0] and output->buf[1] pointing to the completed buffers despite the lost of ownership. This can lead to subsequent flush or completion paths operating on stale state and potentially completing the same buffer more than once. Clear the buffer pointers explicitly. Note: vfe_enable_output_v2 is supposed to overwrite those pointers with pending buffers when streaming is restarted, but nothing guarantees that enough pending buffers will be available to overwrite all entries. Reported-by: Sashiko Closes: https://sashiko.dev/#/bug/linux-e617a776-3d96-47cb-8d60-a769340c25a7 Signed-off-by: Loic Poulain Fixes: 4c98a5f57f90 ("media: camss: Add VFE files") --- arch/arm64/boot/dts/qcom/monaco-pmics.dtsi | 2 ++ drivers/media/platform/qcom/camss/camss-vfe.c | 8 ++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi b/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi index 361f5163b6d91eef794d3bf86b374d4dcbc6d60f..1ed4de00b1a3e23e1ef0f1c412a2e29bf840c870 100644 --- a/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi +++ b/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi @@ -58,6 +58,7 @@ pmm8620au_0_adc: adc@8000 { #address-cells = <1>; #size-cells = <0>; #io-channel-cells = <1>; + #thermal-sensor-cells = <1>; channel@3 { reg = ; @@ -112,6 +113,7 @@ pmm8650au_1_adc: adc@8000 { #address-cells = <1>; #size-cells = <0>; #io-channel-cells = <1>; + #thermal-sensor-cells = <1>; channel@203 { reg = ; diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c index 2680a9914765fa2c8f3c2b38a5f4f0e0bcf4d873..8e297e2bcafcbf30b09fc2ad6e57f484a4e41898 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe.c +++ b/drivers/media/platform/qcom/camss/camss-vfe.c @@ -1187,11 +1187,15 @@ int vfe_flush_buffers(struct camss_video *vid, vfe_buf_flush_pending(output, state); - if (output->buf[0]) + if (output->buf[0]) { vb2_buffer_done(&output->buf[0]->vb.vb2_buf, state); + output->buf[0] = NULL; + } - if (output->buf[1]) + if (output->buf[1]) { vb2_buffer_done(&output->buf[1]->vb.vb2_buf, state); + output->buf[1] = NULL; + } if (output->last_buffer) { vb2_buffer_done(&output->last_buffer->vb.vb2_buf, state); --- base-commit: f1ac44c32cba88ad65dcecd4a279661d14e93651 change-id: 20261030-camss-fix-4972697ef90e Best regards, -- Loic Poulain