From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793380206; b=n+aK+nxvDQWhqB7G2EIlULLZrpmbeW6qZJKakLcHxNEmhq8e0paYGC+Uk9dCgbW+cr33 lrSqgSMJjMos+qV29b266wjH86khXvLnmaUMhdF2ALPRYefmav8Ec1TLOoc8cMwsJvFZT B4RZWjbPbohfiEFcucRbQVAuA9oKHAyCpMBY62JWdWUdY8adrjxn8lcjgJL5vTGiFkooI AHyou9bzg4S28QzLK/pUsRE/i/DzG03gQjsN8wjTifQvWeaDolZX7jtXD/eDx3nkPhiKT TTaDzvKOPCtKZf80OdHzasGN+fhZqR2IWVI438Q+Yc8eA+fUxpq+D+hY8ob9csC6hzA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793380206; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From:Date: Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key:X-Proofpoint-ORIG-GUID: X-Proofpoint-Spam-Info:X-Authority-Analysis:X-Proofpoint-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=EOWyfjg320LsKD74ASlFLIJyIS4lGcmnKVpPXhAJO90=; b=pfHX4xZ9S4jYOqHqHweVS3FPFMp2wjPORcNmRKoGRWM9yqqpjLnvLENR+U5nEHBoM7ax iBLs+BTvnmBmDIA5T+BDc/c/8kvzbhthVfg4o+pXXLsNbVetdPUFucv3aV7WhLbQSqjax /UxyddDnXeIg+b7lMLTT2vrULJbMmaJ0NCO4BZiWI2nN3Fk5g+tOnrV549rIMoKkBdrYV h9F5XzFSuOQbWtl9smWGTjqC/8SGpL0tBF15xmiSi2+np8K4gogeTgZkfme9gbHJjNspI 6NakXg3Hop/LtscZeEV6uuqYObrkg4yndBKzBHS5APXta7AA7JsUxCDmChRy+2J3Lug== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=temperror header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=JfLf0274; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=QonYggbX; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 271A8606A323 for ; Fri, 30 Oct 2026 17:10:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 271A8606A323 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=temperror header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=JfLf0274; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=QonYggbX Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69UER7523552197 for ; Fri, 30 Oct 2026 17:10:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EOWyfjg320LsKD74ASlFLIJyIS4lGcmnKVpPXhAJO90=; b=JfLf0274sJkJhp0e MpthktA3hCXfL601o8AhP8utAJxsqLWLvT8cAbJ8UCxw49uft/r5x3p0nITHHemH uoYZiw6PnBzU0j9uT/yR0ktYe9/NnU4Yjmlnuy5YrzeX6txG9hfAhLskFAvWC+5+ h8pttzgL34wtBJ0npBcG7N2f0AO63ONo0aLMo4F8zz5vZtxla49hOyk5MD01wcpU 70D7wuGIvhKf2ov2A1iBILuBelpVqmz3yKZiB+15MRnloMxP/9uz7VjHPlMdplj1 j/qTl4UoNgd+n7zOuZkZkJyoIZor0VBzKrAJzH4wzsRxkSTWrXgHWXFNkMqpUqoy mbfboQ== Received: from mail-dl1-f70.google.com (mail-dl1-f70.google.com [74.125.82.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hme6qm2xx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Oct 2026 17:10:03 +0000 (GMT) Received: by mail-dl1-f70.google.com with SMTP id a92af1059eb24-189d17eca17so752933c88.1 for ; Fri, 30 Oct 2026 10:10:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793380203; x=1793985003; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EOWyfjg320LsKD74ASlFLIJyIS4lGcmnKVpPXhAJO90=; b=QonYggbXIzlEfMfL2BQlubh5T/fFr6MyrVpXfEMK2xcusRgmsNC7nrv9dub0VBabl6 wTM7oGZQR1PRgSM/gnF+qF4p1Br1Gp472918ZRFRbtmrkiKLciL8fvzpAXNuvJKsvXCc rNfd42jZU+q4lyoX967h035j4bPr6+mNhYQR848zP+7BytByTapdhpdv0sTCYkpqFD1H GOvlnOe02F3ez9ISzENXWJA1oipYl6qYuGMOR34mu1XOcxU+yBFuxetzvFQVXzKpfat2 VxI4tdHKvri1QnSnXTCxiNsMVnLY3WYD1zepmrko36LCTVDrlxfHz8eDt3haiglo5veB OHbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793380203; x=1793985003; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EOWyfjg320LsKD74ASlFLIJyIS4lGcmnKVpPXhAJO90=; b=anfi0Z3P8Y09dGxxdoBwuzE3T0slW7lLnbhx/WcwobI4mKCZDvTURu8uNXBklSgq8M qN6iaFbbRZkC1nNijIpJ5gW7NgOKODQ6l0drSQ+Q3EnkRcI+DPdkig+EuyrgEuLqrXIm ScdVsdCUbfrb2d2FJrVVfGPaI8exNXlYDCzDWS2TLoKb9dpvAxRIbG8Y13iFGsSI8QLf eiS3Bm7xzj034p//RKS0GgXIcrhJq4W9X0Dz7ZLNG/HRsvY3gHTPRPfPSbJwDyyhi6AX VlxDP4jcbkoIMmEKWlYiQpDKJVWo0yYLzSSCUjY5R1i3CPniVnLTIru6FyEtD/Ekq4iG Xx4Q== X-Forwarded-Encrypted: i=1; AKwUvBwa1JblqFwoV3GeFkcPPL2EYrqZfhE3/MewH9wHm4stC1/x1h84ZzxfhZNnkUWwzgYpU7TMHPPXhhyEIIk=@vger.kernel.org X-Gm-Message-State: AFq9FYJk6jnxe3VGzBd/so6LMAlbYlSetv0qttTuFvZjWV3kTKLZU5h0 NrKITIUJW/GHk7ct9J+vE7xvTpnFmZ3wpb1bXh2Da6FwJszXxDiK+LVrOgs3XpJNKwCoqpAfi35 pq7KQWW2+2UZrtvb8vSBuxNvfqGtATHcVo5FdEN8STVG5R+ApdkaMv8cQ/aEgXUvjbXU= X-Gm-Gg: AYBFou3kEYzWz/AYLaWeGixUgzyHSt8Dhn+vLodeIYVVrv9X6YK0rCb93R6L2WSE8yM JkPkZ9L/lvUQf60tqSRQiXgZSTgY9uPkmYSqa/OKgMJGegDQMEcuYAF6lcwsl/R46ac5drj0g2V hJcN6q+78ZX1cnSDRvzPBAERBvH3soR/E1gJU9ZAmv5dB8h9THrLcf2Qrf3dkjKiOA9XsEAwzpP loz0oibOQ58DGmkOHlonac/7HskY5AClxkwGTviUCBkCcEzK2GYQBhWDTiY0ntpEAv8B/d88QKT zDsi22UHSbWIVVqdS2yjl5aYPMuFUhKBXjiy9/laacmzOiyQI3yIkRsNJpQ7lTJhxxzI4VbVCIw 9m1YcB9WVhdlIMOOfbBH8P3DHPuprDCGtnlhx3SyAlBXiDNZrUD39uiprgK39pb1Zc56U5wB0Mw == X-Received: by 2002:a05:7022:3f0d:b0:18a:8164:ce4 with SMTP id a92af1059eb24-1ac4fb0c60amr4017415c88.0.1793380202670; Fri, 30 Oct 2026 10:10:02 -0700 (PDT) X-Received: by 2002:a05:7022:3f0d:b0:18a:8164:ce4 with SMTP id a92af1059eb24-1ac4fb0c60amr4017380c88.0.1793380202065; Fri, 30 Oct 2026 10:10:02 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1ac194b5437sm9481168c88.13.2026.10.30.10.09.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2026 10:10:01 -0700 (PDT) From: Akhil P Oommen Date: Fri, 30 Oct 2026 22:39:25 +0530 Subject: [PATCH v2 4/8] drm/msm/adreno: Simplify adreno_probe() X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261030-gmu-sync-state-fix-v2-4-89d3082d97af@oss.qualcomm.com> References: <20261030-gmu-sync-state-fix-v2-0-89d3082d97af@oss.qualcomm.com> In-Reply-To: <20261030-gmu-sync-state-fix-v2-0-89d3082d97af@oss.qualcomm.com> To: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Neil Armstrong , Ulf Hansson Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akisaira , Vladyslav Tymoshchuk , Val Packett , Dmitry Baryshkov , Akhil P Oommen X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1793380168; l=1922; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=4IwBjgmZtlASF3bKahjtC27XmmmLfOr5jE0Tf4p3+0I=; b=31I4AziRK5+9Pqar0RIswLtFl79uUaePJYhCKxMRgXVX1k0FJpRaM+TKifUzVhcEok2rF8Hgl uGnViKYuy9zANDEc5IhfAhhJiKWOlXyNh99TCwEKNRodCkO8rXfN/Yv X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-ORIG-GUID: LyCZDTxyy6ro7Q-czzo5V0EKXYrOfXzM X-Proofpoint-Spam-Info: AW1haW4tMjYxMDMwMDA2OCBTYWx0ZWRfX/cBHDvlwCFKj k3d3IUiLQ3yXsYQYHzOUdsokLT31kNhwY2G5+dZwQfhjwwlj/hLOQapdh/8eBEFT20Bl2lztIsf d069ksCPRx+0Z9FGD7fM9cQGvCDyGHA= X-Authority-Analysis: v=2.4 cv=DfSCOftW c=1 sm=1 tr=0 ts=6ae4cf6b cx=c_pps a=SvEPeNj+VMjHSW//kvnxuw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=7EupJXidagRHOzv49WEA:9 a=QEXdDO2ut3YA:10 a=Kq8ClHjjuc5pcCNDwlU0:22 X-Proofpoint-GUID: LyCZDTxyy6ro7Q-czzo5V0EKXYrOfXzM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDMwMDA2OCBTYWx0ZWRfX/XyjRy3KUzOy JX3+RkAOrXGtgZi2p1hjsw9Bpeue+aRc3DtPn5R1krvLUbLKe+z/fmAFSszUm9DiJJGzZedzBbg ZOgTwblMAVLdDprTuKEPPF15RTXJ2hyutiEttLWa2Aax+35ywA8esuroFE10X/QTShFenYJihk1 UIKd5t2FMKG6F7yJv5UKVCbcLVMBSvQPaZB1NSckcaUOCwSOwzypvQildfLJ8gqpKM/BKIDDfNX Du9fgyc1KY/oGPRBRTpKRJnTZjqcAo4o7bnH3QalpzHfVFYvoiBCqbJxn9og+OxApbKZ7QLDw/Y HPcfkden835qzFPkMTYouxekmPYoZsTqtIl7rnz9azBwZR5IU8uxBub0l2lqtSHtlws2SQqBFaT y4sXakBJuucbl3obzOmnbK5cc6pSb1RYC0kdLPttup4waSUGou3kaenFlUAPKGPKrzssDcFuqKE MUwqAnxbGyWCHVXEvug== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-30_05,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 adultscore=0 priorityscore=1501 spamscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610300068 Now that it is possible to auto detect and create separate drm device for a "GPU + no display" case, drop the special check for "amd,imageon" compatible string in adreno_probe(). Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/adreno_device.c | 8 ++++---- drivers/gpu/drm/msm/msm_drv.c | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index cdf26b38b904..34718adefbfd 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -271,12 +271,12 @@ static const struct component_ops a3xx_ops = { static int adreno_probe(struct platform_device *pdev) { - struct device_node *node = pdev->dev.of_node; - - if (of_device_is_compatible(node, "amd,imageon") || - (msm_separate_gpu_kms_components() && adreno_has_gpu(node))) + if (msm_separate_gpu_kms_components()) return msm_gpu_probe(pdev, &a3xx_ops); + if (!adreno_has_gpu(pdev->dev.of_node)) + return -ENODEV; + return component_add(&pdev->dev, &a3xx_ops); } diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index e25ef578d2b3..e0c0f1248d1b 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -115,11 +115,11 @@ static bool msm_separate_gpu_kms_auto(void) int gpus = msm_count_gpus(); int display_subsystems = msm_count_mdss() + msm_count_mdp4(); - if (gpus <= 0 || display_subsystems <= 0) + /* Single card if there is exactly one GPU and one display subsystem */ + if (gpus == 1 && display_subsystems == 1) return false; - /* Single card if there is exactly one GPU and one display subsystem */ - return gpus > 1 || display_subsystems > 1; + return true; } bool msm_separate_gpu_kms_components(void) -- 2.55.0