From: Christian Brauner <brauner@kernel.org>
To: Edvard Conrad <edvard@tuta.io>, Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3] fs: let backing files inherit FMODE_NONOTIFY from the user file
Date: Fri, 30 Oct 2026 15:57:49 +0100 [thread overview]
Message-ID: <20261030-welpen-anbinden-nullen-b2432cee1d10@brauner> (raw)
In-Reply-To: <P58Wrer--F-9@tuta.io>
On Thu, Oct 29, 2026 at 10:18:40PM +0100, Edvard Conrad wrote:
> Make a backing file inherit FMODE_NONOTIFY when the user file it is
> opened for must not generate events. This restores the pre-6.14
> behaviour for the fds that fanotify creates (and for any other
> FMODE_NONOTIFY file), while ordinary opens through a stacked filesystem
> keep generating events on the real path, as intended by bc2473c90fca.
Looks good to me. I'll take this via vfs.fixes and fix up the subject to
use the "backing-file:" prefix while applying.
Amir, note that the same deadlock is still there for directories.
ovl_dir_open_realfile() goes through ovl_path_open() -> dentry_open()
and not through backing_file_open(). So a FAN_OPEN_PERM|FAN_ONDIR
listener that opens an overlay directory through the fd fanotify handed
it wedges the same way. That needs to be fixed on the overlayfs side.
next prev parent reply other threads:[~2026-10-30 14:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 21:18 Edvard Conrad
2026-10-30 9:26 ` Amir Goldstein
2026-10-30 14:57 ` Christian Brauner [this message]
2026-10-30 17:13 ` Amir Goldstein
2026-11-02 10:57 ` Edvard Conrad
2026-11-02 12:34 ` Amir Goldstein
2026-10-30 14:58 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261030-welpen-anbinden-nullen-b2432cee1d10@brauner \
--to=brauner@kernel.org \
--cc=amir73il@gmail.com \
--cc=edvard@tuta.io \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®