From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.200 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793342567; b=o8myIUYHKwypNSAFn8p0HrQxY9BNaUzbTCrNF/n7KLU84EiTNRHyI/Y0xFJ9+7kXYp2p GC518Wpv0qipPU4Navwcr04QRM09Tf7TEwKu5ffyjZXUMV9Dac8PX1EBvpIkCOsewJIls yganTKHjRjuzwLiSlZ+dp+0B+v/KFOhtRPek9q8xccI+Oy4rHuYp+P4VTsNXTdUDEasWb QKFDP/PAvixTbs28dmW3mVWhthR9/MbZSSOPsXfKdN6w/dcoLI7lMwIV640AMgnszutdZ Tg2c7i4HJy7Q/it1DH625nwRBbZiAxCqCt2zOHpxTPmBw/NdP9Yv2+t1M5/GCc5yB8Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793342567; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type:Content-Transfer-Encoding; bh=yaHRCTRFiHcMC3zscSmooVqj/PwhaSMo17fIfMvXXa0=; b=FVHz2A6UngBcV1lztzd+pIS+xNQ1yUt5TnQ8YXe0303Qf7gDV1+Qi6GysQvznQH6WKSH Rk9KVpTfC8ZwNmR/WI8xPGNcQpIRq72o8tdgvnxFYBX2EqfR8eKSlLrmhuXP54KeqHkzH KCUfF8S0awWWEkPIBjBYubqxu71jv/M+G0s4EvhayY7g0N6J87aNt2caSNmBOJhKq1Lv7 WqLbe6d+uY6KZUHITQv6QfY6115UpWNIa78u4KMk1EH90d5eXyiKqvUDd61PHxPMxTum3 qFRr1mpw7T12YAn1omLvzvKqdbyiHJMnj5lf2gQB8ZJhxrbMrVAcRWa1rXVBD8muN9w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=Vl0KSw8Z; arc=none smtp.remote-ip=74.125.82.200 Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A2E0606A31C for ; Fri, 30 Oct 2026 06:42:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 7A2E0606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=Vl0KSw8Z Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-33c35f5ca6cso1125431eec.1 for ; Thu, 29 Oct 2026 23:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793342566; x=1793947366; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=yaHRCTRFiHcMC3zscSmooVqj/PwhaSMo17fIfMvXXa0=; b=Vl0KSw8ZV6QKNH9FGUFa5jggHziOsVVyb6CQsA8DGb/aKzfpQaD6JJo/z2L/kJLOa3 sT69waWLqJGBnEQNef7aoOp+IgbHSVC1FfNb1+HlC1jUKfN7G4fG0Tbt3le1cAQE5UuY DQORJgUdG3B2DJJ4d+3Hp0SiiYXb0QWYyi+jDYwqjGI9U6BncFfwRAlnfewS3hcidCiu 3QTrwSDSDWElYL7yntLpHISmxXtQnmGpg665s30fqakV4hd0ccLT8AbOBA28fLgw9Y2E YoCtwgESkAAriclTSCfLwWxaBKhJO3hwn2STO2TtmO2vMCjORi871HY0ZnQWn/lc+2CG /RSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793342566; x=1793947366; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=yaHRCTRFiHcMC3zscSmooVqj/PwhaSMo17fIfMvXXa0=; b=CMuqjQ5ELqLFCGFltHKSvu3iSe2yZsNnPsHABYHOldArPnI7XoeckG75UzsobtuSQr xQP6lLfQ4li1CY7v5+hOzE+1tef+g6aCg7IHjRJW6ZtCIQ0kRVshsE8qTWm9V+viwKV7 Ky7mXPu5zl7ANv8T8jcDZ19pEcDbzh9kElbXjwbEeDjUCu8FIGd/BG0yGzKA+iv2LcB5 BMHt11FXb7lgesGmmGCS2RjZw89bGSJqccTdaMKxwhBlgD7MhrrIzpt69FgtGI4AEruP Ig+cftieFkKF0Tzytz+1206NLzTcuoCGSBazlgjhSYZSbLbkqfY2y6QgokYfj5cz5lnA O/1w== X-Forwarded-Encrypted: i=1; AKwUvBxt/JQ3IoO7Ds3gNNXPGjDNB/ntcNEroB+Fpkphx6zlVSoArYLsyzdh4eZsuzlcx7z4cDxWTogsKmU/pUA=@vger.kernel.org X-Gm-Message-State: AFq9FYIhcuw83IqNa+zF7vP5Mu8AhPr5SALX2bBLTen7J4IrUkGBbnq8 QS6wnvxIZQnFBGSB6j6bHhcPAwO9Y7kTpxXHsCwmlLGDoQp5pxV+RlKdqXhtWxePYqX6jIyWSZ7 l8pYYb4NVgDhwUmEDy2Iywq3I3w== X-Received: from dyblz5.prod.google.com ([2002:a05:7301:1605:b0:36a:120e:b9a]) (user=almasrymina job=prod-delivery.src-stubby-dispatcher) by 2002:a05:693c:4154:10b0:369:f4d7:19fc with SMTP id 5a478bee46e88-36a424988abmr2675719eec.41.1793342566121; Thu, 29 Oct 2026 23:42:46 -0700 (PDT) Date: Fri, 30 Oct 2026 06:42:45 +0000 In-Reply-To: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261030001444.289973-1-omermetekaya0@gmail.com> X-Mailer: git-send-email 2.56.0.385.gac671c819a-goog Message-ID: <20261030064245.4118081-1-almasrymina@google.com> Subject: Re: [PATCH net-next v2] netdevsim: reject port addition and clean up ports after a failed reload From: Mina Almasry To: Hangbin Liu , "=?UTF-8?Q?=C3=96mer_Mete_Kaya?=" Cc: Mina Almasry , Jakub Kicinski , Andrew Lunn , "David S . Miller" , Joas Antonio dos Santos , Eric Dumazet , Paolo Abeni , Jiri Pirko , syzbot+88435e204734072bf39a@syzkaller.appspotmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 30, 2026 at 2:05=E2=80=AFAM Hangbin Liu = wrote: > > Looks Joas has a same issue fix with yours a few hour earlier. > > https://lore.kernel.org/netdev/179324296598.34505.11070163314749859668@gm= ail.com/ > > > --- > > Tested with syzbot C reproducer. > > v2: drop Cc:stable and target net-next. ... > But yours have an extra guard in nsim_drv_port_add... > > Leave this to Jakub decide... I prefer =C3=96mer's version. Once reload_down has torn down the device and reload_up has failed, the device is in an uninitialized state, so rejecting new_port in nsim_drv_port_add() makes more sense than allowing ports/netdevs to be registered on a half-torn-down nsim_dev and only cleaning them up later. --=20 Thanks, Mina