From: chitranshmandhaniya@gmail.com
To: hansg@kernel.org, ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Chitransh_Mandhaniya@dell.com,
srinivas.pandruvada@linux.intel.com, david.e.box@linux.intel.com,
irenic.rajneesh@gmail.com, qipeng.zha@intel.com
Subject: [PATCH 4/8] platform/x86: crystal_cove_charger: switch to devm_mutex_init()
Date: Fri, 30 Oct 2026 13:52:58 +0530 [thread overview]
Message-ID: <20261030082303.284271-5-chitranshmandhaniya@gmail.com> (raw)
In-Reply-To: <20261030082303.284271-1-chitranshmandhaniya@gmail.com>
From: Chitransh Mandhaniya <Chitransh_Mandhaniya@dell.com>
Replace mutex_init() with devm_mutex_init() so the mutex is
automatically destroyed on driver removal via devres. The driver was
missing a mutex_destroy() call on the teardown path.
Signed-off-by: Chitransh Mandhaniya <Chitransh_Mandhaniya@dell.com>
---
drivers/platform/x86/intel/crystal_cove_charger.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel/crystal_cove_charger.c b/drivers/platform/x86/intel/crystal_cove_charger.c
index 425c7eb32442..8ecfec2c8369 100644
--- a/drivers/platform/x86/intel/crystal_cove_charger.c
+++ b/drivers/platform/x86/intel/crystal_cove_charger.c
@@ -94,7 +94,9 @@ static int crystal_cove_charger_probe(struct platform_device *pdev)
return -ENOMEM;
charger->regmap = pmic->regmap;
- mutex_init(&charger->buslock);
+ ret = devm_mutex_init(&pdev->dev, &charger->buslock);
+ if (ret)
+ return ret;
charger->irq = platform_get_irq(pdev, 0);
if (charger->irq < 0)
--
2.43.0
next prev parent reply other threads:[~2026-10-30 8:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 8:22 [PATCH 0/8] platform/x86: intel: switch remaining mutex_init() " chitranshmandhaniya
2026-10-30 8:22 ` [PATCH 1/8] platform/x86: isst_if_mmio: switch " chitranshmandhaniya
2026-10-30 8:22 ` [PATCH 2/8] platform/x86: isst_if_mbox_pci: " chitranshmandhaniya
2026-10-30 8:22 ` [PATCH 3/8] platform/x86: pmt_crashlog: " chitranshmandhaniya
2026-10-30 8:22 ` chitranshmandhaniya [this message]
2026-10-30 8:22 ` [PATCH 5/8] platform/x86: telemetry/pltdrv: " chitranshmandhaniya
2026-10-30 8:23 ` [PATCH 6/8] platform/x86: ishtp_eclite: " chitranshmandhaniya
2026-10-30 8:23 ` [PATCH 7/8] platform/x86: punit_ipc: " chitranshmandhaniya
2026-10-30 8:23 ` [PATCH 8/8] platform/x86: sdsi: " chitranshmandhaniya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261030082303.284271-5-chitranshmandhaniya@gmail.com \
--to=chitranshmandhaniya@gmail.com \
--cc=Chitransh_Mandhaniya@dell.com \
--cc=david.e.box@linux.intel.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=irenic.rajneesh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®