From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.127.231.39 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793352108; b=xMwOyyljQ9SXIimLTUdo7AS1tOn+UGdhssEkld3FH2BgvkM5oCtvzArlkZxTGLenaYlM H6/70EPZa8KbHz50iHWb7MRg+knyGd5N+zcngN2gGcl45VdZCRDnGyaGsGZxHFzIvXqxH 2uzcyWVo20OcqMJIlTFIBxkWUSG5vGrc+9P0syHzvirF0qPomzCMZmpUbkf1RqgJVimCp imRLvwGMYbu1i1YEOZEB/EdHJ9RUV0n4WmehENeRq1Y+8VyEkbnyhthyibqAMO0yid+UB uI8wDTFs2KKzzEojSeAxgSA/+n+sneIlJ9UwUwC+TiXRqJgFhLJuzBmmVu9udvi5caQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793352108; h=DMARC-Filter:DKIM-Signature:X-Mailer:Content-Type:References: X-Original-From:Date:Message-Id:Mime-Version:Received:In-Reply-To: Content-Transfer-Encoding:From:Subject:X-Lms-Return-Path:To:Cc; bh=lDH6CZonHxdY1g1ae5yoOdLp2lZlZBIVpWVUaxg2sgg=; b=CC3jq3bKIylJ6EznHCz5nTW5gxgtAQxT6KCOp/fzdXbUaVYlb91Z0OjdUjssaCy1dVar UO2bNJdG+WDeuPWzA8f7mmu3aZNyOLxtDxowW4bU6D2GsBpFmbyr1iRuyqU0almEUPc8b HIeJecSLetQOzpEp5dyPxIxGiEE9LvROxscQ2lmQkyxOdmlwYz69mHoiUS/1sEDlEDxe7 0UqDfuBjTaVD9o6ghh0NGOBPlcdzejrg40CIityMB8sF7KiwP74QlKReCt5iXYkexDZn7 PrEtwPfguXZQ2QMRhvWpmsEUk72YnoM8BCKfiTruEMzmNPzy1zaUcV4e7+hKHzpc8IQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=fnnas.com; spf=pass smtp.mailfrom=fnnas.com; dkim=pass header.d=fnnas-com.20200927.dkim.feishu.cn header.i=@fnnas-com.20200927.dkim.feishu.cn header.a=rsa-sha256 header.s=s1 header.b=3I4EWibn; arc=none smtp.remote-ip=209.127.231.39 Received: from va-2-39.ptr.blmpb.com (va-2-39.ptr.blmpb.com [209.127.231.39]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A44B2606A31C for ; Fri, 30 Oct 2026 09:21:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org A44B2606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fnnas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fnnas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=fnnas-com.20200927.dkim.feishu.cn header.i=@fnnas-com.20200927.dkim.feishu.cn header.a=rsa-sha256 header.s=s1 header.b=3I4EWibn DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=s1; d=fnnas-com.20200927.dkim.feishu.cn; t=1793352101; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=lDH6CZonHxdY1g1ae5yoOdLp2lZlZBIVpWVUaxg2sgg=; b=3I4EWibnsDdyssBoESwria4Bhkgal1tNmdbWs65gdtJDBrHP2RUbxtvhFple4e6dW8BsTM YUKLgrWLg2K6xV0L7F9hhKYdQndA2Qe9HUFnaCJn6zkKIj/v42flWFchpNlrRHfivVYeJF MwKq2oVYnIjmx3NVe7547wIlTQ3yY2M71egHh6dE4uh1jfX8T3rLg+RY0TkUNxd2SDwDso DBAYKgSdFq5TB0G/kLQnpezQrVOwyMfp5aiBmJSamaEYwXspc+AXhfbI4AcutBsXSZEZ16 89lq41dhnn2oqFeYOqQB5kIa1FT2meOhAoKclra4dk75VUTbNM0NzgGMB5rX9A== X-Mailer: git-send-email 2.56.0 Content-Type: text/plain; charset=UTF-8 References: <20261030092129.1671254-1-chencheng@fnnas.com> X-Original-From: chencheng@fnnas.com Date: Fri, 30 Oct 2026 17:21:28 +0800 Message-Id: <20261030092129.1671254-2-chencheng@fnnas.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Received: from fedora ([183.34.162.132]) by smtp.feishu.cn with ESMTPS; Fri, 30 Oct 2026 17:21:38 +0800 In-Reply-To: <20261030092129.1671254-1-chencheng@fnnas.com> Content-Transfer-Encoding: 7bit From: "Chen Cheng" Subject: [PATCH 1/2] dm snapshot: split discards on chunk boundaries X-Lms-Return-Path: To: , , , , , Cc: , , From: Chen Cheng dm-snapshot did not set ti->max_discard_granularity when it allows discards, so a discard could reach the target unaligned, or spanning several chunks. Set the flag, so dm splits discards on chunk boundaries. Fixes: 2e6023850e17 ("dm snapshot: add optional discard support features") Cc: stable@vger.kernel.org Signed-off-by: Chen Cheng --- drivers/md/dm-snap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c index 31676ee05514..e49427bdbeef 100644 --- a/drivers/md/dm-snap.c +++ b/drivers/md/dm-snap.c @@ -1356,12 +1356,14 @@ static int snapshot_ctr(struct dm_target *ti, unsigned int argc, char **argv) spin_lock_init(&s->tracked_chunk_lock); ti->private = s; ti->num_flush_bios = num_flush_bios; - if (s->discard_zeroes_cow) + if (s->discard_zeroes_cow) { ti->num_discard_bios = (s->discard_passdown_origin ? 2 : 1); + ti->max_discard_granularity = true; + } ti->per_io_data_size = sizeof(struct dm_snap_tracked_chunk); /* Add snapshot to the list of snapshots for this origin */ /* Exceptions aren't triggered till snapshot_resume() is called */ r = register_snapshot(s); -- 2.56.0