From: Florian Fainelli <florian.fainelli@broadcom.com>
To: netde@vger.kernel.org
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Jonas Gorski <jonas.gorski@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
netdev@vger.kernel.org (open list:BROADCOM B53/SF2 ETHERNET
SWITCH DRIVER), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH net v3 0/8] net: dsa: b53: Preliminary fixes
Date: Fri, 30 Oct 2026 14:13:42 -0700 [thread overview]
Message-ID: <20261030211350.287566-1-florian.fainelli@broadcom.com> (raw)
This patch series contains fixes to issues reported by Sashiko on the
b53 PCS bug fixes being submitted, and then some more that came from
code review and testing.
Except for issue #2, all of the other issues did trigger in testing and
needed to be corrected.
Changes in v3:
- patch 2: added Daniel's R-b tag
- patch 3: mention in the commit message that deleting an absent entry
now returns -ENOENT, including when the lookup runs out of space
- patch 4: document that the patch also fixes the clear of the capture
port field in b53_mirror_del()
- patch 6: reference count the mirror source bits per port and
direction, ignoring deletions without a matching reference
- patch 7: new, harden mirror register programming:
- reset the mirror capture and source control registers at setup for
b53 and bcm_sf2, since not all switches are reset
- check and propagate all mirror register read/write errors, only
taking a source reference once hardware programming succeeded
- use the source masks rather than MIRROR_EN to decide whether the
destination is occupied, and write the destination before the source
- log failures in b53_mirror_del() since it cannot return an error
- patch 8: new, fix the mirror capture port encoding on BCM5325 and
BCM5365, which use an 11-bit bitmap (CPU port at bit 8) instead of a
port ID, and translate the CPU port in the ingress/egress source
masks as well (verified against the BCM5325E, BCM5325M and BCM5365P
datasheets)
Changes in v2:
- collected Jonas' R-b tags
- corrected logic in patch #3 to propagate -ENOENT, memset after the
debug print, translate -ENOSPC to -ENOENT when deleting
Florian Fainelli (8):
net: dsa: b53: initialize the jumbo frame size register offset
net: dsa: b53: fix the SRAB grant timeout check
net: dsa: b53: clear stale state when creating an ARL entry
net: dsa: b53: reject conflicting mirror destinations
net: dsa: b53: use the correct override register 2 Gbps bit
net: dsa: b53: reference count shared mirror source bits
net: dsa: b53: harden mirror register programming
net: dsa: b53: fix mirror port encoding on BCM5325 and BCM5365
drivers/net/dsa/b53/b53_common.c | 183 ++++++++++++++++++++++++-------
drivers/net/dsa/b53/b53_priv.h | 3 +
drivers/net/dsa/b53/b53_regs.h | 1 +
drivers/net/dsa/b53/b53_srab.c | 2 +-
drivers/net/dsa/bcm_sf2.c | 5 +
5 files changed, 152 insertions(+), 42 deletions(-)
--
2.53.0
next reply other threads:[~2026-10-30 21:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 21:13 Florian Fainelli [this message]
2026-10-30 21:13 ` [PATCH net v3 1/8] net: dsa: b53: initialize the jumbo frame size register offset Florian Fainelli
2026-10-30 21:13 ` [PATCH net v3 2/8] net: dsa: b53: fix the SRAB grant timeout check Florian Fainelli
2026-10-30 21:13 ` [PATCH net v3 3/8] net: dsa: b53: clear stale state when creating an ARL entry Florian Fainelli
2026-10-30 21:13 ` [PATCH net v3 4/8] net: dsa: b53: reject conflicting mirror destinations Florian Fainelli
2026-10-30 21:13 ` [PATCH net v3 5/8] net: dsa: b53: use the correct override register 2 Gbps bit Florian Fainelli
2026-10-30 21:13 ` [PATCH net v3 6/8] net: dsa: b53: reference count shared mirror source bits Florian Fainelli
2026-10-30 21:13 ` [PATCH net v3 7/8] net: dsa: b53: harden mirror register programming Florian Fainelli
2026-10-30 21:13 ` [PATCH net v3 8/8] net: dsa: b53: fix mirror port encoding on BCM5325 and BCM5365 Florian Fainelli
2026-10-30 21:16 [PATCH net v3 0/8] net: dsa: b53: Preliminary fixes Florian Fainelli
2026-10-30 22:11 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261030211350.287566-1-florian.fainelli@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=jonas.gorski@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netde@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®