Re: [PATCH v7 3/3] PCI: qcom: Implement shutdown() callback

[kernel test robot <lkp@intel.com>]

Hi Krishna,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 17bb0e2f6c8043f70a693a5f3797471cbed354c8]

url:    https://github.com/intel-lab-lkp/linux/commits/Krishna-Chaitanya-Chundru/PCI-host-common-Fix-early-bus-walk-exit-in-d3cold_possible/20261029-094927
base:   17bb0e2f6c8043f70a693a5f3797471cbed354c8
patch link:    https://lore.kernel.org/r/20261029-shutdown-v7-3-3fd7a76a6991%40oss.qualcomm.com
patch subject: [PATCH v7 3/3] PCI: qcom: Implement shutdown() callback
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20261030/202610302144.Iwq8RoDq-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project c2ea4440d4b64c148de4fdfca1fc2c437a0701e4)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261030/202610302144.Iwq8RoDq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610302144.Iwq8RoDq-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/pci/controller/dwc/pcie-qcom.c:2463:6: warning: variable 'pcie' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
    2463 |         if (pcie_cfg && pcie_cfg->firmware_managed) {
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/pci/controller/dwc/pcie-qcom.c:2481:6: note: uninitialized use occurs here
    2481 |         if (pcie)
         |             ^~~~
   drivers/pci/controller/dwc/pcie-qcom.c:2463:2: note: remove the 'if' if its condition is always false
    2463 |         if (pcie_cfg && pcie_cfg->firmware_managed) {
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    2464 |                 /*
         |                 ~~
    2465 |                  * Firmware owns the link teardown and clock/PHY shutdown in
         |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    2466 |                  * this mode; Linux only owns the chained MSI IRQ(s), which
         |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    2467 |                  * still need to be masked off before shutdown proceeds.
         |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    2468 |                  */
         |                  ~~
    2469 |                 pci = platform_get_drvdata(pdev);
         |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    2470 |         } else {
         |         ~~~~~~
   drivers/pci/controller/dwc/pcie-qcom.c:2460:24: note: initialize the variable 'pcie' to silence this warning
    2460 |         struct qcom_pcie *pcie;
         |                               ^
         |                                = NULL
   1 warning generated.


vim +2463 drivers/pci/controller/dwc/pcie-qcom.c

  2456	
  2457	static void qcom_pcie_shutdown(struct platform_device *pdev)
  2458	{
  2459		const struct qcom_pcie_cfg *pcie_cfg = of_device_get_match_data(&pdev->dev);
  2460		struct qcom_pcie *pcie;
  2461		struct dw_pcie *pci;
  2462	
> 2463		if (pcie_cfg && pcie_cfg->firmware_managed) {
  2464			/*
  2465			 * Firmware owns the link teardown and clock/PHY shutdown in
  2466			 * this mode; Linux only owns the chained MSI IRQ(s), which
  2467			 * still need to be masked off before shutdown proceeds.
  2468			 */
  2469			pci = platform_get_drvdata(pdev);
  2470		} else {
  2471			pcie = platform_get_drvdata(pdev);
  2472			pci = pcie->pci;
  2473	
  2474			if (pcie->global_irq)
  2475				disable_irq(pcie->global_irq);
  2476		}
  2477	
  2478		if (pci->pp.use_imsi_rx)
  2479			dw_pcie_free_msi(&pci->pp);
  2480	
  2481		if (pcie)
  2482			dw_pcie_suspend_noirq(pcie->pci, true);
  2483	
  2484		pm_runtime_put_sync(&pdev->dev);
  2485		pm_runtime_disable(&pdev->dev);
  2486	}
  2487	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki