From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793399832; b=zUhFiLAxgWtXc2NfL7myEBghdGmjjzgdCqESWlp9bl/CY1s/njeAo3oVWbMGU4XeCAFg SVDDdMe6LSqZSMiPPqvJ4lCtndLPSAdYQUVJHTA4+qfn5qvIVXn7Raf5EKabKwUkPn3hc FtPL+wk+ZU3GRIL/y3WmJBuTIV44NN8qxyaN7YY0bWGZRitrxIVbwurvIGz8uvIkJ3iSa A8ESb2LP/OJ7rhkzPdd8BGU0IXYT3MNkptBonEgmwPMO/CAPwZPcvrC2qtB0DoVi8F8c8 a3tueCdYeRK7NTQW/vRb1dxliXcFBqa37BlPmYg2HhloF3hb9kUEUEVUBaZzTOkatYQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793399832; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=ITruexzC3YrUxXEBUSI41RKRjFRMFCmpkb9IBOKFR5g=; b=4AVEOzom1lXAhYtFYpLvOrl+yWa/Z/kRe3CYrieFz9PadYAkffildgmxAl9BYXnsdlNA noevrhGtnwDtnitVnHvnmBYstIfph5ou0c1z5dbdt6uT4iVVsGDiX8/UtHr/TSCUm1ALL wdrItf447mJACKLAFAjGbHc5WyR2evkMjij56NBIlhS590ouKSu1UNfKalkIOMfRNGRQT uZlLMX7wjwb7MC6eujUW1RUUrWHtERgKDAIleBLtAwV1YMlQs0c1oBIQOgEqbiJIRGLaM HsFyrLmWPBROSa/AcuQ3rN6SOYumHHUbCiEFQjopzatNf+xkSF/Cs8yCT2QQjG8H/tw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b="PBKZ/jnW"; arc=none smtp.remote-ip=209.85.221.41 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45E0760A261F for ; Fri, 30 Oct 2026 22:37:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 45E0760A261F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=PBKZ/jnW Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-48dee593f18so993526f8f.3 for ; Fri, 30 Oct 2026 15:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793399831; x=1794004631; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ITruexzC3YrUxXEBUSI41RKRjFRMFCmpkb9IBOKFR5g=; b=PBKZ/jnWa7mmm0tS9g1kfixlHrM8IMYxEIHY2MEbheruyGor+NpYfhGtHuBAVe4OEn Rlhq1kUQhAokfvYgRY8u4jkmegL4T4AcB1oEplG9FIz61gKmJYcVUPIaCv8boO1zaYcA o6R46deS0v1dTBsiCHpNe5rB+V/TxVK1tP4uy53Vm69DxvvkRJR3YKaLfUQ/hnEgJaKM bJ1CdjOSK+dr+iKAbRthch670fYqnBO9M0VVg7NdGVHqQwregA6vSLYbIzjr52XRWQdS xOXa0TOG+UIeeRHYnCCzrhLpdp9aqxXWJFwjyvLXwsBdMksu3/zAm4Ziw7MctucOEoJo n1Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793399831; x=1794004631; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ITruexzC3YrUxXEBUSI41RKRjFRMFCmpkb9IBOKFR5g=; b=DoeLZ7nYrolctLx+tuHHmfFwkxcLvKR60xEp03b0G1CVBe10yySWau04yl3Lo78nQN OtlhnVtbLFnMDQQ89ZkZiH0XMH/LLPeK0n66Gcw1cKjnTbKUQbkAMPXecazf9yoXBtCQ EudZPrPurEYwq74ltpnhWk7dUFkkQmBwGNnDr+O2bgeRp5IW5KsJKbKbyx/sZSyNmRbL U2xgS1Xew1Z1+dwnh/xAfmZ23hCDOdPRBqtJ2O/llb7/rfLnCfWX5Y+hq359KE42/7cZ 6beRpmLRQSwYAOais38ij4cHAeviVB14wG3wtKoRxaQXCBRbd9QO7kPp9TG3c0GXjI4K Yc5w== X-Forwarded-Encrypted: i=1; AKwUvBzwPnrAZlg1Nvgv5GbnTzNs1xdqtDszg3HgdhHzGp3bvn3+O39SUdt43VSNAb8Pd0BIyvBni6u17Bav1AE=@vger.kernel.org X-Gm-Message-State: AFq9FYL2QyUe5dK17y7ut2mi9KccXmiVcAK2umyhQoGL9RcmoR7zn+cP YHX7AAJuHlkdNtopmJ+IgtjrbESOTvqN74YsnHwH33FKvTVExgthoYRQ X-Gm-Gg: AYBFou3es6DE3liXpdB9PZ2srbDEFdAyXAnNNDDTzW7S9z2Bk/uIqXVVRa6R0/hrwBz eSH+CFVaQhHjkxJGBOtQw0ZX5qLAYZYBxuyK/sCojlWz91Yjykek+lwgLdZcdWZIs+snB9k2AWU gIZmK129piPoTT8ypY2mMBtzOcRIY9KiRh0o9b9W/nCE8eQoYl+eWePK2pxK3c0iyPbDzC5JH7B H//kzEHH9MEPCFVY780MMkRNG9SSYjn9ou3oSnOo1yQ17UcqCGn8kJZ1XCcdnhtxnxVKms1r1nO 7ZGL5FbmCrCrkobbYN3eP8A3WipEqOQ5RMg548zQQn01bdT/ugT0w4SuFK8by0X5FNxT++OjXvx L4epZLObDIfnAsr7ou2K1YXJqe+o5hzVE9H8EzPNrPtsb8rnvBG1n9bpCItEZKOp/byy/OWT9O0 qeXpIocgx/ewE+pz5F9bbMrA927GzJ/4Clv+j4hcZ9aODixA10ycrx02Pf8sBlXY7Ci7w1AOQpB kSTJIYelXk4QUl8AgPE/6tYFpVfg8P38PzXMwpFzm0W2oTlfpd49DqLYXlyjJt+DOkgHRhJFBeH GhcrMx0i1SkNj9tCGFRhkkdqcNbf X-Received: by 2002:a05:6000:310c:b0:48e:2a6c:153b with SMTP id ffacd0b85a97d-48e6e2fb0e6mr8615074f8f.35.1793399830633; Fri, 30 Oct 2026 15:37:10 -0700 (PDT) Received: from m2.. ([37.142.145.227]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-48e71b959c1sm5457300f8f.45.2026.10.30.15.37.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2026 15:37:10 -0700 (PDT) From: Michael Zaidman To: Jiri Kosina , Benjamin Tissoires Cc: Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , Jiri Slaby , Raman Varabets , Germain Hebert , Christina Quast , Rio Liu , Bruno Giacomazzi , linux-input@vger.kernel.org, linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Zaidman Subject: [PATCH v2 06/15] HID: ft260: i2c: reduce bus-error message severity Date: Sat, 31 Oct 2026 00:36:28 +0200 Message-ID: <20261030223637.86907-7-michael.zaidman@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261030223637.86907-1-michael.zaidman@gmail.com> References: <20261030223637.86907-1-michael.zaidman@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver logged errors when the FT260 reported an I2C bus error or when ft260_i2c_write / ft260_smbus_write failed after such a status. That was meant to flag unexpected failures, but bus scans (i2cdetect, HWMON discovery, transceiver monitoring, and similar) hit missing devices routinely and should not spam dmesg with either: i2c bus error: %#02x ft260_i2c_write: failed with -5 Keep returning -EIO, but print those via ft260_dbg. Still use hid_err in ft260_hid_output_report_check_status for actual HID/USB transport failures, which are genuine errors. Drop the extra __func__ from the write-path ft260_dbg calls; the helper already prints the function name (reported by Sashiko). Signed-off-by: Michael Zaidman --- v2: do not print __func__ twice through ft260_dbg (reported by Sashiko). --- drivers/hid/hid-ft260.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c index d2c5c9ed7927..6f8d72938702 100644 --- a/drivers/hid/hid-ft260.c +++ b/drivers/hid/hid-ft260.c @@ -575,7 +575,7 @@ static int ft260_xfer_status(struct ft260_device *dev, u8 bus_busy) * to 1, bit 1 is also set to 1. */ if (report.bus_status & FT260_I2C_STATUS_ERROR) { - hid_err(hdev, "i2c bus error: %#02x\n", report.bus_status); + ft260_dbg("i2c bus error: %#02x\n", report.bus_status); return -EIO; } @@ -609,6 +609,7 @@ static int ft260_hid_output_report_check_status(struct ft260_device *dev, ret = ft260_hid_output_report(hdev, data, len); if (ret < 0) { + hid_err(hdev, "%s: failed with %d\n", __func__, ret); ft260_i2c_reset(hdev); return ret; } @@ -648,7 +649,6 @@ static int ft260_i2c_write(struct ft260_device *dev, u8 addr, u8 *data, int len, u8 flag) { int ret, wr_len, idx = 0; - struct hid_device *hdev = dev->hdev; struct ft260_i2c_write_request_report *rep = (struct ft260_i2c_write_request_report *)dev->i2c_wr_buf; @@ -679,7 +679,7 @@ static int ft260_i2c_write(struct ft260_device *dev, u8 addr, u8 *data, ret = ft260_hid_output_report_check_status(dev, (u8 *)rep, wr_len + 4); if (ret < 0) { - hid_err(hdev, "%s: failed with %d\n", __func__, ret); + ft260_dbg("failed with %d\n", ret); return ret; } @@ -695,7 +695,7 @@ static int ft260_i2c_write(struct ft260_device *dev, u8 addr, u8 *data, static int ft260_smbus_write(struct ft260_device *dev, u8 addr, u8 cmd, u8 *data, u8 data_len, u8 flag) { - int ret = 0; + int ret; int len = 4; struct ft260_i2c_write_request_report *rep = @@ -720,7 +720,7 @@ static int ft260_smbus_write(struct ft260_device *dev, u8 addr, u8 cmd, ret = ft260_hid_output_report_check_status(dev, (u8 *)rep, len); if (ret < 0) - hid_err(dev->hdev, "%s: failed with %d\n", __func__, ret); + ft260_dbg("failed with %d\n", ret); return ret; } -- 2.43.0