From: Matthias Goergens <matthias.goergens@gmail.com>
To: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] fbdev: pxafb: preserve IRQ probe errors
Date: Sat, 31 Oct 2026 11:32:36 +0800 [thread overview]
Message-ID: <20261031033236.2490968-1-matthias.goergens@gmail.com> (raw)
Preserve platform_get_irq() and devm_request_irq() errors, including
-EPROBE_DEFER, instead of replacing them with -ENODEV and -EBUSY.
Found by Sashiko AI review.
Link: https://lore.kernel.org/dri-devel/20260722075803.570532-1-panchuang@vivo.com
---
drivers/video/fbdev/pxafb.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
index 1682345fb9b0..1912cfce28d6 100644
--- a/drivers/video/fbdev/pxafb.c
+++ b/drivers/video/fbdev/pxafb.c
@@ -2306,15 +2306,13 @@ static int pxafb_probe(struct platform_device *dev)
irq = platform_get_irq(dev, 0);
if (irq < 0) {
- ret = -ENODEV;
+ ret = irq;
goto failed_free_mem;
}
ret = devm_request_irq(&dev->dev, irq, pxafb_handle_irq, 0, "LCD", fbi);
- if (ret) {
- ret = -EBUSY;
+ if (ret)
goto failed_free_mem;
- }
ret = pxafb_smart_init(fbi);
if (ret) {
base-commit: d89e1d186ec9271bf78e62771779e9fc03bf0fc3
prerequisite-patch-id: 44b1c2680cb029871e123eb11eab7764a807ef24
--
2.56.0
reply other threads:[~2026-10-31 3:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261031033236.2490968-1-matthias.goergens@gmail.com \
--to=matthias.goergens@gmail.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®