mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 James Clark <james.clark@linaro.org>,
	Alireza Haghdoost <haghdoost@uber.com>,
	 linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Ian Rogers <irogers@google.com>
Subject: [PATCH 0/3] perf symbols/callchain/annotate: Bug fixes from symbol reference counting review
Date: Fri, 30 Oct 2026 23:35:46 -0700	[thread overview]
Message-ID: <20261031063549.1281324-1-irogers@google.com> (raw)

While reviewing the v2 symbol reference counting series [1], Alireza
Haghdoost identified three existing bugs in callchain merging, ELF
zero-size symbol end calculation across .symtab and .dynsym, and basic
block range splitting/cleanup in 'perf annotate'.

Pull these three fixes out ahead of v3 of the main series so they can
land for the v7.4 merge window:

1. perf callchain: Fix loss of symbol in merge_chain_branch()
   Restore .sym = list->ms.sym when constructing the temporary
   struct map_symbol in merge_chain_branch(), fixing missing symbol
   names and inlined frames in 'perf report --children'.

2. perf symbol-elf: Fix zero-size symbol end calculation across .symtab
   and .dynsym
   Move symbols__fixup_end(), symbols__fixup_duplicate(), and
   maps__fixup_end() from dso__load_sym_internal() to dso__load_sym() so
   zero-size .symtab symbols do not get extended across following
   .dynsym-only functions before .dynsym is loaded, and add a unit test
   in 'perf test symbols'.

3. perf annotate: Fix block_range symbol loss on split and leaks on exit
   Preserve .sym = entry->sym when splitting head/tail basic block
   ranges in block_range__create(), add block_ranges__exit(), and release
   resolved branch_info addr_map_symbol references in
   process_branch_stack().

This series was prepared with the assistance of Antigravity and Gemini 4.

Link: https://lore.kernel.org/linux-perf-users/20261027231513.816148-1-irogers@google.com/ [1]
Assisted-by: Antigravity:Gemini-4

Ian Rogers (3):
  perf callchain: Fix loss of symbol in merge_chain_branch()
  perf symbol-elf: Fix zero-size symbol end calculation across .symtab
    and .dynsym
  perf annotate: Fix block_range symbol loss on split and leaks on exit

 tools/perf/builtin-annotate.c |   5 +
 tools/perf/tests/symbols.c    | 169 ++++++++++++++++++++++++++++++++++
 tools/perf/util/block-range.c |  16 ++++
 tools/perf/util/block-range.h |   1 +
 tools/perf/util/callchain.c   |   1 +
 tools/perf/util/symbol-elf.c  |  36 +++++---
 6 files changed, 213 insertions(+), 15 deletions(-)

-- 
2.56.0.317.g454f8302e1-goog


             reply	other threads:[~2026-10-31  6:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-31  6:35 Ian Rogers [this message]
2026-10-31  6:35 ` [PATCH 1/3] perf callchain: Fix loss of symbol in merge_chain_branch() Ian Rogers
2026-10-31  6:35 ` [PATCH 2/3] perf symbol-elf: Fix zero-size symbol end calculation across .symtab and .dynsym Ian Rogers
2026-10-31  6:35 ` [PATCH 3/3] perf annotate: Fix block_range symbol loss on split and leaks on exit Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261031063549.1281324-1-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=haghdoost@uber.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®