From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.53 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793468551; b=obcjnq0Ptsff6AQvdKFMNyU6Erm7Gh8yz4WSZm2YJ6G13eTME3JgivJlPbf32sw4hoFN 2MJThWyf+Da1yjDaE5zvZ9Fddnek4IKm3RmBQqLEJw298tOPNvnAUyIwYvjEpZRoGIHU/ kQP4CFkTIKqT36hOO1CZVF6HZecr1DDbDE5FrEQLps2D+NmLtKX1mHYneEhTjs33QHcen quZ2wx+THXIrMX1cX7vB578pYOkCBU0iziGYpfAoNeUpN/C43o/FCrEsxYXRwgc7aqRg2 prpJV0wD7nlRt/zyOfZ+0QkQai7kRFFw0cdVrYH0htPSirKd1Ehhp0RM+Q0gb6ObwaQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793468551; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=4aSoQz50UkxhUHwi1YEnkG2T2JwIMwdIrJB94mJsJa0=; b=yPuG86NhsBAios1bfLQAc7uQtyEmB1haLm+JHmLxX2IYWPWH+hU3y9KnO+X8i76Pb2kV YAtlROyQkqcFoK1OEKCYc+CsQh3637xTGiJQyLfbClpPnOybnxqqmirRcOR37YfqrNUhz N8cIBtL+wS1cx+NqsubU9XXMMR7qtWmqG0y0wZsEUJxxVU+rEI6OqSipmekYN4CfnvUJV GINDXHv2Fji58DblTf/khXYWnhi16eb108LkfyPrECjN2t8dBkFdI9r9Y9M7VBJOjy2hW lVZ3JgvBr4rhhU6l8MADLrIeEy34K9iCu0FMGfpoy+O9riXTAPQ+6FwWism3oMIjkCA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=S60XpYnX; arc=none smtp.remote-ip=95.215.58.53 Received: from mta1.migadu.com (out-53.mta1.migadu.com [95.215.58.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52459606A31A for ; Sat, 31 Oct 2026 17:42:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 52459606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=S60XpYnX X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=hQYcDp5T51D0Q+QYDZJn3oMEC0g4AyBTIgom/lK4z58=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793468548; v=1; x=1794073348; b=S60XpYnX4YbRgn2WsO7FCZQQJ0hx7vQDrIVyuRWVjhTtNi+k5oee7AGDt4L09QFfvfYPdgcr 6XoZ9N1yZLOjKC7i6VsoAQilN4dyXbbYPwvsJv/eYsNvMEB2tOl+Eu06n3buj1wiJuvvtSBIz7j Lp5P6TW5lsCerxZuBwvOX1Ho= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id ac3ee34f8b3d0526; Sat, 31 Oct 2026 17:42:28 +0000 X-Mizu-Trace-ID: ac3ee34f8b3d0526 X-Migadu-Flow: FLOW_OUT From: Denis Benato To: linux-kernel@vger.kernel.org Cc: platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org, kernel@lists.opengamingcollective.org, "Benjamin Tissoires" , "Jiri Kosina" , "Luke D . Jones" , "Mateusz Schwartz" , "Denis Benato" , "Jonathan LoBue" , "Khamunetri Clark" , "Derek J. Clark" , "Joshua Leivenzon" , "Nathan Chancellor" , =?UTF-8?q?Rebecca=20Mara=20M=C3=BCller?= , "Ivan Levchenko" , "Corentin Chary" , "Hans de Goede" , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Denis Benato Subject: [PATCH v12 10/17] HID: asus: add support for gamepad mode Date: Sat, 31 Oct 2026 17:41:23 +0000 Message-ID: <20261031174130.208240-11-denis.benato@linux.dev> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261031174130.208240-1-denis.benato@linux.dev> References: <20261031174130.208240-1-denis.benato@linux.dev> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ROG Ally devices can emulate either a mouse+keyboard (desktop mode) or an gamepad device (xbox360 controller in ROG ally and a custom DInput device on newer models): add support for switching the current controller mode. Co-developed-by: Luke Jones Signed-off-by: Luke Jones Signed-off-by: Denis Benato --- drivers/hid/hid-asus.c | 130 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 129 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 3ade3dbda72e..3e58c5ca0cbd 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -352,6 +352,20 @@ enum ally_command_codes { CMD_SET_ANTI_DEADZONE = 0x18, }; +enum ally_gamepad_mode_index { + ALLY_GAMEPAD_MODE_GAMEPAD = 0x01, + ALLY_GAMEPAD_MODE_KEYBOARD = 0x02, +}; + +static const char *const ally_gamepad_mode_text[] = { + "gamepad", "desktop" +}; + +static const u8 ally_gamepad_mode_value[] = { + ALLY_GAMEPAD_MODE_GAMEPAD, + ALLY_GAMEPAD_MODE_KEYBOARD +}; + /* Rumble magnitudes use the hardware's 0..100 intensity range. */ #define ALLY_FF_MAX_INTENSITY 100 @@ -1372,6 +1386,112 @@ static struct device_attribute dev_attr_right_joystick_outer_threshold = static struct device_attribute dev_attr_right_joystick_outer_threshold_range = __ATTR(outer_threshold_range, 0444, right_joystick_outer_threshold_range_show, NULL); +/** + * ally_set_gamepad_mode() - Set the gamepad operating mode + * @hdev: HID device the command packet is sent on + * @mode: %ALLY_GAMEPAD_MODE_GAMEPAD or %ALLY_GAMEPAD_MODE_KEYBOARD + * + * Context: Caller holds ally_prefs.lock. + * Return: 0 on success, negative errno on failure. + */ +static int ally_set_gamepad_mode(struct hid_device *hdev, u8 mode) +{ + const u8 payload[] = { mode }; + size_t buf_len; + int ret; + + if (mode < ALLY_GAMEPAD_MODE_GAMEPAD || mode > ALLY_GAMEPAD_MODE_KEYBOARD) { + hid_err(hdev, "Invalid gamepad mode: %u\n", mode); + return -EINVAL; + } + + u8 *buf __free(kfree) = ally_alloc_cmd(hdev, CMD_SET_GAMEPAD_MODE, + payload, sizeof(payload), + &buf_len); + if (!buf) + return -ENOMEM; + + ret = ally_gamepad_send_packet(hdev, buf, buf_len); + if (ret < 0) { + hid_err(hdev, "Failed to set gamepad mode: %d\n", ret); + return ret; + } + + return 0; +} + +static ssize_t gamepad_mode_show(struct device *dev, struct device_attribute *attr, + char *buf) +{ + u8 mode_byte; + int i; + + guard(mutex)(&ally_prefs.lock); + + mode_byte = ally_prefs.gamepad_mode; + for (i = 0; i < ARRAY_SIZE(ally_gamepad_mode_value); i++) { + if (ally_gamepad_mode_value[i] == mode_byte) + return sysfs_emit(buf, "%s\n", ally_gamepad_mode_text[i]); + } + + /* + * The recorded mode only comes from the table above: an unknown + * byte means memory corruption, not a userspace-visible value. + */ + return -EIO; +} + +static ssize_t gamepad_mode_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) +{ + struct hid_device *hdev = to_hid_device(dev); + u8 mode_byte; + int mode, ret; + + mode = sysfs_match_string(ally_gamepad_mode_text, buf); + if (mode < 0) + return mode; + + /* The text index maps to the byte the MCU accepts. */ + mode_byte = ally_gamepad_mode_value[mode]; + + scoped_guard(mutex, &ally_prefs.lock) { + ret = ally_set_gamepad_mode(hdev, mode_byte); + if (ret < 0) + return ret; + + ally_prefs.gamepad_mode = mode_byte; + } + + hid_dbg(hdev, "Set gamepad mode to %s\n", ally_gamepad_mode_text[mode]); + sysfs_notify(&dev->kobj, NULL, "gamepad_mode"); + + return count; +} + +static ssize_t gamepad_mode_available_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + ssize_t len = 0; + int i; + + for (i = 0; i < ARRAY_SIZE(ally_gamepad_mode_text); i++) { + if (!ally_gamepad_mode_text[i] || ally_gamepad_mode_text[i][0] == '\0') + continue; + + len += sysfs_emit_at(buf, len, "%s ", ally_gamepad_mode_text[i]); + } + + /* Replace the last space with a newline. */ + if (len > 0) + buf[len - 1] = '\n'; + + return len; +} + +static DEVICE_ATTR_RW(gamepad_mode); +static DEVICE_ATTR_RO(gamepad_mode_available); + /** * ally_set_anti_deadzone() - Send the joystick anti-deadzone values to the device * @hdev: HID device the packet is sent on @@ -1981,6 +2101,8 @@ static const struct attribute_group *const ally_cal_attr_groups[] = { static struct attribute *ally_config_attrs[] = { &dev_attr_xbox_controller.attr, + &dev_attr_gamepad_mode.attr, + &dev_attr_gamepad_mode_available.attr, NULL }; @@ -2014,7 +2136,7 @@ static int ally_prefs_setup(struct hid_device *hdev) guard(mutex)(&ally_prefs.lock); if (!ally_prefs.initialized) { - ally_prefs.gamepad_mode = 0x01; + ally_prefs.gamepad_mode = ALLY_GAMEPAD_MODE_GAMEPAD; ally_prefs.xbox_controller_enabled = true; ally_prefs.initialized = true; } @@ -2422,6 +2544,12 @@ static int hid_asus_ally_init(struct hid_device *hdev) hid_warn(hdev, "Failed to restore right response curve: %d\n", ret); } + if (ally_prefs.initialized) { + ret = ally_set_gamepad_mode(hdev, ally_prefs.gamepad_mode); + if (ret < 0) + hid_warn(hdev, "Failed to restore gamepad mode: %d\n", ret); + } + return 0; } -- 2.47.3