From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.24 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793468537; b=XGVM/PTHJ1z4YlJFa+OxQnIvjy4nAvNzf8ulSNP5MHPwFz1AL0P3q0F/eLssrRK+dDLX 4szvT7sgkw74042g9KiiQKP4C5nh+q7O5msX3mZ1OmUjeJTpMkiCW7R7fJVzND5IwESx2 afI7xiiWNhPWEf0JMNbF6mOWXWtv9L3C1xA1bbWZ9J7husQ25pTQuA5CfaJDLIy1LgdwN mPF81M8V/V1fQaoaFd2JBuvXR3tmA7eKFhnsG80nnrRV7SByhFXYiFTHDZ4f/N7mtsR49 Bz55qhF3XLLuqH6iwnzUpTelbPrAIaP33NJGA/A1aBcsW12Mrcgtq976/5q7iFIrYMQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793468537; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=WvHblN7/DWqafuQ+dzVZRhgLfLXh2DmHES79s5/Zay0=; b=hLG+bFpxWyLFvDq27v+TAHdoWIlffoQ3WRiDxOm7aJRHJ+UM7QT/Zrkvsksvq9KY/Q/Y Mb4UWbTBs+eTK2QxBXk5Q1pxFNSFhod1FjC1e/VKJYp9XTEQh6XQB7pGmy/H9dpJB8C41 MqbOAJ6mGGFfW7MJ3zRrceLJFUL0GniRvv0dhy2g6zTbXquIaBzNLoB3vX2phX6Tuuy64 FXrkXZt/WnJYKyg7lCeNQgCiDd+lxWa4f8enovBjT1VE4ZLgV3HgWlxc7ojv0U9VtqQkH /WP8TbrVWPApOCMnLLL8tkeGqLFNwfuImoID22FugNGJmkeO3DHJUMWktRBbd0Tx1eQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=SIwQXeD4; arc=none smtp.remote-ip=95.215.58.24 Received: from mta1.migadu.com (out-24.mta1.migadu.com [95.215.58.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D864606A332 for ; Sat, 31 Oct 2026 17:42:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 6D864606A332 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=SIwQXeD4 X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=S2bOV1bS8ynTsXm/Jz0LWyT2Yz9y+upWwBaksNr8znU=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793468534; v=1; x=1794073334; b=SIwQXeD4k+T7B5C+9lWrPbwpvV63qed0J2pgD/qodNmQbOA5CBaRfuJ7ku2Z0Ng85cmIxt2Q mVaBp3G1QvDc2c7pH3sGogQZjy7FoUt3T9WX4ebp116uzeWlDgqDo5YO66fN+9iPTfAthtqOPdv KTU22d4/c8ow61JRH+SyADPk= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 81120666828a3cf8; Sat, 31 Oct 2026 17:42:14 +0000 X-Mizu-Trace-ID: 81120666828a3cf8 X-Migadu-Flow: FLOW_OUT From: Denis Benato To: linux-kernel@vger.kernel.org Cc: platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org, kernel@lists.opengamingcollective.org, "Benjamin Tissoires" , "Jiri Kosina" , "Luke D . Jones" , "Mateusz Schwartz" , "Denis Benato" , "Jonathan LoBue" , "Khamunetri Clark" , "Derek J. Clark" , "Joshua Leivenzon" , "Nathan Chancellor" , =?UTF-8?q?Rebecca=20Mara=20M=C3=BCller?= , "Ivan Levchenko" , "Corentin Chary" , "Hans de Goede" , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Denis Benato Subject: [PATCH v12 07/17] HID: asus: add joysticks anti-deadzone configuration Date: Sat, 31 Oct 2026 17:41:20 +0000 Message-ID: <20261031174130.208240-8-denis.benato@linux.dev> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261031174130.208240-1-denis.benato@linux.dev> References: <20261031174130.208240-1-denis.benato@linux.dev> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ROG Ally devices allow configuring the anti-deadzone parameter for the resistive joysticks devices as over time those develops drift, therefore allow userspace to configure the anti-deadzone by exposing relevant sysfs attributes. Signed-off-by: Denis Benato Co-developed-by: Luke Jones Signed-off-by: Luke Jones --- drivers/hid/hid-asus.c | 158 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 155 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 5cf7258bc427..9bfdde560834 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -784,6 +784,9 @@ static struct ally_prefs { u8 left_trigger_max; u8 right_trigger_min; u8 right_trigger_max; + + u8 left_anti_deadzone; + u8 right_anti_deadzone; } ally_prefs = { .lock = __MUTEX_INITIALIZER(ally_prefs.lock), }; @@ -1321,11 +1324,152 @@ static struct device_attribute dev_attr_right_joystick_outer_threshold = static struct device_attribute dev_attr_right_joystick_outer_threshold_range = __ATTR(outer_threshold_range, 0444, right_joystick_outer_threshold_range_show, NULL); +/** + * ally_set_anti_deadzone() - Send the joystick anti-deadzone values to the device + * @hdev: HID device the packet is sent on + * @left: Anti-deadzone of the left joystick + * @right: Anti-deadzone of the right joystick + * + * Context: Caller must hold ally_prefs.lock. + * + * Return: 0 on success, -%EOPNOTSUPP if the device does not support + * anti-deadzone, -%ENOMEM if the command buffer cannot be allocated, or a + * negative error code if sending the packet fails. + */ +static int ally_set_anti_deadzone(struct hid_device *hdev, u8 left, u8 right) +{ + const u8 payload[] = { left, right }; + size_t buf_len; + int ret; + + if (!ally_prefs.anti_deadzone_support) { + hid_dbg(hdev, "Anti-deadzone not supported on this device\n"); + return -EOPNOTSUPP; + } + + u8 *buf __free(kfree) = ally_alloc_cmd(hdev, CMD_SET_ANTI_DEADZONE, + payload, sizeof(payload), + &buf_len); + if (!buf) + return -ENOMEM; + + ret = ally_gamepad_send_packet(hdev, buf, buf_len); + if (ret < 0) { + hid_err(hdev, "Failed to set anti-deadzone values: %d\n", ret); + return ret; + } + + return 0; +} + +/* Indices into ally_anti_deadzones[] */ +enum ally_joystick { + ALLY_LEFT_JOYSTICK, + ALLY_RIGHT_JOYSTICK, +}; + +static u8 *const ally_anti_deadzones[] = { + [ALLY_LEFT_JOYSTICK] = &ally_prefs.left_anti_deadzone, + [ALLY_RIGHT_JOYSTICK] = &ally_prefs.right_anti_deadzone, +}; + +static ssize_t ally_anti_deadzone_show(struct device *dev, char *buf, + enum ally_joystick which) +{ + guard(mutex)(&ally_prefs.lock); + + if (!ally_prefs.anti_deadzone_support) { + hid_dbg(to_hid_device(dev), "Anti-deadzone not supported on this device\n"); + return -EOPNOTSUPP; + } + + return sysfs_emit(buf, "%u\n", *ally_anti_deadzones[which]); +} + +static ssize_t ally_anti_deadzone_store(struct device *dev, const char *buf, + size_t count, enum ally_joystick which, + const char *group) +{ + u8 value, dz[ARRAY_SIZE(ally_anti_deadzones)]; + struct hid_device *hdev = to_hid_device(dev); + unsigned int i; + int ret; + + ret = kstrtou8(buf, 10, &value); + if (ret || value > 100) + return -EINVAL; + + scoped_guard(mutex, &ally_prefs.lock) { + if (!ally_prefs.anti_deadzone_support) { + hid_dbg(hdev, "Anti-deadzone not supported on this device\n"); + return -EOPNOTSUPP; + } + + for (i = 0; i < ARRAY_SIZE(dz); i++) + dz[i] = *ally_anti_deadzones[i]; + dz[which] = value; + + ret = ally_set_anti_deadzone(hdev, dz[ALLY_LEFT_JOYSTICK], + dz[ALLY_RIGHT_JOYSTICK]); + if (ret) + return ret; + + *ally_anti_deadzones[which] = value; + } + + sysfs_notify(&dev->kobj, group, "anti_deadzone"); + + return count; +} + +/* Generates _joystick_anti_deadzone_{show,store,range_show}. */ +#define ALLY_ANTI_DEADZONE_FUNCS(side, SIDE) \ +static ssize_t side##_joystick_anti_deadzone_show(struct device *dev, \ + struct device_attribute *attr, \ + char *buf) \ +{ \ + return ally_anti_deadzone_show(dev, buf, ALLY_##SIDE##_JOYSTICK); \ +} \ + \ +static ssize_t side##_joystick_anti_deadzone_store(struct device *dev, \ + struct device_attribute *attr, \ + const char *buf, size_t count) \ +{ \ + return ally_anti_deadzone_store(dev, buf, count, ALLY_##SIDE##_JOYSTICK, \ + #side "_joystick_axis"); \ +} \ + \ +static ssize_t side##_joystick_anti_deadzone_range_show(struct device *dev, \ + struct device_attribute *attr, \ + char *buf) \ +{ \ + return sysfs_emit(buf, "0 100\n"); \ +} + +ALLY_ANTI_DEADZONE_FUNCS(left, LEFT) +ALLY_ANTI_DEADZONE_FUNCS(right, RIGHT) + +static struct device_attribute dev_attr_left_joystick_anti_deadzone = + __ATTR(anti_deadzone, 0644, left_joystick_anti_deadzone_show, + left_joystick_anti_deadzone_store); + +static struct device_attribute dev_attr_left_joystick_anti_deadzone_range = + __ATTR(anti_deadzone_range, 0444, left_joystick_anti_deadzone_range_show, NULL); + +static struct device_attribute dev_attr_right_joystick_anti_deadzone = + __ATTR(anti_deadzone, 0644, right_joystick_anti_deadzone_show, + right_joystick_anti_deadzone_store); + +static struct device_attribute dev_attr_right_joystick_anti_deadzone_range = + __ATTR(anti_deadzone_range, 0444, right_joystick_anti_deadzone_range_show, NULL); + static struct attribute *left_joystick_axis_attrs[] = { &dev_attr_left_joystick_inner_threshold.attr, &dev_attr_left_joystick_outer_threshold.attr, &dev_attr_left_joystick_inner_threshold_range.attr, &dev_attr_left_joystick_outer_threshold_range.attr, + &dev_attr_left_joystick_anti_deadzone.attr, + &dev_attr_left_joystick_anti_deadzone_range.attr, NULL }; @@ -1334,6 +1478,8 @@ static struct attribute *right_joystick_axis_attrs[] = { &dev_attr_right_joystick_outer_threshold.attr, &dev_attr_right_joystick_inner_threshold_range.attr, &dev_attr_right_joystick_outer_threshold_range.attr, + &dev_attr_right_joystick_anti_deadzone.attr, + &dev_attr_right_joystick_anti_deadzone_range.attr, NULL }; @@ -1602,7 +1748,7 @@ static int ally_prefs_setup(struct hid_device *hdev) } /* Skip the calibration groups when the capability is missing. */ - if (ally_prefs.user_cal_support) { + if (ally_prefs.user_cal_support || ally_prefs.anti_deadzone_support) { int cal_i; for (cal_i = 0; cal_i < ARRAY_SIZE(ally_cal_attr_groups); cal_i++) { @@ -1643,8 +1789,7 @@ static void ally_sysfs_remove(struct hid_device *hdev) for (i = 0; i < ARRAY_SIZE(ally_attr_groups); i++) sysfs_remove_group(&hdev->dev.kobj, &ally_attr_groups[i]); - if (ally_prefs.user_cal_support || ally_prefs.anti_deadzone_support || - ally_prefs.resp_curve_support) { + if (ally_prefs.user_cal_support || ally_prefs.anti_deadzone_support) { for (i = 0; i < ARRAY_SIZE(ally_cal_attr_groups); i++) sysfs_remove_group(&hdev->dev.kobj, ally_cal_attr_groups[i]); } @@ -1871,6 +2016,13 @@ static int hid_asus_ally_init(struct hid_device *hdev) hid_warn(hdev, "Failed to restore trigger ranges: %d\n", ret); } + if (ally_prefs.initialized && ally_prefs.anti_deadzone_support) { + ret = ally_set_anti_deadzone(hdev, ally_prefs.left_anti_deadzone, + ally_prefs.right_anti_deadzone); + if (ret < 0) + hid_warn(hdev, "Failed to restore anti-deadzone: %d\n", ret); + } + return 0; } -- 2.47.3