From: Simon Horman <horms@kernel.org>
To: "Björn Töpel" <bjorn@kernel.org>
Cc: Alexander Duyck <alexanderduyck@fb.com>,
Jakub Kicinski <kuba@kernel.org>,
kernel-team@meta.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH net] eth: fbnic: Report the logical RX queue to XDP
Date: Sat, 31 Oct 2026 18:33:34 +0000 [thread overview]
Message-ID: <20261031183334.GX257209@horms.kernel.org> (raw)
In-Reply-To: <20261030141452.1173282-1-bjorn@kernel.org>
On Fri, Oct 30, 2026 at 03:14:50PM +0100, Björn Töpel wrote:
> fbnic reports queue 0 to XDP on all RX queues. The XDP RX queue is
> registered with the header buffer queue index, which is always 0,
> instead of the completion queue index, which is the netdev queue id.
>
> Any XDP program that reads rx_queue_index gets 0 on every queue, so a
> program that uses the queue id uses the wrong queue. AF_XDP has the
> same problem: XSKMAP finds the wrong socket, and redirect to a socket
> on another queue fails.
>
> Triggered on fbnic hardware (50G, firmware 25.08.05-004) with AF_XDP
> zero-copy: sockets on queues other than 0 got no packets. With this
> fix, a socket on queue 43, and sockets on four queues at once, get
> their packets. On the QEMU model with two queues, a kprobe shows 0 and
> 0 before the fix, and 0 and 1 after it.
>
> Fixes: 894d4a4ea6cb ("eth: fbnic: move xdp_rxq_info_reg() to resource alloc")
> Signed-off-by: Björn Töpel <bjorn@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-10-31 18:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 14:14 Björn Töpel
2026-10-31 18:33 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261031183334.GX257209@horms.kernel.org \
--to=horms@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®