Re: [PATCH] staging: greybus: light: use sysfs_emit() instead of sprintf()

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sat, Oct 31, 2026 at 03:48:13PM +0700, Kenzema wrote:
> According to Documentation/filesystems/sysfs.rst, the show() callback
> should use sysfs_emit() instead of sprintf() or snprintf().
> Convert fade_*_show() and color_show() to use sysfs_emit() for safer
> buffer handling and consistency with other greybus drivers.
> 
> Signed-off-by: Kenzema <ken3009le@gmail.com>
> ---
>  drivers/staging/greybus/light.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
> index cab02b5da..2689f9a75 100644
> --- a/drivers/staging/greybus/light.c
> +++ b/drivers/staging/greybus/light.c
> @@ -173,7 +173,7 @@ static ssize_t fade_##__dir##_show(struct device *dev,			\
>  	struct led_classdev *cdev = dev_get_drvdata(dev);		\
>  	struct gb_channel *channel = get_channel_from_cdev(cdev);	\
>  									\
> -	return sprintf(buf, "%u\n", channel->fade_##__dir);		\
> +	return sysfs_emit(buf, "%u\n", channel->fade_##__dir);		\

Please read the mailing list for why this keeps getting rejected.

thanks,

greg k-h