From: Jonathan Cameron <jic23@kernel.org>
To: Andrei Stancovici via B4 Relay
<devnull+andrei.stancovici.analog.com@kernel.org>
Cc: andrei.stancovici@analog.com, "Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Liam Beguin" <liambeguin@gmail.com>,
"Joshua Crofts" <joshua.crofts1@gmail.com>,
linux@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Conor Dooley" <conor.dooley@microchip.com>
Subject: Re: [PATCH v3 0/4] iio: adc: ltc2497: add LTC2493 support and line-frequency rejection
Date: Sun, 1 Nov 2026 01:49:35 +0000 [thread overview]
Message-ID: <20261101014935.411c75af@jic23-hlaptop> (raw)
In-Reply-To: <20261029-submission-ltc2493-support-v1-v3-0-c7dd5f877c3b@analog.com>
On Thu, 29 Oct 2026 00:24:25 +0200
Andrei Stancovici via B4 Relay <devnull+andrei.stancovici.analog.com@kernel.org> wrote:
> This series adds LTC2493 support to the ltc2497 driver, and adds FA/FB
> line-frequency rejection for the LTC2499 and the LTC2493.
>
> It includes:
> - the LTC2493 device-tree binding,
> - FA/FB line-frequency rejection (50Hz, 60Hz, or both) exposed via
> filter_mode, implemented in the core and enabled for the LTC2499,
> - a preparatory refactor giving each supported channel layout a channel
> set in the core, referenced directly from chip_info,
> - LTC2493 support in the driver: 4 single-ended inputs or 2 differential
> pairs, 24-bit result, same command format as the LTC2499, the internal
> PTAT temperature channel, the 2x conversion speed mode exposed via
> sampling_frequency, and the same rejection selection.
>
> The rejection patch also adjusts the conversion wait time for each
> rejection mode. The 50Hz-only mode takes up to 163.5 ms at 1x, while the
> previous fixed 150 ms delay only covered the default 50/60Hz mode.
>
> Validated on a Raspberry Pi 4 running 7.3.0-rc4, over an IIO network
> backend, with a DC1010A-A board (LTC2493), a DC1012A-A board (LTC2499)
> and an LTC2497:
> - LTC2493: 41/41 hardware tests passed,
> - LTC2499: 36/36 hardware tests passed,
> - LTC2497: 24/24 hardware tests passed,
> - all LTC2493 rejection x speed combinations were exercised without
> conversion or I2C errors.
>
> LTC2496 was build-tested only because no LTC2496 hardware was available.
>
> The source in this series matches the hardware-tested tree.
>
> Signed-off-by: Andrei Stancovici <andrei.stancovici@analog.com>
I've somewhat speculatively picked this up on basis it looks fine to me.
However, there is still time for additional review from Nuno or others
as, whilst I'll be rebasing shortly on rc1, I probably won't push out as not
rebasing until second half of the week.
So applied to the testing branch of iio.git
Thanks,
Jonathan
> ---
> Changes in v3:
> - The channel-set selection moved into a preparatory patch, so the patch
> adding the LTC2493 no longer touches the chip_info of the parts
> already supported (Nuno Sá).
> - chip_info now references a per-device channel set directly. The
> num_inputs field and the keyed lookup it was matched against in probe
> are both gone (Nuno Sá).
> - The LTC2493 patch is reduced to the device-specific additions.
> - The binding and FA/FB patches are unchanged. Nuno Sá's Reviewed-by is
> added to the FA/FB patch.
> - Behaviour revalidated on hardware on all three parts; see the
> validation summary above.
> - Per-patch changelogs are under the --- of each patch.
> - Link to v2: https://patch.msgid.link/20261022-submission-ltc2493-support-v1-v2-0-391d908d2877@analog.com
>
> ---
> Andrei Stancovici (4):
> dt-bindings: iio: adc: lltc,ltc2497: add LTC2493 support
> iio: adc: ltc2497: add FA/FB line-frequency rejection selection
> iio: adc: ltc2497: select the channel set per device
> iio: adc: ltc2497: add LTC2493 support
>
> .../devicetree/bindings/iio/adc/lltc,ltc2497.yaml | 7 +
> drivers/iio/adc/ltc2496.c | 1 +
> drivers/iio/adc/ltc2497-core.c | 208 ++++++++++++++++-----
> drivers/iio/adc/ltc2497.c | 47 +++--
> drivers/iio/adc/ltc2497.h | 44 ++++-
> 5 files changed, 243 insertions(+), 64 deletions(-)
> ---
> base-commit: a3b3580713f3ac5a32dc2874ee546828977a1d68
> change-id: 20261009-submission-ltc2493-support-v1-86449ede432d
>
> Best regards,
> --
> Andrei Stancovici <andrei.stancovici@analog.com>
>
>
prev parent reply other threads:[~2026-11-01 1:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 22:24 Andrei Stancovici via B4 Relay
2026-10-28 22:24 ` [PATCH v3 1/4] dt-bindings: iio: adc: lltc,ltc2497: add LTC2493 support Andrei Stancovici via B4 Relay
2026-10-28 22:24 ` [PATCH v3 2/4] iio: adc: ltc2497: add FA/FB line-frequency rejection selection Andrei Stancovici via B4 Relay
2026-10-28 22:24 ` [PATCH v3 3/4] iio: adc: ltc2497: select the channel set per device Andrei Stancovici via B4 Relay
2026-10-28 22:24 ` [PATCH v3 4/4] iio: adc: ltc2497: add LTC2493 support Andrei Stancovici via B4 Relay
2026-11-01 1:49 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261101014935.411c75af@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andrei.stancovici@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=devnull+andrei.stancovici.analog.com@kernel.org \
--cc=dlechner@baylibre.com \
--cc=joshua.crofts1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®