From: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
apais@microsoft.com, rlmenge@gmail.com,
hargar@linux.microsoft.com,
Siddharth Chintamaneni <sidchintamaneni@gmail.com>
Subject: [PATCH v1 0/2] fs: fix and deduplicate whence handling in default_llseek()
Date: Sat, 31 Oct 2026 23:00:47 -0700 [thread overview]
Message-ID: <20261101060049.81441-1-sidchintamaneni@gmail.com> (raw)
This series fixes negative offset validation for SEEK_DATA and SEEK_HOLE
in default_llseek() and deduplicates its whence handling with
must_set_pos().
Patch 1 updates default_llseek() to read the inode size once via
i_size_read(inode) and compare (unsigned long long)offset >= eof for
SEEK_DATA and SEEK_HOLE so negative offsets fail with -ENXIO instead of
bypassing the range check.
Patch 2 replaces the open-coded switch (whence) block in
default_llseek() with a call to must_set_pos().
Siddharth Chintamaneni (2):
fs: reject negative offsets for SEEK_DATA and SEEK_HOLE in
default_llseek()
fs: use must_set_pos() in default_llseek()
fs/read_write.c | 48 ++++++++++++++----------------------------------
1 file changed, 14 insertions(+), 34 deletions(-)
base-commit: 36aad21d50d1af3f6954bb0c988257a908202477
--
2.50.1 (Apple Git-155)
next reply other threads:[~2026-11-01 6:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 6:00 Siddharth Chintamaneni [this message]
2026-11-01 6:00 ` [PATCH v1 1/2] fs: reject negative offsets for SEEK_DATA and SEEK_HOLE " Siddharth Chintamaneni
2026-11-01 6:00 ` [PATCH v1 2/2] fs: use must_set_pos() " Siddharth Chintamaneni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261101060049.81441-1-sidchintamaneni@gmail.com \
--to=sidchintamaneni@gmail.com \
--cc=apais@microsoft.com \
--cc=brauner@kernel.org \
--cc=hargar@linux.microsoft.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rlmenge@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®