mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cheng Yongkang <teel4res@gmail.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Cheng Yongkang <teel4res@gmail.com>,
	David Sterba <dsterba@suse.com>, Chris Mason <mason@kernel.org>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: reject refs=0 subvolume without DEAD in SUBVOL_SYNC_WAIT
Date: Sat, 31 Oct 2026 23:28:39 -0700	[thread overview]
Message-ID: <20261101062839.1747239-1-teel4res@gmail.com> (raw)
In-Reply-To: <dd97efe9-91ec-495b-b698-acff1447421c@gmx.com>

Hi Qu,

Thanks for pointing out the failed-delete path. v2 is here:
https://lore.kernel.org/linux-btrfs/20261101062539.1744605-1-teel4res@gmail.com/

Before waiting for a deleted subvolume, it now returns -EROFS if the
filesystem is read-only. The check runs on every iteration, so it also
covers a filesystem that becomes read-only during the wait. On a
writable filesystem, a zero-reference root without DEAD returns
-EUCLEAN, with unlikely(). Subvolumes that were not deleted or do not
exist still return -EEXIST and -ENOENT.

Thanks,
Cheng Yongkang

      reply	other threads:[~2026-11-01  6:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-25 18:02 Cheng Yongkang
2026-10-26  1:13 ` Qu Wenruo
2026-11-01  6:28   ` Cheng Yongkang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261101062839.1747239-1-teel4res@gmail.com \
    --to=teel4res@gmail.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mason@kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®