mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Rupesh Majhi <zoone.rupert@gmail.com>
Cc: "Andy Shevchenko" <andy@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Eddie James" <eajames@linux.ibm.com>,
	"Joel Stanley" <joel@jms.id.au>, "Nuno Sá" <nuno.sa@analog.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sashiko <sashiko-bot@kernel.org>,
	"Paulius Zaleckas" <paulius.zaleckas@gmail.com>
Subject: Re: [PATCH 2/3] iio: pressure: dps310: reset the chip at probe
Date: Sun, 1 Nov 2026 17:30:09 +0000	[thread overview]
Message-ID: <20261101173009.3549f50d@jic23-hlaptop> (raw)
In-Reply-To: <20261101105855.55716-1-zoone.rupert@gmail.com>

On Sun,  1 Nov 2026 12:58:55 +0200
Rupesh Majhi <zoone.rupert@gmail.com> wrote:

> On Sun, 01 Nov 2026 01:04:44 +0000
> Jonathan Cameron <jic23@kernel.org> wrote:
> 
> > > Reset the chip first, as remove already does.  
> > Why do we do it in remove?  Does it put it in a power saving mode
> > or similar? It's fairly unusual to bother resetting in that path
> > given as you've seen here, we pretty much have to reset in probe.  
> 
> Yes, in effect. Driver leaves the chip measuring in background mode,
> and soft reset returns it to standby (datasheet 4.1). It came with the
> original driver without a stated reason.
> 
> Writing 0 to MEAS_CTRL would also stop it, if you'd rather not reset
> there.
I would prefer that as it would avoid the need for documentation
to say that the reset is there to put it into a low power mode.
If there hadn't been any other way to do it (unlike writing that 0)
then I'd have asked for a comment.

Thanks,

Jonathan

> 
> Rupesh


  reply	other threads:[~2026-11-01 17:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 22:06 [PATCH 0/3] iio: pressure: dps310: fix input checks and resets Rupesh Majhi
2026-10-29 22:06 ` [PATCH 1/3] iio: pressure: dps310: reject a zero rate or oversampling ratio Rupesh Majhi
2026-10-30  8:17   ` Joshua Crofts
2026-10-29 22:06 ` [PATCH 2/3] iio: pressure: dps310: reset the chip at probe Rupesh Majhi
2026-10-30  8:19   ` Joshua Crofts
2026-11-01  1:03   ` Jonathan Cameron
2026-11-01  1:04   ` Jonathan Cameron
2026-11-01 10:58     ` Rupesh Majhi
2026-11-01 17:30       ` Jonathan Cameron [this message]
2026-10-29 22:06 ` [PATCH 3/3] iio: pressure: dps310: keep the user's settings across a timeout reset Rupesh Majhi
2026-10-30  8:22   ` Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261101173009.3549f50d@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=eajames@linux.ibm.com \
    --cc=joel@jms.id.au \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=paulius.zaleckas@gmail.com \
    --cc=sashiko-bot@kernel.org \
    --cc=zoone.rupert@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®